Completed
Push — master ( 73b3d9...d4697b )
by Ítalo
02:38
created

LazyKeyedIterableTrait   F

Complexity

Total Complexity 51

Size/Duplication

Total Lines 264
Duplicated Lines 14.39 %

Coupling/Cohesion

Components 0
Dependencies 21

Importance

Changes 2
Bugs 0 Features 0
Metric Value
c 2
b 0
f 0
dl 38
loc 264
wmc 51
lcom 0
cbo 21
rs 3.4503

33 Methods

Rating   Name   Duplication   Size   Complexity  
A toArray() 0 9 2
A toValuesArray() 0 9 2
A toKeysArray() 0 9 2
A toVector() 0 4 1
A toImmVector() 0 4 1
A toMap() 0 4 1
A toImmMap() 0 4 1
A toSet() 0 4 1
A toImmSet() 0 4 1
A lazy() 0 4 1
A values() 0 4 1
A keys() 0 4 1
A map() 0 4 1
A mapWithKey() 0 4 1
A filter() 0 4 1
A filterWithKey() 0 4 1
A zip() 0 8 2
A take() 0 4 1
A takeWhile() 0 4 1
A skip() 0 4 1
A skipWhile() 0 4 1
A slice() 0 4 1
A concat() 0 8 2
A first() 0 8 2
A firstKey() 0 8 2
A last() 0 8 2
A lastKey() 0 8 2
A each() 0 8 2
A exists() 0 10 3
A concatAll() 12 12 2
A groupBy() 16 16 4
A indexBy() 10 10 2
A reduce() 0 8 2

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like LazyKeyedIterableTrait often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use LazyKeyedIterableTrait, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace Collections\Iterator;
4
5
use Collections\Immutable\ImmArrayList;
6
use Collections\Immutable\ImmDictionary;
7
use Collections\Immutable\ImmSet;
8
use Collections\Map;
9
use Collections\Pair;
10
use Collections\Set;
11
use Collections\Vector;
12
use Collections\VectorInterface;
13
14
trait LazyKeyedIterableTrait
15
{
16
    public function toArray()
17
    {
18
        $arr = [];
19
        foreach ($this as $k => $v) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
20
            $arr[$k] = $v;
21
        }
22
23
        return $arr;
24
    }
25
26
    public function toValuesArray()
27
    {
28
        $arr = [];
29
        foreach ($this as $v) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
30
            $arr[] = $v;
31
        }
32
33
        return $arr;
34
    }
35
36
    public function toKeysArray()
37
    {
38
        $arr = [];
39
        foreach ($this as $k => $_) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
40
            $arr[] = $k;
41
        }
42
43
        return $arr;
44
    }
45
46
    public function toVector()
47
    {
48
        return new Vector($this);
49
    }
50
51
    public function toImmVector()
52
    {
53
        return new ImmArrayList($this);
54
    }
55
56
    public function toMap()
57
    {
58
        return new Map($this);
59
    }
60
61
    public function toImmMap()
62
    {
63
        return new ImmDictionary($this);
64
    }
65
66
    public function toSet()
67
    {
68
        return new Set($this);
69
    }
70
71
    public function toImmSet()
72
    {
73
        return new ImmSet($this);
74
    }
75
76
    public function lazy()
77
    {
78
        return $this;
79
    }
80
81
    public function values()
82
    {
83
        return new LazyValuesIterable($this);
84
    }
85
86
    public function keys()
87
    {
88
        return new LazyKeysIterable($this);
89
    }
90
91
    public function map($callback)
92
    {
93
        return new LazyMapKeyedIterable($this, $callback);
94
    }
95
96
    public function mapWithKey($callback)
97
    {
98
        return new LazyMapWithKeyIterable($this, $callback);
99
    }
100
101
    public function filter($callback)
102
    {
103
        return new LazyFilterKeyedIterable($this, $callback);
104
    }
105
106
    public function filterWithKey($callback)
107
    {
108
        return new LazyFilterWithKeyIterable($this, $callback);
109
    }
110
111
    public function zip($traversable)
112
    {
113
        if (is_array($traversable)) {
114
            $traversable = new ImmDictionary($traversable);
115
        }
116
117
        return new LazyZipKeyedIterable($this, $traversable);
118
    }
119
120
    public function take($n)
121
    {
122
        return new LazyTakeKeyedIterable($this, $n);
123
    }
124
125
    public function takeWhile($fn)
126
    {
127
        return new LazyTakeWhileKeyedIterable($this, $fn);
128
    }
129
130
    public function skip($n)
131
    {
132
        return new LazySkipKeyedIterable($this, $n);
133
    }
134
135
    public function skipWhile($fn)
136
    {
137
        return new LazySkipWhileKeyedIterable($this, $fn);
138
    }
139
140
    public function slice($start, $len)
141
    {
142
        return new LazySliceKeyedIterable($this, $start, $len);
143
    }
144
145
    public function concat($iterable)
146
    {
147
        if (is_array($iterable)) {
148
            $iterable = new ImmDictionary($iterable);
149
        }
150
151
        return new LazyConcatIterable($this, $iterable);
152
    }
153
154
    public function first()
155
    {
156
        foreach ($this as $v) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
157
            return $v;
158
        }
159
160
        return null;
161
    }
162
163
    public function firstKey()
164
    {
165
        foreach ($this as $k => $_) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
166
            return $k;
167
        }
168
169
        return null;
170
    }
171
172
    public function last()
173
    {
174
        $v = null;
175
        foreach ($this as $v) {
0 ignored issues
show
Unused Code introduced by
This foreach statement is empty and can be removed.

This check looks for foreach loops that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.

Consider removing the loop.

Loading history...
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
176
        }
177
178
        return $v;
179
    }
180
181
    public function lastKey()
182
    {
183
        $k = null;
184
        foreach ($this as $k => $_) {
0 ignored issues
show
Unused Code introduced by
This foreach statement is empty and can be removed.

This check looks for foreach loops that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.

Consider removing the loop.

Loading history...
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
185
        }
186
187
        return $k;
188
    }
189
190
    /**
191
     * {@inheritDoc}
192
     * @return $this
193
     */
194
    public function each(callable $callable)
195
    {
196
        foreach ($this as $v) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
197
            $callable($v);
198
        }
199
200
        return $this;
201
    }
202
203
    /**
204
     * {@inheritdoc}
205
     */
206
    public function exists(callable $fn)
207
    {
208
        foreach ($this as $element) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
209
            if ($fn($element)) {
210
                return true;
211
            }
212
        }
213
214
        return false;
215
    }
216
217 View Code Duplication
    public function concatAll()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
218
    {
219
        /** @var VectorInterface $results */
220
        $results = new static();
221
        $this->each(function ($subArray) use ($results) {
222
            foreach ($subArray as $item) {
223
                $results->add($item);
224
            }
225
        });
226
227
        return $results;
228
    }
229
230
    /**
231
     * {@inheritDoc}
232
     * @return $this
233
     */
234 View Code Duplication
    public function groupBy($callback)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
235
    {
236
        $group = new Map();
237
        foreach ($this as $value) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
238
            $key = $callback($value);
239
            if (!$group->containsKey($key)) {
240
                $element = $this instanceof VectorInterface ? new static([$value]) : new Vector([$value]);
0 ignored issues
show
Unused Code introduced by
The call to LazyKeyedIterableTrait::__construct() has too many arguments starting with array($value).

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
241
                $group->add(new Pair($key, $element));
242
            } else {
243
                $value = $group->get($key)->add($value);
244
                $group->set($key, $value);
245
            }
246
        }
247
248
        return $group;
249
    }
250
251
    /**
252
     * {@inheritDoc}
253
     * @return $this
254
     */
255 View Code Duplication
    public function indexBy($callback)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
256
    {
257
        $group = new Map();
258
        foreach ($this as $value) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
259
            $key = $callback($value);
260
            $group->set($key, $value);
261
        }
262
263
        return $group;
264
    }
265
266
    /**
267
     * {@inheritdoc}
268
     */
269
    public function reduce(callable $callback, $initial = null)
270
    {
271
        foreach ($this as $element) {
0 ignored issues
show
Bug introduced by
The expression $this of type this<Collections\Iterator\LazyKeyedIterableTrait> is not traversable.
Loading history...
272
            $initial = $callback($initial, $element);
273
        }
274
275
        return $initial;
276
    }
277
}