Collections\Traits\MapLikeTrait

Complexity

Total Complexity

15

Size/Duplication

Total Lines	112
Duplicated Lines	22.32 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetGet()	0	4	1
A	offsetSet()	0	8	2
A	offsetUnset()	0	4	1
A	set()	0	6	1
A	setAll()	13	13	3
A	add()	0	13	2
A	removeKey()	0	8	1
A	remove()	12	12	2
A	each()	0	8	2

<?php

namespace Collections\Traits;

use Collections\Pair;

trait MapLikeTrait
{
    use ConstMapLikeTrait,
        CommonMutableContainerTrait;

    /**
     * identical to at, implemented for ArrayAccess
     */
    public function offsetGet($offset)
    {
        return $this->at($offset);
    }

    public function offsetSet($offset, $value)
    {
        if (is_null($offset)) {
            $this->add($value);
        } else {
            $this->set($offset, $value);
        }
    }

    public function offsetUnset($offset)
    {
        $this->removeKey($offset);
    }

    /**
     * {@inheritdoc}
     */
    public function set($key, $value)
    {
        $this->container[$key] = $value;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setAll($items)

This method seems to be duplicated in your project.

    {
        $this->validateTraversable($items);

        foreach ($items as $key => $item) {
            if (is_array($item)) {
                $item = new static($item);

The call to MapLikeTrait::__construct() has too many arguments starting with $item.

            }
            $this->set($key, $item);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function add($pair)
    {
        if (!($pair instanceof Pair)) {
            throw new \InvalidArgumentException('Parameter must be an instance of Pair');
        }

        list($key, $value) = $pair;

        $this->validateKeyExists($key);
        $this->set($key, $value);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function removeKey($key)
    {
        $this->validateKeyDoesNotExists($key);

        unset($this->container[$key]);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function remove($element)

This method seems to be duplicated in your project.

    {
        $key = array_search($element, $this->container);

        if (false === $key) {
            throw new \OutOfBoundsException('No element found in the collection');
        }

        $this->removeKey($key);

        return $this;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function each(callable $callable)
    {
        foreach ($this as $k => $v) {

The expression $this of type this<Collections\Traits\MapLikeTrait> is not traversable.

            $callable($v, $k);
        }

        return $this;
    }
}