StrictKeyedIterableTrait - Code Metrics - Inspection of "Fixes bug with string comparer" - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e2954...632183 )

by Ítalo

created 2015-12-17 15:37 UTC

StrictKeyedIterableTrait B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	245
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

6.94%

Importance

Changes	5
Bugs	0	Features	2

Metric	Value
wmc	51
c	5
b	0
f	2
lcom	0
cbo	5
dl	0
loc	245
ccs	10
cts	144
cp	0.0694
rs	8.3206

19 Methods

Rating	Name	Size	Complexity
A	keys()	9	2
A	map()	9	2
A	mapWithKey()	9	2
A	filter()	11	3
A	filterWithKey()	11	3
A	zip()	14	3
A	take()	15	4
A	takeWhile()	12	3
A	skip()	13	3
A	skipWhile()	16	4
B	slice()	19	5
A	concat()	15	3
A	first()	8	2
A	firstKey()	8	2
A	last()	8	2
A	lastKey()	8	2
A	each()	8	2
A	exists()	10	3
A	concatAll()	12	1

How to fix Complexity

<?php

namespace Collections\Traits;

use Collections\ArrayList;
use Collections\Dictionary;
use Collections\Iterable;
use Collections\MapInterface;

trait StrictKeyedIterableTrait
{
    use CommonMutableContainerTrait;

    public function keys()
    {
        $res = new ArrayList();
        foreach ($this as $k => $_) {

            $res[] = $k;
        }

        return $res;
    }

    public function map(callable $callback)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            $res[$k] = $callback($v);
        }

        return $res;
    }

    public function mapWithKey($callback)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            $res[$k] = $callback($k, $v);
        }

        return $res;
    }

    public function filter(callable $callback)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            if ($callback($v)) {
                $res[$k] = $v;
            }
        }

        return $res;
    }

    public function filterWithKey($callback)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            if ($callback($k, $v)) {
                $res[$k] = $v;
            }
        }

        return $res;
    }

    public function zip($iterable)
    {
        $res = new Dictionary();
        $it = $iterable->getIterator();
        foreach ($this as $k => $v) {

            if (!$it->valid()) {
                break;
            }
            $res[$k] = new Pair($v, $it->current());
            $it->next();
        }

        return $res;
    }

    public function take($size = 1)
    {
        $res = new Dictionary();
        if ($size <= 0) {
            return $res;
        }
        foreach ($this as $k => $v) {

            $res[$k] = $v;
            if (--$size === 0) {
                break;
            }
        }

        return $res;
    }

    public function takeWhile($fn)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            if (!$fn($v)) {
                break;
            }
            $res[$k] = $v;
        }

        return $res;
    }

    public function skip($n)
    {
        $res = new Dictionary();
        foreach ($this as $k => $v) {

            if ($n <= 0) {
                $res[$k] = $v;
            } else {
                --$n;
            }
        }

        return $res;
    }

    public function skipWhile($fn)
    {
        $res = new Dictionary();
        $skip = true;
        foreach ($this as $k => $v) {

            if ($skip) {
                if ($fn($v)) {
                    continue;
                }
                $skip = false;
            }
            $res[$k] = $v;
        }

        return $res;
    }

    public function slice($start, $lenght)
    {
        $res = new Dictionary();
        if ($lenght <= 0) {
            return $res;
        }
        foreach ($this as $k => $v) {

            if ($start !== 0) {
                --$start;
                continue;
            }
            $res[$k] = $v;
            if (--$lenght === 0) {
                break;
            }
        }

        return $res;
    }

    public function concat(\Traversable $iterable)
    {
        $res = [];

        foreach ($this as $k => $v) {

            $res[$k] = $v;
        }

        foreach ($iterable as $k => $v) {
            $res[$k] = $v;
        }
        $this->container = $res;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    public function first()
    {
        foreach ($this as $v) {

            return $v;
        }

        return null;
    }

    public function firstKey()
    {
        foreach ($this as $k => $_) {

            return $k;
        }

        return null;
    }

    public function last()
    {
        $v = null;
        foreach ($this as $v) {

        }

        return $v;
    }

    public function lastKey()
    {
        $k = null;
        foreach ($this as $k => $_) {

        }

        return $k;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function each(callable $callable)
    {
        foreach ($this as $k => $v) {

            $callable($v, $k);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function exists(callable $fn)
    {
        foreach ($this as $key => $element) {

            if ($fn($key, $element)) {
                return true;
            }
        }

        return false;
    }

    public function concatAll()
    {
        /** @var MapInterface $results */
        $results = new static();
        $this->each(function (Iterable $subArray) use ($results) {
            $subArray->each(function ($item, $key) use ($results) {
                $results->add($key, $item);
            });
        });

        return $results;
    }
}


1		<?php
2
3		namespace Collections\Traits;
4
5		use Collections\ArrayList;
6		use Collections\Dictionary;
7		use Collections\Iterable;
8		use Collections\MapInterface;
9
10		trait StrictKeyedIterableTrait
11		{
12		use CommonMutableContainerTrait;
13
14		public function keys()
15		{
16		$res = new ArrayList();
17		foreach ($this as $k => $_) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
18		$res[] = $k;
19		}
20
21		return $res;
22		}
23
24		public function map(callable $callback)
25		{
26		$res = new Dictionary();
27		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
28		$res[$k] = $callback($v);
29		}
30
31		return $res;
32		}
33
34		public function mapWithKey($callback)
35		{
36		$res = new Dictionary();
37		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
38		$res[$k] = $callback($k, $v);
39		}
40
41		return $res;
42		}
43
44		public function filter(callable $callback)
45		{
46		$res = new Dictionary();
47		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
48		if ($callback($v)) {
49		$res[$k] = $v;
50		}
51		}
52
53		return $res;
54		}
55
56		public function filterWithKey($callback)
57		{
58		$res = new Dictionary();
59		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
60		if ($callback($k, $v)) {
61		$res[$k] = $v;
62		}
63		}
64
65		return $res;
66		}
67
68		public function zip($iterable)
69		{
70		$res = new Dictionary();
71		$it = $iterable->getIterator();
72		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
73		if (!$it->valid()) {
74		break;
75		}
76		$res[$k] = new Pair($v, $it->current());
77		$it->next();
78		}
79
80		return $res;
81		}
82
83		public function take($size = 1)
84		{
85		$res = new Dictionary();
86		if ($size <= 0) {
87		return $res;
88		}
89		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
90		$res[$k] = $v;
91		if (--$size === 0) {
92		break;
93		}
94		}
95
96		return $res;
97		}
98
99		public function takeWhile($fn)
100		{
101		$res = new Dictionary();
102		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
103		if (!$fn($v)) {
104		break;
105		}
106		$res[$k] = $v;
107		}
108
109		return $res;
110		}
111
112		public function skip($n)
113		{
114		$res = new Dictionary();
115		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
116		if ($n <= 0) {
117		$res[$k] = $v;
118		} else {
119		--$n;
120		}
121		}
122
123		return $res;
124		}
125
126		public function skipWhile($fn)
127		{
128		$res = new Dictionary();
129		$skip = true;
130		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
131		if ($skip) {
132		if ($fn($v)) {
133		continue;
134		}
135		$skip = false;
136		}
137		$res[$k] = $v;
138		}
139
140		return $res;
141		}
142
143		public function slice($start, $lenght)
144		{
145		$res = new Dictionary();
146		if ($lenght <= 0) {
147		return $res;
148		}
149		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
150		if ($start !== 0) {
151		--$start;
152		continue;
153		}
154		$res[$k] = $v;
155		if (--$lenght === 0) {
156		break;
157		}
158		}
159
160		return $res;
161		}
162
163	1	public function concat(\Traversable $iterable)
164		{
165	1	$res = [];
166
167	1	foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
168	1	$res[$k] = $v;
169	1	}
170
171	1	foreach ($iterable as $k => $v) {
172	1	$res[$k] = $v;
173	1	}
174	1	$this->container = $res;
		0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
175
176	1	return $this;
177		}
178
179		public function first()
180		{
181		foreach ($this as $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
182		return $v;
183		}
184
185		return null;
186		}
187
188		public function firstKey()
189		{
190		foreach ($this as $k => $_) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
191		return $k;
192		}
193
194		return null;
195		}
196
197		public function last()
198		{
199		$v = null;
200		foreach ($this as $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
201		}
202
203		return $v;
204		}
205
206		public function lastKey()
207		{
208		$k = null;
209		foreach ($this as $k => $_) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
210		}
211
212		return $k;
213		}
214
215		/**
216		* {@inheritDoc}
217		* @return $this
218		*/
219		public function each(callable $callable)
220		{
221		foreach ($this as $k => $v) {
		0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
222		$callable($v, $k);
223		}
224
225		return $this;
226		}
227
228		/**
229		* {@inheritdoc}
230		*/
231		public function exists(callable $fn)
232		{
233		foreach ($this as $key => $element) {
		0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictKeyedIterableTrait>` is not traversable. Loading history...
234		if ($fn($key, $element)) {
235		return true;
236		}
237		}
238
239		return false;
240		}
241
242		public function concatAll()
243		{
244		/** @var MapInterface $results */
245		$results = new static();
246		$this->each(function (Iterable $subArray) use ($results) {
247		$subArray->each(function ($item, $key) use ($results) {
248		$results->add($key, $item);
249		});
250		});
251
252		return $results;
253		}
254		}
255

italolelis / collections

Push — master ( 0e2954...632183 )

StrictKeyedIterableTrait B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

19 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like