Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class Stack extends SplStack implements StackInterface, \JsonSerializable |
|
|
|
|||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Inserts multiples objects at the top of the Stack. |
||
| 15 | * @param array $items The Objects to push onto the Stack. The value <b>can</b> be null. |
||
| 16 | * @return $this|Stack |
||
| 17 | */ |
||
| 18 | 1 | public function pushMultiple($items) |
|
| 19 | { |
||
| 20 | 1 | foreach ($items as $item) { |
|
| 21 | 1 | $this->push($item); |
|
| 22 | 1 | } |
|
| 23 | |||
| 24 | 1 | return $this; |
|
| 25 | } |
||
| 26 | |||
| 27 | public static function fromArray(array $arr) |
||
| 28 | { |
||
| 29 | $collection = new Stack(); |
||
| 30 | foreach ($arr as $v) { |
||
| 31 | if (is_array($v)) { |
||
| 32 | $collection->push(static::fromArray($v)); |
||
| 33 | } else { |
||
| 34 | $collection->push($v); |
||
| 35 | } |
||
| 36 | } |
||
| 37 | |||
| 38 | return $collection; |
||
| 39 | } |
||
| 40 | |||
| 41 | /** |
||
| 42 | * {@inheritdoc} |
||
| 43 | */ |
||
| 44 | 2 | public function toArray() |
|
| 45 | { |
||
| 46 | 2 | $array = array(); |
|
| 47 | 2 | foreach ($this as $key => $value) { |
|
| 48 | 2 | if ($value instanceof Enumerable) { |
|
| 49 | $array[$key] = $value->toArray(); |
||
| 50 | } else { |
||
| 51 | 2 | $array[$key] = $value; |
|
| 52 | } |
||
| 53 | 2 | } |
|
| 54 | |||
| 55 | 2 | return $array; |
|
| 56 | } |
||
| 57 | |||
| 58 | /** |
||
| 59 | * {@inheritdoc} |
||
| 60 | */ |
||
| 61 | 2 | public function __toString() |
|
| 65 | |||
| 66 | /** |
||
| 67 | * (PHP 5 >= 5.4.0)<br/> |
||
| 68 | * Specify data which should be serialized to JSON |
||
| 69 | * @link http://php.net/manual/en/jsonserializable.jsonserialize.php |
||
| 70 | * @return mixed data which can be serialized by <b>json_encode</b>, |
||
| 71 | * which is a value of any type other than a resource. |
||
| 72 | */ |
||
| 73 | public function jsonSerialize() |
||
| 77 | } |
||
| 78 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.