SortTrait - Code Metrics - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

SortTrait A
last analyzed 2016-12-13 14:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	52.94 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	0
cbo	0
dl	18
loc	34
ccs	12
cts	12
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	sort()	9	9	2
A	sortByKey()	9	9	2

How to fix Duplicated Code

<?php

// Copyright (c) Lellys Informática. All rights reserved. See License.txt in the project root for license information.
namespace Collections;

use Collections\Generic\ComparerInterface;

/**
 * Provides utility protected methods for extracting a property or column
 * from an array or object.
 */
trait SortTrait
{
    /**
     * Sorts the elements in the entire Collection<T> using the specified comparer.
     * @param ComparerInterface $comparer The ComparerInterface implementation to use when comparing elements, or null
     * to use the default comparer Comparer<T>.Default.
     * @return $this
     */
    public function sort(ComparerInterface $comparer = null)

    {
        if ($comparer === null) {
            $comparer = $this->getDefaultComparer();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        usort($this->container, array($comparer, 'compare'));
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    /**
     * Sorts the keys in the entire Collection<T> using the specified comparer.
     * @param ComparerInterface $comparer The ComparerInterface implementation to use when comparing elements, or
     * null to use the default comparer Comparer<T>.Default.
     * @return $this
     */
    public function sortByKey(ComparerInterface $comparer = null)

    {
        if ($comparer === null) {
            $comparer = $this->getDefaultComparer();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        uksort($this->container, array($comparer, 'compare'));

        return $this;
    }
}


1			<?php
2
3			// Copyright (c) Lellys Informática. All rights reserved. See License.txt in the project root for license information.
4			namespace Collections;
5
6			use Collections\Generic\ComparerInterface;
7
8			/**
9			* Provides utility protected methods for extracting a property or column
10			* from an array or object.
11			*/
12			trait SortTrait
13			{
14			/**
15			* Sorts the elements in the entire Collection<T> using the specified comparer.
16			* @param ComparerInterface $comparer The ComparerInterface implementation to use when comparing elements, or null
17			* to use the default comparer Comparer<T>.Default.
18			* @return $this
19			*/
20	1	View Code Duplication	public function sort(ComparerInterface $comparer = null)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21			{
22	1		if ($comparer === null) {
23	1		$comparer = $this->getDefaultComparer();
			0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report It seems like `getDefaultComparer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24	1		}
25	1		usort($this->container, array($comparer, 'compare'));
			0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26
27	1		return $this;
28			}
29
30			/**
31			* Sorts the keys in the entire Collection<T> using the specified comparer.
32			* @param ComparerInterface $comparer The ComparerInterface implementation to use when comparing elements, or
33			* null to use the default comparer Comparer<T>.Default.
34			* @return $this
35			*/
36	1	View Code Duplication	public function sortByKey(ComparerInterface $comparer = null)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37			{
38	1		if ($comparer === null) {
39	1		$comparer = $this->getDefaultComparer();
			0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report It seems like `getDefaultComparer()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40	1		}
41	1		uksort($this->container, array($comparer, 'compare'));
42
43	1		return $this;
44			}
45			}
46

italolelis / collections

SortTrait A last analyzed 2016-12-13 14:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

SortTrait A
last analyzed 2016-12-13 14:12 UTC