Isolate\Framework\LazyObjects\DefinitionCollection

Complexity

Total Complexity

8

Size/Duplication

Total Lines	60
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	12	12	2
A	add()	7	7	1
A	getIterator()	4	4	1
A	validateFactory()	6	6	2
A	validateDefinition()	6	6	2

<?php

namespace Isolate\Framework\LazyObjects;

use Isolate\Framework\LazyObjects\Definition\Factory;
use Isolate\LazyObjects\Proxy\Definition;
use Traversable;

class DefinitionCollection implements \IteratorAggregate

This class seems to be duplicated in your project.

{
    /**
     * @var Definition[]|array
     */
    private $definitions;

    public function __construct(array $elements = array())
    {
        $this->definitions = [];
        
        foreach ($elements as $definitionFactory) {
            $this->validateFactory($definitionFactory);
            $definition = $definitionFactory->createDefinition();
            $this->validateDefinition($definition);

            $this->definitions[] = $definition;
        }
    }

    /**
     * @param mixed $value

There is no parameter named $value. Was it maybe removed?

     * @return bool
     */
    public function add(Factory $definitionFactory)
    {
        $definition = $definitionFactory->createDefinition();
        $this->validateDefinition($definition);
        
        $this->definitions[] = $definition;
    }

    /**
     * @return \ArrayIterator
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->definitions);
    }

    /**
     * @param $definitionFactory
     */
    private function validateFactory($definitionFactory)
    {
        if (!$definitionFactory instanceof Factory) {
            throw new \InvalidArgumentException("Definition collection elements needs to implement Definition\\Factory.");
        }
    }

    /**
     * @param $definition
     */
    private function validateDefinition($definition)
    {
        if (!$definition instanceof Definition) {
            throw new \RuntimeException("Definition\\Factory needs to create Entity\\Definition instance.");
        }
    }
}