Completed
Branch scrutinizer-score-improvements (437d31)
by dan
02:16
created
ImageProcessing/ImageManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -145,6 +145,9 @@
 block discarded – undo
145 145
         return $this->fileSystem->has($path);
146 146
     }
147 147
 
148
+    /**
149
+     * @param string $customStyleString
150
+     */
148 151
     public function createCustomStyledImage(ResponsiveImageInterface $image, $customStyleString, $forceGenerate = false)
149 152
     {
150 153
         // @TODO: To avoid creating images, that already exist, check if it exists, need a way to disable this checking
Please login to merge, or discard this patch.
StyleManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -60,6 +60,9 @@
 block discarded – undo
60 60
         }
61 61
     }
62 62
 
63
+    /**
64
+     * @param string $src
65
+     */
63 66
     public function setImageAttributes(ResponsiveImageInterface $image, $styleName = null, $src = null)
64 67
     {
65 68
         // Use the style data to figure out the width and height for this image
Please login to merge, or discard this patch.
Tests/Entity/TestImage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -60,6 +60,9 @@
 block discarded – undo
60 60
         return $this->path;
61 61
     }
62 62
 
63
+    /**
64
+     * @param string $path
65
+     */
63 66
     public function setPath($path)
64 67
     {
65 68
         $this->path = $path;
Please login to merge, or discard this patch.
Tests/ResponsiveImageTestCase.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -77,6 +77,9 @@
 block discarded – undo
77 77
         return $exitCode;
78 78
     }
79 79
 
80
+    /**
81
+     * @param string $serviceName
82
+     */
80 83
     protected function getService($serviceName)
81 84
     {
82 85
         if (empty($this->testKernel)) {
Please login to merge, or discard this patch.
Twig/ResponsiveImageExtension.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     }
52 52
 
53 53
     /**
54
-     * @return array
54
+     * @return \Twig_SimpleFunction[]
55 55
      */
56 56
     public function getFunctions()
57 57
     {
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      * @param                          $pictureSetName
102 102
      * @param                          $selector
103 103
      *
104
-     * @return mixed|string
104
+     * @return string
105 105
      */
106 106
     public function generateBackgroundImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $selector)
107 107
     {
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
      * @param                          $pictureSetName
126 126
      * @param bool                     $generate
127 127
      *
128
-     * @return mixed|string
128
+     * @return string
129 129
      */
130 130
     public function generatePictureImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
131 131
     {
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      * @internal
147 147
      *
148 148
      * @param array $data
149
-     * @param array $keys
149
+     * @param string[] $keys
150 150
      */
151 151
     private function convertPathsToUrls(array &$data, array $keys)
152 152
     {
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
      * @param                          $pictureSetName
189 189
      * @param bool                     $generate
190 190
      *
191
-     * @return mixed|string
191
+     * @return string
192 192
      */
193 193
     public function generateSizesImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
194 194
     {
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
      * @param null                     $styleName
217 217
      * @param bool                     $generate
218 218
      *
219
-     * @return mixed|string
219
+     * @return string
220 220
      */
221 221
     public function generateStyledImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null, $generate = false)
222 222
     {
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      * @param string                   $width
232 232
      * @param null                     $height
233 233
      *
234
-     * @return mixed|string
234
+     * @return string
235 235
      */
236 236
     public function cropImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = null)
237 237
     {
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
      * @param string                   $width
251 251
      * @param string                   $height
252 252
      *
253
-     * @return mixed|string
253
+     * @return string
254 254
      */
255 255
     public function scaleImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = '')
256 256
     {
@@ -266,9 +266,9 @@  discard block
 block discarded – undo
266 266
     /**
267 267
      * @param \Twig_Environment        $environment
268 268
      * @param ResponsiveImageInterface $image
269
-     * @param null                     $styleName
269
+     * @param null|string                     $styleName
270 270
      *
271
-     * @return mixed|string
271
+     * @return string
272 272
      */
273 273
     protected function renderImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null)
274 274
     {
Please login to merge, or discard this patch.