Completed
Branch scrutinizer-score-improvements (437d31)
by dan
02:16
created
ImageProcessing/ImageStyler.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $this->image->resize(
99 99
             $width,
100 100
             $height,
101
-            function ($constraint) {
101
+            function($constraint) {
102 102
                 $constraint->aspectRatio();
103 103
             }
104 104
         );
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                     $this->image->fit(
178 178
                         $this->styleData['width'],
179 179
                         $this->styleData['height'],
180
-                        function ($constraint) {
180
+                        function($constraint) {
181 181
                             $constraint->upsize();
182 182
                         }
183 183
                     );
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,8 +153,7 @@
 block discarded – undo
153 153
                     // just cut out the crop rectangle.
154 154
                     if (empty($this->getCoordinates('focus'))) {
155 155
                         $this->doCropRectangle();
156
-                    }
157
-                    else {
156
+                    } else {
158 157
 
159 158
                         $focusOffsetFinder = new FocusCropDataCalculator(
160 159
                             $this->getCoordinates('crop'),
Please login to merge, or discard this patch.
ImageProcessing/FocusCropDataCalculator.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -161,10 +161,10 @@
 block discarded – undo
161 161
         $focusY2 = $this->focusCoordinates[3];
162 162
 
163 163
         if ($type == 'near') {
164
-            $point = ${'focus' . $axis . '1'} - ${'crop' . $axis . '1'};
164
+            $point = ${'focus' . $axis . '1'} -${'crop' . $axis . '1'};
165 165
         }
166 166
         else {
167
-            $point = ${'focus' . $axis . '2'} - ${'crop' . $axis . '1'};
167
+            $point = ${'focus' . $axis . '2'} -${'crop' . $axis . '1'};
168 168
         }
169 169
 
170 170
         return $point;
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -76,12 +76,10 @@  discard block
 block discarded – undo
76 76
 
77 77
         if ($imageAspectRatio > $styleAspectRatio) {
78 78
             $axis = 'x';
79
-        }
80
-        else {
79
+        } else {
81 80
             if ($imageAspectRatio < $styleAspectRatio) {
82 81
                 $axis = 'y';
83
-            }
84
-            else {
82
+            } else {
85 83
                 return [
86 84
                     'width'  => $newWidth,
87 85
                     'height' => $newHeight,
@@ -162,8 +160,7 @@  discard block
 block discarded – undo
162 160
 
163 161
         if ($type == 'near') {
164 162
             $point = ${'focus' . $axis . '1'} - ${'crop' . $axis . '1'};
165
-        }
166
-        else {
163
+        } else {
167 164
             $point = ${'focus' . $axis . '2'} - ${'crop' . $axis . '1'};
168 165
         }
169 166
 
Please login to merge, or discard this patch.
ImageProcessing/CoordinateGeometry.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $size->resize(
52 52
             $scaleX,
53 53
             $scaleY,
54
-            function ($constraint) {
54
+            function($constraint) {
55 55
                 $constraint->aspectRatio();
56 56
             }
57 57
         );
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,8 +80,7 @@
 block discarded – undo
80 80
         $axis = strtolower($axis);
81 81
         if ($axis == 'x') {
82 82
             return $this->x2 - $this->x1;
83
-        }
84
-        else {
83
+        } else {
85 84
             return $this->y2 - $this->y1;
86 85
         }
87 86
     }
Please login to merge, or discard this patch.
Url/UrlBuilder.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -149,8 +149,7 @@
 block discarded – undo
149 149
         if ($urlBits[0] == 'http' || $urlBits[0] == 'https') {
150 150
             $urlPrefix = $urlBits[0] . '://';
151 151
             $urlPath   = $urlBits[1];
152
-        }
153
-        else {
152
+        } else {
154 153
             $urlPrefix = '/';
155 154
             $urlPath   = $url;
156 155
         }
Please login to merge, or discard this patch.
Tests/File/FileToObjectTest.php 3 patches
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,21 +45,21 @@
 block discarded – undo
45 45
 
46 46
         // Mock the EntityManager to return the mock of the repository
47 47
         $entityManager = $this->getMockBuilder(EntityManager::class)
48
-                              ->disableOriginalConstructor()
49
-                              ->getMock();
48
+                                ->disableOriginalConstructor()
49
+                                ->getMock();
50 50
 
51 51
         $entityManager->expects($this->any())
52
-                      ->method('getRepository')
53
-                      ->will($this->returnValue($imageRepository));
52
+                        ->method('getRepository')
53
+                        ->will($this->returnValue($imageRepository));
54 54
 
55 55
         // The mock the ImageEntityName
56 56
         $nameResolver = $this->getMockBuilder(ImageEntityNameResolver::class)
57
-                             ->disableOriginalConstructor()
58
-                             ->getMock();
57
+                                ->disableOriginalConstructor()
58
+                                ->getMock();
59 59
 
60 60
         $nameResolver->expects($this->once())
61
-                     ->method('getClassName')
62
-                     ->will($this->returnValue('ResponsiveImage'));
61
+                        ->method('getClassName')
62
+                        ->will($this->returnValue('ResponsiveImage'));
63 63
 
64 64
         $fileToObject = new FileToObject($entityManager, $nameResolver);
65 65
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
                         ->method('findImageFromFilename')
32 32
                         ->will(
33 33
                             $this->returnCallback(
34
-                                function ($filename) {
34
+                                function($filename) {
35 35
                                     $image = new TestImage();
36 36
                                     if ($filename === $image->getPath()) {
37 37
                                         return $image;
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@
 block discarded – undo
35 35
                                     $image = new TestImage();
36 36
                                     if ($filename === $image->getPath()) {
37 37
                                         return $image;
38
-                                    }
39
-                                    else {
38
+                                    } else {
40 39
                                         return null;
41 40
                                     }
42 41
                                 }
Please login to merge, or discard this patch.
Tests/File/FilenameTransliteratorTest.php 3 patches
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -20,29 +20,29 @@
 block discarded – undo
20 20
     {
21 21
         // Mock the repository so it returns the mock of the Image repository.
22 22
         $fileToObject = $this->getMockBuilder(FileToObject::class)
23
-                             ->disableOriginalConstructor()
24
-                             ->getMock();
23
+                                ->disableOriginalConstructor()
24
+                                ->getMock();
25 25
 
26 26
         $fileToObject->expects($this->any())
27
-                     ->method('getObjectFromFilename')
28
-                     ->will(
29
-                         $this->returnCallback(
30
-                             function ($filename) {
31
-                                 $existingFilenames = [
32
-                                     'test.jpg',
33
-                                     'test_1.jpg',
34
-                                 ];
35
-                                 if (in_array($filename, $existingFilenames)) {
36
-                                     $image = new TestImage();
37
-
38
-                                     return $image;
39
-                                 }
40
-                                 else {
41
-                                     return null;
42
-                                 }
43
-                             }
44
-                         )
45
-                     );
27
+                        ->method('getObjectFromFilename')
28
+                        ->will(
29
+                            $this->returnCallback(
30
+                                function ($filename) {
31
+                                    $existingFilenames = [
32
+                                        'test.jpg',
33
+                                        'test_1.jpg',
34
+                                    ];
35
+                                    if (in_array($filename, $existingFilenames)) {
36
+                                        $image = new TestImage();
37
+
38
+                                        return $image;
39
+                                    }
40
+                                    else {
41
+                                        return null;
42
+                                    }
43
+                                }
44
+                            )
45
+                        );
46 46
 
47 47
         $transliterator = new FilenameTransliterator($fileToObject);
48 48
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
                      ->method('getObjectFromFilename')
28 28
                      ->will(
29 29
                          $this->returnCallback(
30
-                             function ($filename) {
30
+                             function($filename) {
31 31
                                  $existingFilenames = [
32 32
                                      'test.jpg',
33 33
                                      'test_1.jpg',
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,7 @@
 block discarded – undo
36 36
                                      $image = new TestImage();
37 37
 
38 38
                                      return $image;
39
-                                 }
40
-                                 else {
39
+                                 } else {
41 40
                                      return null;
42 41
                                  }
43 42
                              }
Please login to merge, or discard this patch.
Tests/File/FileValidatorTest.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@  discard block
 block discarded – undo
27 27
     {
28 28
         $uploadedFile = $this->getMockFileUpload();
29 29
         $uploadedFile->expects($this->once())
30
-                     ->method('getClientOriginalExtension')
31
-                     ->will(
32
-                         $this->returnValue('jpg')
33
-                     );
30
+                        ->method('getClientOriginalExtension')
31
+                        ->will(
32
+                            $this->returnValue('jpg')
33
+                        );
34 34
         $uploadedFile->expects($this->once())
35
-                     ->method('guessExtension')
36
-                     ->will(
37
-                         $this->returnValue('jpg')
38
-                     );
35
+                        ->method('guessExtension')
36
+                        ->will(
37
+                            $this->returnValue('jpg')
38
+                        );
39 39
 
40 40
         // Test the validator.
41 41
         $validator = new FileValidator();
@@ -49,15 +49,15 @@  discard block
 block discarded – undo
49 49
     {
50 50
         $uploadedFile = $this->getMockFileUpload();
51 51
         $uploadedFile->expects($this->once())
52
-                     ->method('getClientOriginalExtension')
53
-                     ->will(
54
-                         $this->returnValue('doc')
55
-                     );
52
+                        ->method('getClientOriginalExtension')
53
+                        ->will(
54
+                            $this->returnValue('doc')
55
+                        );
56 56
         $uploadedFile->expects($this->once())
57
-                     ->method('guessExtension')
58
-                     ->will(
59
-                         $this->returnValue('doc')
60
-                     );
57
+                        ->method('guessExtension')
58
+                        ->will(
59
+                            $this->returnValue('doc')
60
+                        );
61 61
 
62 62
         // Test the validator.
63 63
         $validator = new FileValidator();
@@ -71,15 +71,15 @@  discard block
 block discarded – undo
71 71
     {
72 72
         $uploadedFile = $this->getMockFileUpload();
73 73
         $uploadedFile->expects($this->once())
74
-                     ->method('getClientOriginalExtension')
75
-                     ->will(
76
-                         $this->returnValue('jpg')
77
-                     );
74
+                        ->method('getClientOriginalExtension')
75
+                        ->will(
76
+                            $this->returnValue('jpg')
77
+                        );
78 78
         $uploadedFile->expects($this->once())
79
-                     ->method('guessExtension')
80
-                     ->will(
81
-                         $this->returnValue('png')
82
-                     );
79
+                        ->method('guessExtension')
80
+                        ->will(
81
+                            $this->returnValue('png')
82
+                        );
83 83
 
84 84
         // Test the validator.
85 85
         $validator = new FileValidator();
Please login to merge, or discard this patch.
Validator/Constraints/CropFocusCoordinatesValidator.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@
 block discarded – undo
53 53
 
54 54
         if (!$valid) {
55 55
             $this->context->buildViolation($constraint->message)
56
-                          ->setParameter('{{ string }}', $value)
57
-                          ->addViolation()
56
+                            ->setParameter('{{ string }}', $value)
57
+                            ->addViolation()
58 58
             ;
59 59
         }
60 60
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,7 @@
 block discarded – undo
36 36
         $testValue = str_replace(' ', '', $value);
37 37
         if (!preg_match('/^(\d+),(\d+),(\d+),(\d+):(\d+),(\d+),(\d+),(\d+)$/', $testValue, $matches)) {
38 38
             $valid = false;
39
-        }
40
-        else {
39
+        } else {
41 40
             // Check the focus rectangle is inside the crop rectangle.
42 41
             $cropFocusCoordinates = explode(':', $testValue);
43 42
             $crop                 = explode(',', $cropFocusCoordinates[0]);
Please login to merge, or discard this patch.
Uploader.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,8 +114,7 @@
 block discarded – undo
114 114
             if (!empty($uploaderEvent)) {
115 115
                 $this->eventDispatcher->dispatch(UploaderEvents::UPLOADER_UPLOADED, $uploaderEvent);
116 116
             }
117
-        }
118
-        else {
117
+        } else {
119 118
             $error = empty($this->error) ? $this->file->getErrorMessage() : $this->error;
120 119
             throw new FileException(
121 120
                 $error
Please login to merge, or discard this patch.