irishdan / ResponsiveImageBundle

ImageProcessing/ImageStyler.php

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $this->image->resize(
             $width,
             $height,
-            function ($constraint) {
+            function($constraint) {
                 $constraint->aspectRatio();
             }
         );
@@ -177,7 +177,7 @@ 
                     $this->image->fit(
                         $this->styleData['width'],
                         $this->styleData['height'],
-                        function ($constraint) {
+                        function($constraint) {
                             $constraint->upsize();
                         }
                     );

Braces +1 added lines, -2 removed lines

@@ -153,8 +153,7 @@
                     // just cut out the crop rectangle.
                     if (empty($this->getCoordinates('focus'))) {
                         $this->doCropRectangle();
-                    }
-                    else {
+                    } else {
 
                         $focusOffsetFinder = new FocusCropDataCalculator(
                             $this->getCoordinates('crop'),

Doc Comments +6 added lines, -2 removed lines

@@ -120,8 +120,8 @@ 
      * Performs the image manipulation using current style information
      * and user defined crop and focus rectangles.
      *
-     * @param       $source
-     * @param       $destination
+     * @param       string $source
+     * @param       string $destination
      * @param array $style
      * @param null $cropFocusCoords
      *
@@ -177,6 +177,10 @@ 
                     $this->image->fit(
                         $this->styleData['width'],
                         $this->styleData['height'],
+
+                        /**
+                         * @param string $constraint
+                         */
                         function ($constraint) {
                             $constraint->upsize();
                         }

ImageProcessing/FocusCropDataCalculator.php

Spacing +2 added lines, -2 removed lines

@@ -161,10 +161,10 @@
         $focusY2 = $this->focusCoordinates[3];
 
         if ($type == 'near') {
-            $point = ${'focus' . $axis . '1'} - ${'crop' . $axis . '1'};
+            $point = ${'focus' . $axis . '1'} -${'crop' . $axis . '1'};
         }
         else {
-            $point = ${'focus' . $axis . '2'} - ${'crop' . $axis . '1'};
+            $point = ${'focus' . $axis . '2'} -${'crop' . $axis . '1'};
         }
 
         return $point;

Doc Comments +6 added lines, -6 removed lines

@@ -97,8 +97,8 @@ 
      * @param string $axis
      * @param        $cropCoordinates
      * @param        $aspectRatio
-     * @param        $newWidth
-     * @param        $newHeight
+     * @param        integer $newWidth
+     * @param        integer $newHeight
      *
      * @return array
      */
@@ -159,7 +159,7 @@ 
     }
 
     /**
-     * @param        $axis
+     * @param        string $axis
      * @param string $type
      *
      * @return mixed
@@ -255,10 +255,10 @@ 
     }
 
     /**
-     * @param $focusNear
+     * @param double $focusNear
      * @param $focusFar
      * @param $cropLength
-     * @param $imageLength
+     * @param integer $imageLength
      *
      * @return array
      */
@@ -296,7 +296,7 @@ 
      * Tests if a given offset is valid.
      * Valid offsets cropped images will include the focus rectangle and will not fall outside of the original image.
      *
-     * @param $point
+     * @param integer $point
      * @param $cropLength
      * @param $imageLength
      * @param $focusNear

Braces +4 added lines, -8 removed lines

@@ -77,11 +77,9 @@ 
 
         if ($imageAspectRatio > $styleAspectRatio) {
             $axis = 'x';
-        }
-        else if ($imageAspectRatio < $styleAspectRatio) {
+        } else if ($imageAspectRatio < $styleAspectRatio) {
             $axis = 'y';
-        }
-        else {
+        } else {
             return [
                 'width'  => $newWidth,
                 'height' => $newHeight,
@@ -114,8 +112,7 @@ 
             // How many times the style height goes into the new height
             $scaleFactor = $newHeight / $this->styleHeight;
             $cropWidth = $this->styleWidth * $scaleFactor;
-        }
-        else {
+        } else {
             $cropWidth = $newWidth;
 
             // How many times the style height goes into the new height
@@ -178,8 +175,7 @@ 
 
         if ($type == 'near') {
             $point = ${'focus' . $axis . '1'} - ${'crop' . $axis . '1'};
-        }
-        else {
+        } else {
             $point = ${'focus' . $axis . '2'} - ${'crop' . $axis . '1'};
         }
 

ImageProcessing/CoordinateGeometry.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
         $size->resize(
             $scaleX,
             $scaleY,
-            function ($constraint) {
+            function($constraint) {
                 $constraint->aspectRatio();
             }
         );

Braces +1 added lines, -2 removed lines

@@ -80,8 +80,7 @@
         $axis = strtolower($axis);
         if ($axis == 'x') {
             return $this->x2 - $this->x1;
-        }
-        else {
+        } else {
             return $this->y2 - $this->y1;
         }
     }

Url/UrlBuilder.php

Braces +1 added lines, -2 removed lines

@@ -149,8 +149,7 @@
         if ($urlBits[0] == 'http' || $urlBits[0] == 'https') {
             $urlPrefix = $urlBits[0] . '://';
             $urlPath   = $urlBits[1];
-        }
-        else {
+        } else {
             $urlPrefix = '/';
             $urlPath   = $url;
         }

Tests/File/FileToObjectTest.php

Indentation +8 added lines, -8 removed lines

@@ -45,21 +45,21 @@
 
         // Mock the EntityManager to return the mock of the repository
         $entityManager = $this->getMockBuilder(EntityManager::class)
-                              ->disableOriginalConstructor()
-                              ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $entityManager->expects($this->any())
-                      ->method('getRepository')
-                      ->will($this->returnValue($imageRepository));
+                        ->method('getRepository')
+                        ->will($this->returnValue($imageRepository));
 
         // The mock the ImageEntityName
         $nameResolver = $this->getMockBuilder(ImageEntityNameResolver::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $nameResolver->expects($this->once())
-                     ->method('getClassName')
-                     ->will($this->returnValue('ResponsiveImage'));
+                        ->method('getClassName')
+                        ->will($this->returnValue('ResponsiveImage'));
 
         $fileToObject = new FileToObject($entityManager, $nameResolver);
 

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
                         ->method('findImageFromFilename')
                         ->will(
                             $this->returnCallback(
-                                function ($filename) {
+                                function($filename) {
                                     $image = new TestImage();
                                     if ($filename === $image->getPath()) {
                                         return $image;

Braces +1 added lines, -2 removed lines

@@ -35,8 +35,7 @@
                                     $image = new TestImage();
                                     if ($filename === $image->getPath()) {
                                         return $image;
-                                    }
-                                    else {
+                                    } else {
                                         return null;
                                     }
                                 }

Tests/File/FilenameTransliteratorTest.php

Indentation +21 added lines, -21 removed lines

@@ -20,29 +20,29 @@
     {
         // Mock the repository so it returns the mock of the Image repository.
         $fileToObject = $this->getMockBuilder(FileToObject::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $fileToObject->expects($this->any())
-                     ->method('getObjectFromFilename')
-                     ->will(
-                         $this->returnCallback(
-                             function ($filename) {
-                                 $existingFilenames = [
-                                     'test.jpg',
-                                     'test_1.jpg',
-                                 ];
-                                 if (in_array($filename, $existingFilenames)) {
-                                     $image = new TestImage();
-
-                                     return $image;
-                                 }
-                                 else {
-                                     return null;
-                                 }
-                             }
-                         )
-                     );
+                        ->method('getObjectFromFilename')
+                        ->will(
+                            $this->returnCallback(
+                                function ($filename) {
+                                    $existingFilenames = [
+                                        'test.jpg',
+                                        'test_1.jpg',
+                                    ];
+                                    if (in_array($filename, $existingFilenames)) {
+                                        $image = new TestImage();
+
+                                        return $image;
+                                    }
+                                    else {
+                                        return null;
+                                    }
+                                }
+                            )
+                        );
 
         $transliterator = new FilenameTransliterator($fileToObject);
 

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
                      ->method('getObjectFromFilename')
                      ->will(
                          $this->returnCallback(
-                             function ($filename) {
+                             function($filename) {
                                  $existingFilenames = [
                                      'test.jpg',
                                      'test_1.jpg',

Braces +1 added lines, -2 removed lines

@@ -36,8 +36,7 @@
                                      $image = new TestImage();
 
                                      return $image;
-                                 }
-                                 else {
+                                 } else {
                                      return null;
                                  }
                              }

Validator/Constraints/CropFocusCoordinatesValidator.php

Indentation +2 added lines, -2 removed lines

@@ -53,8 +53,8 @@
 
         if (!$valid) {
             $this->context->buildViolation($constraint->message)
-                          ->setParameter('{{ string }}', $value)
-                          ->addViolation()
+                            ->setParameter('{{ string }}', $value)
+                            ->addViolation()
             ;
         }
     }

Braces +1 added lines, -2 removed lines

@@ -36,8 +36,7 @@
         $testValue = str_replace(' ', '', $value);
         if (!preg_match('/^(\d+),(\d+),(\d+),(\d+):(\d+),(\d+),(\d+),(\d+)$/', $testValue, $matches)) {
             $valid = false;
-        }
-        else {
+        } else {
             // Check the focus rectangle is inside the crop rectangle.
             $cropFocusCoordinates = explode(':', $testValue);
             $crop                 = explode(',', $cropFocusCoordinates[0]);

Uploader.php

Braces +1 added lines, -2 removed lines

@@ -114,8 +114,7 @@
             if (!empty($uploaderEvent)) {
                 $this->eventDispatcher->dispatch(UploaderEvents::UPLOADER_UPLOADED, $uploaderEvent);
             }
-        }
-        else {
+        } else {
             $error = empty($this->error) ? $this->file->getErrorMessage() : $this->error;
             throw new FileException(
                 $error

EventSubscriber/ImageSubscriber.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use IrishDan\ResponsiveImageBundle\Event\ImageEvent;
 use IrishDan\ResponsiveImageBundle\Event\ImageEvents;
 use IrishDan\ResponsiveImageBundle\ImageProcessing\ImageManager;
-
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 
 /**