irishdan / ResponsiveImageBundle

ImageProcessing/ImageManager.php

Doc Comments +3 added lines

@@ -145,6 +145,9 @@
         return $this->fileSystem->has($path);
     }
 
+    /**
+     * @param string $customStyleString
+     */
     public function createCustomStyledImage(ResponsiveImageInterface $image, $customStyleString, $forceGenerate = false)
     {
         // @TODO: To avoid creating images, that already exist, check if it exists, need a way to disable this checking

StyleManager.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         }
     }
 
+    /**
+     * @param string $src
+     */
     public function setImageAttributes(ResponsiveImageInterface $image, $styleName = null, $src = null)
     {
         // Use the style data to figure out the width and height for this image

Tests/Entity/TestImage.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         return $this->path;
     }
 
+    /**
+     * @param string $path
+     */
     public function setPath($path)
     {
         $this->path = $path;

Tests/ResponsiveImageTestCase.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
         return $exitCode;
     }
 
+    /**
+     * @param string $serviceName
+     */
     protected function getService($serviceName)
     {
         if (empty($this->testKernel)) {

Twig/ResponsiveImageExtension.php

Doc Comments +10 added lines, -10 removed lines

@@ -51,7 +51,7 @@ 
     }
 
     /**
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -101,7 +101,7 @@ 
      * @param                          $pictureSetName
      * @param                          $selector
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateBackgroundImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $selector)
     {
@@ -125,7 +125,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generatePictureImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -146,7 +146,7 @@ 
      * @internal
      *
      * @param array $data
-     * @param array $keys
+     * @param string[] $keys
      */
     private function convertPathsToUrls(array &$data, array $keys)
     {
@@ -188,7 +188,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateSizesImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -216,7 +216,7 @@ 
      * @param null                     $styleName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateStyledImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null, $generate = false)
     {
@@ -231,7 +231,7 @@ 
      * @param string                   $width
      * @param null                     $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function cropImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = null)
     {
@@ -250,7 +250,7 @@ 
      * @param string                   $width
      * @param string                   $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function scaleImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = '')
     {
@@ -266,9 +266,9 @@ 
     /**
      * @param \Twig_Environment        $environment
      * @param ResponsiveImageInterface $image
-     * @param null                     $styleName
+     * @param null|string                     $styleName
      *
-     * @return mixed|string
+     * @return string
      */
     protected function renderImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null)
     {

Tests/File/FileToObjectTest.php

Indentation +8 added lines, -8 removed lines

@@ -45,21 +45,21 @@
 
         // Mock the EntityManager to return the mock of the repository
         $entityManager = $this->getMockBuilder(EntityManager::class)
-                              ->disableOriginalConstructor()
-                              ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $entityManager->expects($this->any())
-                      ->method('getRepository')
-                      ->will($this->returnValue($imageRepository));
+                        ->method('getRepository')
+                        ->will($this->returnValue($imageRepository));
 
         // The mock the ImageEntityName
         $nameResolver = $this->getMockBuilder(ImageEntityNameResolver::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $nameResolver->expects($this->once())
-                     ->method('getClassName')
-                     ->will($this->returnValue('ResponsiveImage'));
+                        ->method('getClassName')
+                        ->will($this->returnValue('ResponsiveImage'));
 
         $fileToObject = new FileToObject($entityManager, $nameResolver);
 

Tests/File/FilenameTransliteratorTest.php

Indentation +21 added lines, -21 removed lines

@@ -20,29 +20,29 @@
     {
         // Mock the repository so it returns the mock of the Image repository.
         $fileToObject = $this->getMockBuilder(FileToObject::class)
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $fileToObject->expects($this->any())
-                     ->method('getObjectFromFilename')
-                     ->will(
-                         $this->returnCallback(
-                             function ($filename) {
-                                 $existingFilenames = [
-                                     'test.jpg',
-                                     'test_1.jpg',
-                                 ];
-                                 if (in_array($filename, $existingFilenames)) {
-                                     $image = new TestImage();
-
-                                     return $image;
-                                 }
-                                 else {
-                                     return null;
-                                 }
-                             }
-                         )
-                     );
+                        ->method('getObjectFromFilename')
+                        ->will(
+                            $this->returnCallback(
+                                function ($filename) {
+                                    $existingFilenames = [
+                                        'test.jpg',
+                                        'test_1.jpg',
+                                    ];
+                                    if (in_array($filename, $existingFilenames)) {
+                                        $image = new TestImage();
+
+                                        return $image;
+                                    }
+                                    else {
+                                        return null;
+                                    }
+                                }
+                            )
+                        );
 
         $transliterator = new FilenameTransliterator($fileToObject);
 

Tests/File/FileValidatorTest.php

Indentation +24 added lines, -24 removed lines

@@ -27,15 +27,15 @@ 
     {
         $uploadedFile = $this->getMockFileUpload();
         $uploadedFile->expects($this->once())
-                     ->method('getClientOriginalExtension')
-                     ->will(
-                         $this->returnValue('jpg')
-                     );
+                        ->method('getClientOriginalExtension')
+                        ->will(
+                            $this->returnValue('jpg')
+                        );
         $uploadedFile->expects($this->once())
-                     ->method('guessExtension')
-                     ->will(
-                         $this->returnValue('jpg')
-                     );
+                        ->method('guessExtension')
+                        ->will(
+                            $this->returnValue('jpg')
+                        );
 
         // Test the validator.
         $validator = new FileValidator();
@@ -49,15 +49,15 @@ 
     {
         $uploadedFile = $this->getMockFileUpload();
         $uploadedFile->expects($this->once())
-                     ->method('getClientOriginalExtension')
-                     ->will(
-                         $this->returnValue('doc')
-                     );
+                        ->method('getClientOriginalExtension')
+                        ->will(
+                            $this->returnValue('doc')
+                        );
         $uploadedFile->expects($this->once())
-                     ->method('guessExtension')
-                     ->will(
-                         $this->returnValue('doc')
-                     );
+                        ->method('guessExtension')
+                        ->will(
+                            $this->returnValue('doc')
+                        );
 
         // Test the validator.
         $validator = new FileValidator();
@@ -71,15 +71,15 @@ 
     {
         $uploadedFile = $this->getMockFileUpload();
         $uploadedFile->expects($this->once())
-                     ->method('getClientOriginalExtension')
-                     ->will(
-                         $this->returnValue('jpg')
-                     );
+                        ->method('getClientOriginalExtension')
+                        ->will(
+                            $this->returnValue('jpg')
+                        );
         $uploadedFile->expects($this->once())
-                     ->method('guessExtension')
-                     ->will(
-                         $this->returnValue('png')
-                     );
+                        ->method('guessExtension')
+                        ->will(
+                            $this->returnValue('png')
+                        );
 
         // Test the validator.
         $validator = new FileValidator();

Validator/Constraints/CropFocusCoordinatesValidator.php

Indentation +2 added lines, -2 removed lines

@@ -53,8 +53,8 @@
 
         if (!$valid) {
             $this->context->buildViolation($constraint->message)
-                          ->setParameter('{{ string }}', $value)
-                          ->addViolation()
+                            ->setParameter('{{ string }}', $value)
+                            ->addViolation()
             ;
         }
     }