Issues in ImageRepository.php - New Issues - Inspection of "Switch to flysystem file systems" - irishdan/ResponsiveImageBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by dan

created 2017-08-15 16:41 UTC

Repository/ImageRepository.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of the IrishDan\ResponsiveImageBundle package.
 *
 * (c) Daniel Byrne <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE file that was distributed with this source
 * code.
 */

namespace IrishDan\ResponsiveImageBundle\Repository;

use Doctrine\ORM\EntityRepository;
use IrishDan\ResponsiveImageBundle\ResponsiveImageRepositoryInterface;

/**
 * Class ImageRepository
 *
 * @package IrishDan\ResponsiveImageBundle\Repository
 */
class ImageRepository extends EntityRepository implements ResponsiveImageRepositoryInterface
{
    /**
     * @param $filename
     *
     * @return mixed
     */
    public function findImageFromFilename($filename)
    {
        return $this->findOneByPath($filename);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}


1			<?php
2			/**
3			* This file is part of the IrishDan\ResponsiveImageBundle package.
4			*
5			* (c) Daniel Byrne <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE file that was distributed with this source
8			* code.
9			*/
10
11			namespace IrishDan\ResponsiveImageBundle\Repository;
12
13			use Doctrine\ORM\EntityRepository;
14			use IrishDan\ResponsiveImageBundle\ResponsiveImageRepositoryInterface;
15
16			/**
17			* Class ImageRepository
18			*
19			* @package IrishDan\ResponsiveImageBundle\Repository
20			*/
21			class ImageRepository extends EntityRepository implements ResponsiveImageRepositoryInterface
22			{
23			/**
24			* @param $filename
25			*
26			* @return mixed
27			*/
28			public function findImageFromFilename($filename)
29			{
30			return $this->findOneByPath($filename);
			0 ignored issues – show Documentation Bug introduced 2017-08-15 16:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneByPath` does not exist on `object<IrishDan\Responsi...sitory\ImageRepository>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
31			}
32			}
33

irishdan / ResponsiveImageBundle

Pull Request — master (#10)

Repository/ImageRepository.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like