IrishDan\ResponsiveImageBundle\EventSubscriber\StyledImagesSubscriber

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getSubscribedEvents()	0	7	1
A	onImagesGenerated()	0	14	2
A	onImagesDeleted()	0	4	1

<?php
/**
 * This file is part of the IrishDan\ResponsiveImageBundle package.
 *
 * (c) Daniel Byrne <danielbyrne@outlook.com>
 *
 * For the full copyright and license information, please view the LICENSE file that was distributed with this source
 * code.
 */

namespace IrishDan\ResponsiveImageBundle\EventSubscriber;

use IrishDan\ResponsiveImageBundle\Event\StyledImagesEvent;
use IrishDan\ResponsiveImageBundle\Event\StyledImagesEvents;
use IrishDan\ResponsiveImageBundle\FileSystem\PrimaryFileSystemWrapper;
use League\Flysystem\FilesystemInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Class StyledImagesSubscriber
 *
 * @package IrishDan\ResponsiveImageBundle\EventSubscriber
 */
class StyledImagesSubscriber implements EventSubscriberInterface
{
    /**
     * @var FilesystemInterface
     */
    private $temporaryFileSystem;
    /**
     * @var FilesystemInterface|null
     */
    private $primaryFileSystem;

    /**
     * StyledImagesSubscriber constructor.
     *
     * @param PrimaryFileSystemWrapper $PrimaryFileSystemWrapper
     * @param FilesystemInterface|null $temporaryFileSystem
     */
    public function __construct(PrimaryFileSystemWrapper $PrimaryFileSystemWrapper, FilesystemInterface $temporaryFileSystem = null)
    {
        $this->temporaryFileSystem = $temporaryFileSystem;
        $this->primaryFileSystem   = $PrimaryFileSystemWrapper->getFileSystem();
    }

    /**
     * @return array
     */
    public static function getSubscribedEvents()
    {
        return [
            StyledImagesEvents::STYLED_IMAGES_GENERATED => 'onImagesGenerated',
            StyledImagesEvents::STYLED_IMAGES_DELETED   => 'onImagesDeleted',
        ];
    }

    /**
     * @param StyledImagesEvent $event
     */
    public function onImagesGenerated(StyledImagesEvent $event)
    {
        $image = $event->getImage();
        $this->temporaryFileSystem->delete($image->getPath());

        $generatedImages = $event->getStyleImageLocationArray();

        foreach ($generatedImages as $style => $relativePath) {
            $contents = $this->temporaryFileSystem->read($relativePath);
            $this->primaryFileSystem->put($relativePath, $contents);

It seems like $contents defined by $this->temporaryFileSystem->read($relativePath) on line 69 can also be of type false; however, League\Flysystem\FilesystemInterface::put() does only seem to accept string, did you maybe forget to handle an error condition?

            $this->temporaryFileSystem->delete($relativePath);
        }
    }

    /**
     * @param StyledImagesEvent $event
     */
    public function onImagesDeleted(StyledImagesEvent $event)

The parameter $event is not used and could be removed.

    {
        // @TODO: Implement.
    }
}