Issues in BaseMessageAdapter.php (master) - Issues in master - irishdan/NotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (51)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Adapter/BaseMessageAdapter.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace IrishDan\NotificationBundle\Adapter;

use IrishDan\NotificationBundle\Exception\MessageFormatException;
use IrishDan\NotificationBundle\Message\Message;
use IrishDan\NotificationBundle\Notification\NotificationInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

/**
 * Class BaseMessageAdapter
 *
 * @package IrishDan\NotificationBundle\Adapter
 */
abstract class BaseMessageAdapter
{
    protected $twig;
    protected $eventDispatcher;
    protected $configuration = [];
    protected $channelName;

    /**
     * @param \Twig_Environment $twig
     */
    public function setTemplating(\Twig_Environment $twig)
    {
        $this->twig = $twig;
    }

    /**
     * @param EventDispatcherInterface $eventDispatcher
     */
    public function setDispatcher(EventDispatcherInterface $eventDispatcher)
    {
        $this->eventDispatcher = $eventDispatcher;
    }

    /**
     * @param $data
     * @param $user
     * @param $template
     * @return mixed
     */
    protected function renderTwigTemplate($data, $user, $template)
    {
        return $this->twig->render(
            $template,
            [
                'data' => $data,
                'user' => $user,
            ]
        );
    }

    /**
     * @param NotificationInterface $notification
     */
    public function format(NotificationInterface $notification)
    {
        $notification->setChannel($this->channelName);

        $templateArray = $notification->getTemplateArray();
        if (!empty($this->twig) && !empty($templateArray)) {
            $data = $notification->getDataArray();

            if ($notification->getUuid()) {
                $data['uuid'] = $notification->getUuid();
            }

            foreach ($templateArray as $key => $template) {
                // Find out if the template exists before trying to render it.
                $exists = $this->twig->getLoader()->exists($template);
                if (!empty($data[$key]) && $exists) {

                    $data[$key] = $this->renderTwigTemplate(
                        $data,
                        $notification->getNotifiable(),
                        $template
                    );
                }
            }

            $notification->setDataArray($data);
        }
    }

    /**
     * @param        $dispatchData
     * @param        $messageData
     * @param string $channel
     * @return Message
     */
    protected static function createMessage($dispatchData, $messageData, $channel = 'default')
    {
        $message = new Message();

        $message->setChannel($channel);
        $message->setDispatchData($dispatchData);
        $message->setMessageData($messageData);

        return $message;
    }

    /**
     * @param array $notificationData
     * @return array
     */
    protected static function createMessagaData(array $notificationData)
    {
        // Build the message data array.
        $messageData = [];
        $messageData['body'] = empty($notificationData['body']) ? '' : $notificationData['body'];
        $messageData['title'] = empty($notificationData['title']) ? '' : $notificationData['title'];
        $messageData['uuid'] = empty($notificationData['uuid']) ? '' : $notificationData['uuid'];

        return $messageData;
    }

    /**
     * @param $shouldImplement
     * @param $type
     * @throws MessageFormatException
     */
    protected static function createFormatterException($shouldImplement, $type)
    {
        $message = sprintf('Notifiable must implement %s interface in order to format as a %s message', $shouldImplement, $type);
        throw new MessageFormatException(
            $message
        );
    }

    /**
     * @param array $configuration
     */
    public function setConfiguration(array $configuration)
    {
        $this->configuration = $configuration;
    }

    /**
     * @param mixed $channeName
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function setChannelName($channelName)
    {
        $this->channelName = $channelName;
    }
}

1			<?php
2
3			namespace IrishDan\NotificationBundle\Adapter;
4
5			use IrishDan\NotificationBundle\Exception\MessageFormatException;
6			use IrishDan\NotificationBundle\Message\Message;
7			use IrishDan\NotificationBundle\Notification\NotificationInterface;
8			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
9
10			/**
11			* Class BaseMessageAdapter
12			*
13			* @package IrishDan\NotificationBundle\Adapter
14			*/
15			abstract class BaseMessageAdapter
16			{
17			protected $twig;
18			protected $eventDispatcher;
19			protected $configuration = [];
20			protected $channelName;
21
22			/**
23			* @param \Twig_Environment $twig
24			*/
25			public function setTemplating(\Twig_Environment $twig)
26			{
27			$this->twig = $twig;
28			}
29
30			/**
31			* @param EventDispatcherInterface $eventDispatcher
32			*/
33			public function setDispatcher(EventDispatcherInterface $eventDispatcher)
34			{
35			$this->eventDispatcher = $eventDispatcher;
36			}
37
38			/**
39			* @param $data
40			* @param $user
41			* @param $template
42			* @return mixed
43			*/
44			protected function renderTwigTemplate($data, $user, $template)
45			{
46			return $this->twig->render(
47			$template,
48			[
49			'data' => $data,
50			'user' => $user,
51			]
52			);
53			}
54
55			/**
56			* @param NotificationInterface $notification
57			*/
58			public function format(NotificationInterface $notification)
59			{
60			$notification->setChannel($this->channelName);
61
62			$templateArray = $notification->getTemplateArray();
63			if (!empty($this->twig) && !empty($templateArray)) {
64			$data = $notification->getDataArray();
65
66			if ($notification->getUuid()) {
67			$data['uuid'] = $notification->getUuid();
68			}
69
70			foreach ($templateArray as $key => $template) {
71			// Find out if the template exists before trying to render it.
72			$exists = $this->twig->getLoader()->exists($template);
73			if (!empty($data[$key]) && $exists) {
74
75			$data[$key] = $this->renderTwigTemplate(
76			$data,
77			$notification->getNotifiable(),
78			$template
79			);
80			}
81			}
82
83			$notification->setDataArray($data);
84			}
85			}
86
87			/**
88			* @param $dispatchData
89			* @param $messageData
90			* @param string $channel
91			* @return Message
92			*/
93			protected static function createMessage($dispatchData, $messageData, $channel = 'default')
94			{
95			$message = new Message();
96
97			$message->setChannel($channel);
98			$message->setDispatchData($dispatchData);
99			$message->setMessageData($messageData);
100
101			return $message;
102			}
103
104			/**
105			* @param array $notificationData
106			* @return array
107			*/
108			protected static function createMessagaData(array $notificationData)
109			{
110			// Build the message data array.
111			$messageData = [];
112			$messageData['body'] = empty($notificationData['body']) ? '' : $notificationData['body'];
113			$messageData['title'] = empty($notificationData['title']) ? '' : $notificationData['title'];
114			$messageData['uuid'] = empty($notificationData['uuid']) ? '' : $notificationData['uuid'];
115
116			return $messageData;
117			}
118
119			/**
120			* @param $shouldImplement
121			* @param $type
122			* @throws MessageFormatException
123			*/
124			protected static function createFormatterException($shouldImplement, $type)
125			{
126			$message = sprintf('Notifiable must implement %s interface in order to format as a %s message', $shouldImplement, $type);
127			throw new MessageFormatException(
128			$message
129			);
130			}
131
132			/**
133			* @param array $configuration
134			*/
135			public function setConfiguration(array $configuration)
136			{
137			$this->configuration = $configuration;
138			}
139
140			/**
141			* @param mixed $channeName
			0 ignored issues – show Documentation introduced 2017-09-02 16:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$channeName`. Did you maybe mean `$channelName`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
142			*/
143			public function setChannelName($channelName)
144			{
145			$this->channelName = $channelName;
146			}
147			}

irishdan / NotificationBundle

Issues (51)

Security Analysis not enabled

Adapter/BaseMessageAdapter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like