BaseFormatter - Code Metrics - Inspection of "Adjust base formatter" - irishdan/NotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3a73f...40fe4a )

by dan

created 2017-08-22 14:27 UTC

BaseFormatter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	2
dl	0
loc	40
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	setTemplating()	4	1
A	setDispatcher()	4	1
A	renderTwigTemplate()	10	1
A	format()	13	3

<?php

namespace IrishDan\NotificationBundle\Formatter;

use IrishDan\NotificationBundle\Notification\NotificationInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

abstract class BaseFormatter
{
    protected $twig;
    protected $eventDispatcher;

    public function setTemplating(\Twig_Environment $twig)
    {
        $this->twig = $twig;
    }

    public function setDispatcher(EventDispatcherInterface $eventDispatcher)
    {
        $this->eventDispatcher = $eventDispatcher;
    }

    protected function renderTwigTemplate($data, $user, $template)
    {
        return $this->twig->render(
            $template,
            [
                'data' => $data,
                'user' => $user,
            ]
        );
    }

    public function format(NotificationInterface $notification)
    {
        if (!empty($this->twig) && $notification->getTemplate()) {
            $data         = $notification->getDataArray();
            $data['body'] = $this->renderTwigTemplate(
                $data,
                $notification->getNotifiable(),
                $notification->getTemplate()
            );

            $notification->setDataArray($data);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }
}

1			<?php
2
3			namespace IrishDan\NotificationBundle\Formatter;
4
5			use IrishDan\NotificationBundle\Notification\NotificationInterface;
6			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
7
8			abstract class BaseFormatter
9			{
10			protected $twig;
11			protected $eventDispatcher;
12
13			public function setTemplating(\Twig_Environment $twig)
14			{
15			$this->twig = $twig;
16			}
17
18			public function setDispatcher(EventDispatcherInterface $eventDispatcher)
19			{
20			$this->eventDispatcher = $eventDispatcher;
21			}
22
23			protected function renderTwigTemplate($data, $user, $template)
24			{
25			return $this->twig->render(
26			$template,
27			[
28			'data' => $data,
29			'user' => $user,
30			]
31			);
32			}
33
34			public function format(NotificationInterface $notification)
35			{
36			if (!empty($this->twig) && $notification->getTemplate()) {
37			$data = $notification->getDataArray();
38			$data['body'] = $this->renderTwigTemplate(
39			$data,
40			$notification->getNotifiable(),
41			$notification->getTemplate()
42			);
43
44			$notification->setDataArray($data);
			0 ignored issues – show Bug introduced 2017-08-22 14:30 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `IrishDan\NotificationBun...n\NotificationInterface` as the method `setDataArray()` does only exist in the following implementations of said interface: `IrishDan\NotificationBun...cation\TestNotification`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45			}
46			}
47			}

irishdan / NotificationBundle

Push — master ( e3a73f...40fe4a )

BaseFormatter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like