IrishDan\NotificationBundle\Dispatcher\DatabaseMessageDispatcher

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	dispatch()	0	18	2
B	createDatabaseNotificationEntity()	0	24	4

<?php

namespace IrishDan\NotificationBundle\Dispatcher;

use Doctrine\ORM\EntityManager;
use IrishDan\NotificationBundle\Message\BaseMessage;
use IrishDan\NotificationBundle\Message\MessageInterface;
use Symfony\Component\PropertyAccess\PropertyAccess;

class DatabaseMessageDispatcher implements MessageDispatcherInterface
{
    protected $entityManager;
    protected $configuration;
    protected $accessor;

    public function __construct(EntityManager $entityManager, $configuration = [])

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
        $this->configuration = $configuration;
    }

    public function dispatch(MessageInterface $message)
    {
        // Get the dispatch and message data from the message.
        $dispatchData = $message->getDispatchData();

$dispatchData is not used, you could remove the assignment.

        $messageData = $message->getMessageData();

$messageData is not used, you could remove the assignment.

        // Create the database notification entity
        $databaseNotification = $this->createDatabaseNotificationEntity($message);
        if ($databaseNotification) {
            // Save the notification to the database
            $this->entityManager->persist($databaseNotification);
            $this->entityManager->flush();

            return true;
        }

        return false;
    }

    protected function createDatabaseNotificationEntity($data)
    {
        if ($this->accessor === null) {
            $this->accessor = PropertyAccess::createPropertyAccessor();
        }

        $entity = $this->configuration['entity'];
        if (!empty($entity)) {
            $em = $this->entityManager;
            $class = $em->getRepository($entity)->getClassName();
            $object = new $class();

            // Transfer values from message to databaseNotification.
            $properties = ['notifiable', 'uuid', 'type', 'data'];
            foreach ($properties as $property) {
                $value = $this->accessor->getValue($data, $property);
                $this->accessor->setValue($object, $property, $value);
            }

            return $object;
        }

        return false;
    }
}