irishdan / NotificationBundle

DependencyInjection/Factory/Channel/SlackBroadcasterFactory.php

<?php

namespace IrishDan\NotificationBundle\DependencyInjection\Factory\Broadcaster;

use IrishDan\NotificationBundle\DependencyInjection\Factory\BroadcasterFactoryInterface;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\DefinitionDecorator;
use Symfony\Component\DependencyInjection\Reference;

class SlackBroadcasterFactory implements BroadcasterFactoryInterface

The type IrishDan\NotificationBundle\DependencyInjection\Factory\Broadcaster\SlackBroadcasterFactory has been defined more than once; this definition is ignored, only the first definition in DependencyInjection/Factory/Broadcaster/SlackBroadcasterFactory.php (L11-38) is considered.

This class seems to be duplicated in your project.

{
    public function getKey()
    {
        return 'slack';
    }

    public function create(ContainerBuilder $container, $id, array $config)
    {
        $container
            ->setDefinition($id, new DefinitionDecorator('notification.broadcaster.slack'))

The class Symfony\Component\DependencyInjection\DefinitionDecorator has been deprecated with message: The DefinitionDecorator class is deprecated since version 3.3 and will be removed in 4.0. Use the Symfony\Component\DependencyInjection\ChildDefinition class instead.

            ->replaceArgument(0, new Reference(sprintf('notification.%s_adapter', $config['adapter'])))
            // ->replaceArgument(1, $config['key'])

75% of this comment could be valid code. Did you maybe forget this after debugging?

            // ->replaceArgument(2, $config['expires'])

75% of this comment could be valid code. Did you maybe forget this after debugging?

        ;
    }

    public function addConfiguration(NodeDefinition $node)
    {
        // $node
        //     ->children()
        //         // ->scalarNode('adapter')->isRequired()->end()
        //         // ->scalarNode('key')->defaultValue('flysystem')->end()
        //         // ->scalarNode('expires')->defaultNull()->end()
        //     ->end()
        // ;
    }
}