Broadcaster - Code Metrics - Inspection of "Create broadcasters and integrate into notificatio..." - irishdan/NotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 97130c...2e004f )

by dan

created 2017-08-31 18:20 UTC

Broadcaster A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
c	0
b	0
f	0
lcom	1
cbo	2
dl	0
loc	40
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	23	5
A	broadcast()	0	8	1

<?php

namespace IrishDan\NotificationBundle\Broadcast;

use IrishDan\NotificationBundle\Channel\ChannelInterface;
use IrishDan\NotificationBundle\Notification\NotifiableInterface;
use IrishDan\NotificationBundle\Notification\NotificationInterface;

class Broadcaster
{
    protected $notifiable;
    protected $channel;
    protected $config;
    protected $channelName;

    public function __construct(NotifiableInterface $notifiable, ChannelInterface $channel, array $config)
    {
        $this->notifiable = $notifiable;
        $this->channel = $channel;
        $this->config = $config;
        $this->channelName = $channel->channelName();

        switch ($this->channelName) {
            case 'slack':
                // Set the data for Slack Broadcasts
                if (!empty($config['webhook'])) {
                    $notifiable->setSlackWebhook($config['webhook']);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                }
                break;

            case 'pusher':
                // Set data for pusher broadcasts
                if (!empty($config['channel_name'])) {
                    $notifiable->setPusherChannel($config['channel_name']);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                }
                break;
        }
    }

    public function broadcast(NotificationInterface $notification)
    {
        $notification->setNotifiable($this->notifiable);
        $notification->setChannel($this->channelName);

        // Format and send the broadcast
        $this->channel->formatAndDispatch($notification);
    }
}

Push — master ( 97130c...2e004f )

Broadcaster A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

1			<?php
2
3			namespace IrishDan\NotificationBundle\Broadcast;
4
5			use IrishDan\NotificationBundle\Channel\ChannelInterface;
6			use IrishDan\NotificationBundle\Notification\NotifiableInterface;
7			use IrishDan\NotificationBundle\Notification\NotificationInterface;
8
9			class Broadcaster
10			{
11			protected $notifiable;
12			protected $channel;
13			protected $config;
14			protected $channelName;
15
16			public function __construct(NotifiableInterface $notifiable, ChannelInterface $channel, array $config)
17			{
18			$this->notifiable = $notifiable;
19			$this->channel = $channel;
20			$this->config = $config;
21			$this->channelName = $channel->channelName();
22
23			switch ($this->channelName) {
24			case 'slack':
25			// Set the data for Slack Broadcasts
26			if (!empty($config['webhook'])) {
27			$notifiable->setSlackWebhook($config['webhook']);
			0 ignored issues – show Bug introduced 2017-08-31 15:34 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `IrishDan\NotificationBun...ion\NotifiableInterface` as the method `setSlackWebhook()` does only exist in the following implementations of said interface: `IrishDan\NotificationBundle\Broadcast\Broadcast`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
28			}
29			break;
30
31			case 'pusher':
32			// Set data for pusher broadcasts
33			if (!empty($config['channel_name'])) {
34			$notifiable->setPusherChannel($config['channel_name']);
			0 ignored issues – show Bug introduced 2017-08-31 15:34 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `IrishDan\NotificationBun...ion\NotifiableInterface` as the method `setPusherChannel()` does only exist in the following implementations of said interface: `IrishDan\NotificationBundle\Broadcast\Broadcast`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
35			}
36			break;
37			}
38			}
39
40			public function broadcast(NotificationInterface $notification)
41			{
42			$notification->setNotifiable($this->notifiable);
43			$notification->setChannel($this->channelName);
44
45			// Format and send the broadcast
46			$this->channel->formatAndDispatch($notification);
47			}
48			}

irishdan / NotificationBundle

Push — master ( 97130c...2e004f )

Broadcaster A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like