FullyNotifiableTrait - Code Metrics - Inspection of "Improve documention" - irishdan/NotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aad899...3d3dd0 )

by dan

created 2017-10-02 08:48 UTC

FullyNotifiableTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	1
cbo	0
dl	0
loc	46
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getEmail()	4	1
A	getSlackWebhook()	4	1
A	getNumber()	4	1
A	getPusherChannelSuffix()	4	1

<?php

namespace IrishDan\NotificationBundle;

/**
 * Trait FullyNotifiableTrait
 * This trait is handy for getting set up quickly.
 *
 * @package IrishDan\NotificationBundle
 */
trait FullyNotifiableTrait
{
    protected $email;
    protected $slackWebhook;
    protected $number;

    /**
     * From EmailableInterface
     *
     * @return string
     */
    public function getEmail()
    {
        return $this->mail;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * From SlackableInterface
     *
     * @return string
     */
    public function getSlackWebhook()
    {
        return $this->slackWebhook;
    }

    /**
     * From TextableInterface
     *
     * @return string
     */
    public function getNumber()
    {
        return $this->number;
    }

    /**
     * From PusherableInterface
     *
     * @return string
     */
    public function getPusherChannelSuffix()
    {
        return '_' . $this->id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}

1			<?php
2
3			namespace IrishDan\NotificationBundle;
4
5			/**
6			* Trait FullyNotifiableTrait
7			* This trait is handy for getting set up quickly.
8			*
9			* @package IrishDan\NotificationBundle
10			*/
11			trait FullyNotifiableTrait
12			{
13			protected $email;
14			protected $slackWebhook;
15			protected $number;
16
17			/**
18			* From EmailableInterface
19			*
20			* @return string
21			*/
22			public function getEmail()
23			{
24			return $this->mail;
			0 ignored issues – show Bug introduced 2017-10-02 09:00 UTC by Report Bug Copy Issue Report The property `mail` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26
27			/**
28			* From SlackableInterface
29			*
30			* @return string
31			*/
32			public function getSlackWebhook()
33			{
34			return $this->slackWebhook;
35			}
36
37			/**
38			* From TextableInterface
39			*
40			* @return string
41			*/
42			public function getNumber()
43			{
44			return $this->number;
45			}
46
47			/**
48			* From PusherableInterface
49			*
50			* @return string
51			*/
52			public function getPusherChannelSuffix()
53			{
54			return '_' . $this->id;
			0 ignored issues – show Bug introduced 2017-10-02 09:00 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
55			}
56			}

irishdan / NotificationBundle

Push — master ( aad899...3d3dd0 )

FullyNotifiableTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like