NotificationChannelSubscriber::formatMessageFromEvent() - Code Metrics - Inspection of "Initial symfony4 upgrade" - irishdan/NotificationBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by dan

created 2019-02-16 02:23 UTC

formatMessageFromEvent() A

↳ Parent: NotificationChannelSubscriber

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	28
rs	9.472
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace IrishDan\NotificationBundle\Subscriber;

use IrishDan\NotificationBundle\Adapter\MessageAdapterInterface;
use IrishDan\NotificationBundle\Channel\ChannelInterface;
use IrishDan\NotificationBundle\Channel\EventChannel;
use IrishDan\NotificationBundle\Event\MessageCreatedEvent;
use IrishDan\NotificationBundle\Event\MessageDispatchedEvent;
use IrishDan\NotificationBundle\Event\NotificationReadyToFormatEvent;
use IrishDan\NotificationBundle\Exception\MessageDispatchException;
use IrishDan\NotificationBundle\Message\MessageInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Class NotificationChannelSubscriber
 *
 * @package IrishDan\NotificationBundle\Subscriber
 */
class NotificationChannelSubscriber implements EventSubscriberInterface
{
    /**
     * An array of all available adapters.
     *
     * @var array
     */
    private $adapters = [];
    private $eventDispatcher;
    private $adapterlessChannel;
    private $channelConfigMap = [];

    public function __construct(EventDispatcherInterface $eventDispatcher, ChannelInterface $adapterlessChannel, array $channelConfigMap = [])
    {
        $this->eventDispatcher = $eventDispatcher;
        $this->adapterlessChannel = $adapterlessChannel;
        $this->channelConfigMap = $channelConfigMap;
    }


    /**
     * @return array
     */
    public static function getSubscribedEvents()
    {
        return [
            NotificationReadyToFormatEvent::NAME => 'formatMessageFromEvent'
        ];
    }

    /**
     * @param                         $key
     * @param MessageAdapterInterface $adapter
     * @param array                   $config
     */
    public function addAdapter($key, MessageAdapterInterface $adapter, array $config = [])

    {
        $adapter->setChannelName($key);
        $this->adapters[$key] = $adapter;
    }


    public function formatMessageFromEvent(NotificationReadyToFormatEvent $event)
    {
        $notification = $event->getNotification();

        // get the adapter name from the
        // $adapterKey = $message->getChannel();
        $adapterKey = $this->channelConfigMap[$notification->getChannel()]['adapter'];
        $channelConfiguration =  $this->channelConfigMap[$notification->getChannel()]['config'];

        // Get the adapter for this channel
        // and inject it into the adapterless channel
        // disable dispatching to events also...
        if (!empty($this->adapters[$adapterKey])) {
            $adapter = $this->adapters[$adapterKey];

            // Below could be refactored into a an abstract class for use in a queue worker or else where
            $this->adapterlessChannel->setAdapter($adapter);
            $this->adapterlessChannel->setChannelConfiguration($channelConfiguration);

            $message = $this->adapterlessChannel->formatAndDispatch($notification, false);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            // @TODO: Event...

        } else {
            throw new MessageDispatchException(
                sprintf('No adapter available with key "%s"', $adapterKey)
            );
        }
    }
}


1			<?php
2
3			namespace IrishDan\NotificationBundle\Subscriber;
4
5			use IrishDan\NotificationBundle\Adapter\MessageAdapterInterface;
6			use IrishDan\NotificationBundle\Channel\ChannelInterface;
7			use IrishDan\NotificationBundle\Channel\EventChannel;
8			use IrishDan\NotificationBundle\Event\MessageCreatedEvent;
9			use IrishDan\NotificationBundle\Event\MessageDispatchedEvent;
10			use IrishDan\NotificationBundle\Event\NotificationReadyToFormatEvent;
11			use IrishDan\NotificationBundle\Exception\MessageDispatchException;
12			use IrishDan\NotificationBundle\Message\MessageInterface;
13			use Psr\Log\LoggerInterface;
14			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
15			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
16
17			/**
18			* Class NotificationChannelSubscriber
19			*
20			* @package IrishDan\NotificationBundle\Subscriber
21			*/
22			class NotificationChannelSubscriber implements EventSubscriberInterface
23			{
24			/**
25			* An array of all available adapters.
26			*
27			* @var array
28			*/
29			private $adapters = [];
30			private $eventDispatcher;
31			private $adapterlessChannel;
32			private $channelConfigMap = [];
33
34			public function __construct(EventDispatcherInterface $eventDispatcher, ChannelInterface $adapterlessChannel, array $channelConfigMap = [])
35			{
36			$this->eventDispatcher = $eventDispatcher;
37			$this->adapterlessChannel = $adapterlessChannel;
38			$this->channelConfigMap = $channelConfigMap;
39			}
40
41
42			/**
43			* @return array
44			*/
45			public static function getSubscribedEvents()
46			{
47			return [
48			NotificationReadyToFormatEvent::NAME => 'formatMessageFromEvent'
49			];
50			}
51
52			/**
53			* @param $key
54			* @param MessageAdapterInterface $adapter
55			* @param array $config
56			*/
57			public function addAdapter($key, MessageAdapterInterface $adapter, array $config = [])
			0 ignored issues – show Unused Code introduced 2019-02-16 02:38 UTC by Report Bug Copy Issue Report The parameter `$config` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58			{
59			$adapter->setChannelName($key);
60			$this->adapters[$key] = $adapter;
61			}
62
63
64			public function formatMessageFromEvent(NotificationReadyToFormatEvent $event)
65			{
66			$notification = $event->getNotification();
67
68			// get the adapter name from the
69			// $adapterKey = $message->getChannel();
70			$adapterKey = $this->channelConfigMap[$notification->getChannel()]['adapter'];
71			$channelConfiguration = $this->channelConfigMap[$notification->getChannel()]['config'];
72
73			// Get the adapter for this channel
74			// and inject it into the adapterless channel
75			// disable dispatching to events also...
76			if (!empty($this->adapters[$adapterKey])) {
77			$adapter = $this->adapters[$adapterKey];
78
79			// Below could be refactored into a an abstract class for use in a queue worker or else where
80			$this->adapterlessChannel->setAdapter($adapter);
81			$this->adapterlessChannel->setChannelConfiguration($channelConfiguration);
82
83			$message = $this->adapterlessChannel->formatAndDispatch($notification, false);
			0 ignored issues – show Unused Code introduced 2019-02-16 02:38 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
84			// @TODO: Event...
85
86			} else {
87			throw new MessageDispatchException(
88			sprintf('No adapter available with key "%s"', $adapterKey)
89			);
90			}
91			}
92			}
93

irishdan / NotificationBundle

Pull Request — master (#4)

formatMessageFromEvent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like