irfaardy / raja-ongkir

src/Ongkir/Func/Api.php

<?php

/*
    Raja Ongkir API
    Author: Irfa Ardiansyah <irfa.backend@protonmail.com>
*/

namespace Irfa\RajaOngkir\Ongkir\Func;

use Exception;
use Irfa\RajaOngkir\Caching\CacheCurl;

class Api extends CacheCurl
{
    private static $account_type;
    private static $api_key;
    private static $api_version;
    private static $url;
    private static $count = 0;

The private property $count is not used, and could be removed.

    private static function setup_option()
    {
        if (function_exists('config') and function_exists('app')) {//Load Config For Laravel

Using logical operators such as and instead of && is generally not recommended.

            self::$account_type = strtolower(config('irfa.rajaongkir.account_type'));
            self::$api_key = config('irfa.rajaongkir.api_key');
            self::$api_version = config('irfa.rajaongkir.api_version');
        } else {//Load config For PHP Native
            require __DIR__.'../../../../config/config.php';
            self::$account_type = strtolower($config['account_type']);

The variable $config seems to be never defined.

            self::$api_key = $config['api_key'];
            self::$api_version = $config['api_version'];
        }
        if (self::$account_type == 'pro') {
            self::$url = 'https://pro.rajaongkir.com/api';
        } else {
            self::$url = 'https://api.rajaongkir.com/'.self::$account_type;
        }
    }

    protected static function cacheProvince()
    {
        self::setup_option();
        echo "Retrieving data from \033[96m".self::$url."...\033[0m".PHP_EOL;
        CacheCurl::caching(self::get_province())->province();
    }

    protected static function cacheCity()
    {
        self::setup_option();
        echo "Retrieving data from\033[96m ".self::$url."...\033[0m".PHP_EOL;
        CacheCurl::caching(self::get_city())->city();
    }
    protected static function cacheSubDistrict($arr)
    {
        self::setup_option();
        echo "Retrieving data from\033[96m ".self::$url."...\033[0m".PHP_EOL;
        CacheCurl::caching(self::getSubdistrict($arr))->subdistrict();
    }
    protected static function get_province($arr = null)
    {
        if ($arr != null) {
            $province_id = array_key_exists('province_id', $arr) ? '?id='.$arr['province_id'] : null;
        } else {
            $province_id = null;
        }
        self::setup_option();
        $curl = curl_init();
        curl_setopt_array($curl, [
            CURLOPT_URL            => self::$url.'/province'.$province_id,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING       => '',
            CURLOPT_MAXREDIRS      => 10,
            CURLOPT_TIMEOUT        => 30,
            CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST  => 'GET',
            CURLOPT_HTTPHEADER     => [
                'key: '.self::$api_key,
            ],
        ]);
        $response = curl_exec($curl);
        $err = curl_error($curl);

        curl_close($curl);

        if ($err) {
            self::exceptCurl($err);
        } else {
            $json = json_decode($response, false)->rajaongkir;

It seems like $response can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if ($json->status->code == '400') {
                throw new Exception($json->status->description);
            } else {
                $res = $json->results;

                return $res;
            }
        }
    }

    protected static function get_city($arr = null)
    {
        if ($arr != null) {
            $province_id = array_key_exists('province_id', $arr) ? '?province='.$arr['province_id'] : null;
        } else {
            $province_id = null;
        }
        self::setup_option();
        $curl = curl_init();
        curl_setopt_array($curl, [
            CURLOPT_URL            => self::$url.'/city'.$province_id,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING       => '',
            CURLOPT_MAXREDIRS      => 10,
            CURLOPT_TIMEOUT        => 30,
            CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST  => 'GET',
            CURLOPT_HTTPHEADER     => [
                'key: '.self::$api_key,
            ],
        ]);
        $response = curl_exec($curl);
        $err = curl_error($curl);

        curl_close($curl);

        if ($err) {
           self::exceptCurl($err);
        } else {
            $json = json_decode($response, false)->rajaongkir;

It seems like $response can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if ($json->status->code == '400') {
                throw new Exception($json->status->description);
            } else {
                $res = $json->results;

                return $res;
            }
        }
    }

    protected static function get_courier($arr)
    {
        $origin = $arr['origin'];
        $destination = $arr['destination'];
        $weight = $arr['weight'];
        $courier = $arr['courier'];
        $res = self::curl_cost_get($origin, $destination, $weight, $courier);

        return $res;
    }

    protected static function get_cost_details($arr)
    {
        $origin = $arr['origin'];
        $destination = $arr['destination'];
        $weight = $arr['weight'];
        $courier = $arr['courier'];
        $res = self::curl_cost_get($origin, $destination, $weight, $courier);

        return $res[0]->costs;
    }

    private static function curl_cost_get($origin, $destination, $weight, $courier)
    {
        $curl = curl_init();

        curl_setopt_array($curl, self::curl_cost_option($origin, $destination, $weight, $courier));

        $response = curl_exec($curl);
        $err = curl_error($curl);

        curl_close($curl);

        if ($err) {
            echo "Can't connect to server, please check your internet connection.";
            exit();

Using exit here is not recommended.

        } else {
            $json = json_decode($response, false)->rajaongkir;

It seems like $response can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if ($json->status->code == '400') {
                throw new Exception($json->status->description);
            } else {
                $res = $json->results;

                return $res;
            }
        }
    }

    private static function curl_cost_option($origin, $destination, $weight, $courier)
    {
        self::setup_option();

        return [
            CURLOPT_URL            => self::$url.'/cost',
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING       => '',
            CURLOPT_MAXREDIRS      => 10,
            CURLOPT_TIMEOUT        => 30,
            CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST  => 'POST',
            CURLOPT_POSTFIELDS     => 'origin='.$origin.'&destination='.$destination.'&weight='.$weight.'&courier='.strtolower($courier),
            CURLOPT_HTTPHEADER     => [
                'content-type: application/x-www-form-urlencoded',
                'key: '.self::$api_key,
            ],
        ];
    }
///PRO
     protected static function getSubdistrict($arr = null)
    {
        if ($arr != null) {
            $city = array_key_exists('city', $arr) ? '?city='.$arr['city'] : null;
        } else {
            $city = null;
        }
        self::setup_option();
        $curl = curl_init();
        curl_setopt_array($curl, [
            CURLOPT_URL            => self::$url.'/subdistrict'.$city,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING       => '',
            CURLOPT_MAXREDIRS      => 10,
            CURLOPT_TIMEOUT        => 30,
            CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST  => 'GET',
            CURLOPT_HTTPHEADER     => [
                'key: '.self::$api_key,
            ],
        ]);
        $response = curl_exec($curl);
        $err = curl_error($curl);

        curl_close($curl);

        if ($err) {
            self::exceptCurl($err);
        } else {
            $json = json_decode($response, false)->rajaongkir;

It seems like $response can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if ($json->status->code == '400') {
                throw new Exception($json->status->description);
            } else {
                $res = $json->results;

                return $res;
            }
        }
    }

private static function exceptCurl($err){
      if(php_sapi_name() == "cli"){
                echo "Can't connect to server, please check your internet connection.\n";
                echo "Exception: \033[31m".$err;
                exit();

Using exit here is not recommended.

            } else{
                throw new Exception($err);
            }
}

protected static function test_connection($arr = null)
{
        if ($arr != null) {
            $province_id = array_key_exists('province_id', $arr) ? '?id='.$arr['province_id'] : null;
        } else {
            $province_id = null;
        }
        self::setup_option();
        $curl = curl_init();
        curl_setopt_array($curl, [
            CURLOPT_URL            => self::$url.'/province'.$province_id,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING       => '',
            CURLOPT_MAXREDIRS      => 10,
            CURLOPT_TIMEOUT        => 30,
            CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST  => 'GET',
            CURLOPT_HTTPHEADER     => [
                'key: '.self::$api_key,
            ],
        ]);
        $response = curl_exec($curl);
        $err = curl_error($curl);

        curl_close($curl);

        if ($err) {
            $result = false;
            return $result;
        } else {
            $data = json_decode($response, false);

It seems like $response can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if(!empty($data)){
                $json = $data->rajaongkir;
                if ($json->status->code == '400') {
                    $result = ['res' => $json->status->code,'success'=> false];
                    return $result;
                } else {
                    $result = ['res' => "Connected to server.",'success'=> true];
                    return $result;
                }
             } else{
                 $result = ['res' => "Data is Empty.",'success'=> false];
                return $result;
             }
        }
    }
}