irfaardy / php-gatcha

src/Roulette/Roulette.php

<?php 
/* 
	Author:Irfa Ardiansyah <irfa.backend@protonmail.com>
	Simple Items Gatcha with PHP
	v2.1
	https://github.com/irfaardy/php-gacha
*/
namespace Irfa\Gatcha\Roulette;

use Exception;
use Irfa\Gatcha\Roulette\RateUp;

class Roulette extends RateUp {

 	 /**
     * encode to Json.
     *
     * @param string $dt
     * @return json

The type Irfa\Gatcha\Roulette\json was not found. Maybe you did not declare it correctly or list all dependencies?

     */
 	protected static function jsonItem($dt) {
 		$data['data'] = ['item' => $dt];

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

 		return json_encode($data);

The expression return json_encode($data) returns the type string which is incompatible with the documented return type Irfa\Gatcha\Roulette\json.

 	}

 	 /**
     * Add drop up rate to items.
     *
     * @param mixed $item_list
     * @param array $items
     * @param float $rate
     * @return array
     */
 	protected static function itemDropUp($item_list, $items, $rate)
 	{
 		return self::_itemDropUp($item_list, $items, $rate);
 	}

 	 /**
     * Get Item.
     *
     * @param array $item
     * @return string
     */
	protected static function get($items) {
		if (is_array($items))
		{
			$max = 0;
			foreach ($items as $key => $value) {
				$max += $value;
				$items[$key] = $max;
			}

			$random = mt_rand(1, $max);

				foreach ($items as $item => $max)
				{
					if ($random <= $max) {
						break;
					}
				}
				 return $item;

The variable $item seems to be defined by a foreach iteration on line 56. Are you sure the iterator is never empty, otherwise this variable is not defined?

		} else {
				throw new Exception('Parameter must be an array.');

				return false;

return false is not reachable.

		}
	}
	
}