Irfa\Gatcha\Roulette\Roulette::get()

Complexity

Conditions	5
Paths	7

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php 
	protected static function get($items) {
		if (is_array($items))
		{
			$max = 0;
			foreach ($items as $key => $value) {
				$max += $value;
				$items[$key] = $max;
			}

			$random = mt_rand(1, $max);

				foreach ($items as $item => $max)
				{
					if ($random <= $max) {
						break;
					}
				}
				 return $item;

The variable $item seems to be defined by a foreach iteration on line 28. Are you sure the iterator is never empty, otherwise this variable is not defined?

		} else {
				throw new Exception('Parameter must be an array.');

				return false;

return false is not reachable.

		}
}