Irfa\AppLicenseServer\Controller\AppLicenseController::check()

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function check(Request $request,License $license,Json $json)
    {
    	if(empty($request->serial))
    	{
    		$data['active'] = false;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

    		$data['message'] = "Serial number must be provided.";
    		return $json->response(400,'data',$data,[]); 
    	}
    	$res = $license->serial($request->serial)->check();
        if($res->active)
        {
    	   return $json->response(200,'data',$res,[]); 
        } 
           return $json->response(400,'data',$res,[$res->message]);