Issues in AbstractMcryptMixer.php (master) - Issues in master - ircmaxell/RandomLib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/RandomLib/AbstractMcryptMixer.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * The RandomLib library for securely generating random numbers and strings in PHP
 *
 * @author     Anthony Ferrara <[email protected]>
 * @copyright  2011 The Authors
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 * @version    Build @@version@@
 */

/**
 * The Mcrypt abstract mixer class
 *
 * PHP version 5.3
 *
 * @category   PHPCryptLib
 * @package    Random
 * @subpackage Mixer
 *
 * @author     Anthony Ferrara <[email protected]>
 * @copyright  2013 The Authors
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 *
 * @version    Build @@version@@
 */
namespace RandomLib;

/**
 * The mcrypt abstract mixer class
 *
 * @category   PHPCryptLib
 * @package    Random
 * @subpackage Mixer
 *
 * @author     Anthony Ferrara <[email protected]>
 * @author     Chris Smith <[email protected]>
 */
abstract class AbstractMcryptMixer extends AbstractMixer
{
    /**
     * mcrypt module resource
     *
     * @var resource
     */
    private $mcrypt;

    /**
     * Block size of cipher
     *
     * @var int
     */
    private $blockSize;

    /**
     * Cipher initialization vector
     *
     * @var string
     */
    private $initv;

    /**
     * {@inheritdoc}
     */
    public static function test()
    {
        return extension_loaded('mcrypt');
    }

    /**
     * Construct mcrypt mixer
     */
    public function __construct()
    {
        $this->mcrypt    = mcrypt_module_open($this->getCipher(), '', MCRYPT_MODE_ECB, '');
        $this->blockSize = mcrypt_enc_get_block_size($this->mcrypt);
        $this->initv     = str_repeat(chr(0), mcrypt_enc_get_iv_size($this->mcrypt));
    }

    /**
     * Performs cleanup
     */
    public function __destruct()
    {
        if ($this->mcrypt) {
            mcrypt_module_close($this->mcrypt);
        }
    }

    /**
     * Fetch the cipher for mcrypt.
     *
     * @return string
     */
    abstract protected function getCipher();

    /**
     * {@inheritdoc}
     */
    protected function getPartSize()
    {
        return $this->blockSize;
    }

    /**
     * {@inheritdoc}
     */
    protected function mixParts1($part1, $part2)
    {
        return $this->encryptBlock($part1, $part2);
    }

    /**
     * {@inheritdoc}
     */
    protected function mixParts2($part1, $part2)
    {
        return $this->decryptBlock($part2, $part1);
    }

    /**
     * Encrypts a block using the suppied key
     *
     * @param string $input Plaintext to encrypt
     * @param string $key   Encryption key
     *
     * @return string Resulting ciphertext
     */
    private function encryptBlock($input, $key)

    {
        if (!$input && !$key) {
            return '';
        }

        $this->prepareCipher($key);
        $result = mcrypt_generic($this->mcrypt, $input);
        mcrypt_generic_deinit($this->mcrypt);

        return $result;
    }

    /**
     * Derypts a block using the suppied key
     *
     * @param string $input Ciphertext to decrypt
     * @param string $key   Encryption key
     *
     * @return string Resulting plaintext
     */
    private function decryptBlock($input, $key)

    {
        if (!$input && !$key) {
            return '';
        }

        $this->prepareCipher($key);
        $result = mdecrypt_generic($this->mcrypt, $input);
        mcrypt_generic_deinit($this->mcrypt);

        return $result;
    }

    /**
     * Sets up the mcrypt module
     *
     * @param string $key
     *
     * @return void
     */
    private function prepareCipher($key)
    {
        if (0 !== mcrypt_generic_init($this->mcrypt, $key, $this->initv)) {
            throw new \RuntimeException('Failed to prepare mcrypt module');
        }
    }
}


1		<?php
2
3		/*
4		* The RandomLib library for securely generating random numbers and strings in PHP
5		*
6		* @author Anthony Ferrara <[email protected]>
7		* @copyright 2011 The Authors
8		* @license http://www.opensource.org/licenses/mit-license.html MIT License
9		* @version Build @@version@@
10		*/
11
12		/**
13		* The Mcrypt abstract mixer class
14		*
15		* PHP version 5.3
16		*
17		* @category PHPCryptLib
18		* @package Random
19		* @subpackage Mixer
20		*
21		* @author Anthony Ferrara <[email protected]>
22		* @copyright 2013 The Authors
23		* @license http://www.opensource.org/licenses/mit-license.html MIT License
24		*
25		* @version Build @@version@@
26		*/
27		namespace RandomLib;
28
29		/**
30		* The mcrypt abstract mixer class
31		*
32		* @category PHPCryptLib
33		* @package Random
34		* @subpackage Mixer
35		*
36		* @author Anthony Ferrara <[email protected]>
37		* @author Chris Smith <[email protected]>
38		*/
39		abstract class AbstractMcryptMixer extends AbstractMixer
40		{
41		/**
42		* mcrypt module resource
43		*
44		* @var resource
45		*/
46		private $mcrypt;
47
48		/**
49		* Block size of cipher
50		*
51		* @var int
52		*/
53		private $blockSize;
54
55		/**
56		* Cipher initialization vector
57		*
58		* @var string
59		*/
60		private $initv;
61
62		/**
63		* {@inheritdoc}
64		*/
65		public static function test()
66		{
67		return extension_loaded('mcrypt');
68		}
69
70		/**
71		* Construct mcrypt mixer
72		*/
73		public function __construct()
74		{
75		$this->mcrypt = mcrypt_module_open($this->getCipher(), '', MCRYPT_MODE_ECB, '');
76		$this->blockSize = mcrypt_enc_get_block_size($this->mcrypt);
77		$this->initv = str_repeat(chr(0), mcrypt_enc_get_iv_size($this->mcrypt));
78		}
79
80		/**
81		* Performs cleanup
82		*/
83		public function __destruct()
84		{
85		if ($this->mcrypt) {
86		mcrypt_module_close($this->mcrypt);
87		}
88		}
89
90		/**
91		* Fetch the cipher for mcrypt.
92		*
93		* @return string
94		*/
95		abstract protected function getCipher();
96
97		/**
98		* {@inheritdoc}
99		*/
100		protected function getPartSize()
101		{
102		return $this->blockSize;
103		}
104
105		/**
106		* {@inheritdoc}
107		*/
108		protected function mixParts1($part1, $part2)
109		{
110		return $this->encryptBlock($part1, $part2);
111		}
112
113		/**
114		* {@inheritdoc}
115		*/
116		protected function mixParts2($part1, $part2)
117		{
118		return $this->decryptBlock($part2, $part1);
119		}
120
121		/**
122		* Encrypts a block using the suppied key
123		*
124		* @param string $input Plaintext to encrypt
125		* @param string $key Encryption key
126		*
127		* @return string Resulting ciphertext
128		*/
129	View Code Duplication	private function encryptBlock($input, $key)
		0 ignored issues – show Duplication introduced 2016-09-07 15:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130		{
131		if (!$input && !$key) {
132		return '';
133		}
134
135		$this->prepareCipher($key);
136		$result = mcrypt_generic($this->mcrypt, $input);
137		mcrypt_generic_deinit($this->mcrypt);
138
139		return $result;
140		}
141
142		/**
143		* Derypts a block using the suppied key
144		*
145		* @param string $input Ciphertext to decrypt
146		* @param string $key Encryption key
147		*
148		* @return string Resulting plaintext
149		*/
150	View Code Duplication	private function decryptBlock($input, $key)
		0 ignored issues – show Duplication introduced 2016-09-07 15:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		if (!$input && !$key) {
153		return '';
154		}
155
156		$this->prepareCipher($key);
157		$result = mdecrypt_generic($this->mcrypt, $input);
158		mcrypt_generic_deinit($this->mcrypt);
159
160		return $result;
161		}
162
163		/**
164		* Sets up the mcrypt module
165		*
166		* @param string $key
167		*
168		* @return void
169		*/
170		private function prepareCipher($key)
171		{
172		if (0 !== mcrypt_generic_init($this->mcrypt, $key, $this->initv)) {
173		throw new \RuntimeException('Failed to prepare mcrypt module');
174		}
175		}
176		}
177

ircmaxell / RandomLib

Issues (16)

Security Analysis not enabled

lib/RandomLib/AbstractMcryptMixer.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like