Completed
Push — master ( 3d39f9...d9b5c0 )
by Anthony
07:02 queued 04:32
created

RandTest   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 34
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 6
c 1
b 0
f 0
lcom 1
cbo 3
dl 34
loc 34
rs 10

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace RandomLib\Source;
4
5
use SecurityLib\Strength;
6
7
class RandTest extends \PHPUnit_Framework_TestCase {
8
9
    public static function provideGenerate() {
10
        $data = array();
11
        for ($i = 0; $i < 100; $i += 5) {
12
            $not = $i > 0 ? str_repeat(chr(0), $i) : chr(0);
13
            $data[] = array($i, $not);
14
        }
15
        return $data;
16
    }
17
18
    /**
19
     */
20
    public function testGetStrength() {
21
        if (defined('S_ALL')) {
22
            $strength = new Strength(Strength::LOW);
23
        } else {
24
            $strength = new Strength(Strength::VERYLOW);
25
        }
26
        $actual = Rand::getStrength();
27
        $this->assertEquals($actual, $strength);
28
    }
29
30
    /**
31
     * @dataProvider provideGenerate
32
     */
33
    public function testGenerate($length, $not) {
34
        $rand = new Rand;
35
        $stub = $rand->generate($length);
36
        $this->assertEquals($length, strlen($stub));
37
        $this->assertNotEquals($not, $stub);
38
    }
39
40
}
41