Issues in Hash.php - Fixed Issues - Inspection of "Merge pull request #30 from lavoiesl/supported-gen..." - ircmaxell/RandomLib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4d4232...ffcfa4 )

by Anthony

created 2016-09-07 15:14 UTC

lib/RandomLib/Mixer/Hash.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * The Hash medium strength mixer class
 *
 * This class implements a mixer based upon the recommendations in RFC 4086
 * section 5.2
 *
 * PHP version 5.3
 *
 * @see        http://tools.ietf.org/html/rfc4086#section-5.2
 * @category   PHPCryptLib
 * @package    Random
 * @subpackage Mixer
 * @author     Anthony Ferrara <[email protected]>
 * @copyright  2011 The Authors
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 * @version    Build @@version@@
 */

namespace RandomLib\Mixer;

use \SecurityLib\Strength;
use \SecurityLib\Util;

/**
 * The Hash medium strength mixer class
 *
 * This class implements a mixer based upon the recommendations in RFC 4086
 * section 5.2
 *
 * @see        http://tools.ietf.org/html/rfc4086#section-5.2
 * @category   PHPCryptLib
 * @package    Random
 * @subpackage Mixer
 * @author     Anthony Ferrara <[email protected]>
 */
class Hash extends \RandomLib\AbstractMixer {

    /**
     * @var string The hash instance to use
     */
    protected $hash = null;

    /**
     * Build the hash mixer
     *
     * @param string $hash The hash instance to use (defaults to sha512)
     *
     * @return void
     */
    public function __construct($hash = 'sha512') {
        $this->hash = $hash;
    }

    /**
     * Return an instance of Strength indicating the strength of the source
     *
     * @return Strength An instance of one of the strength classes
     */
    public static function getStrength() {
        return new Strength(Strength::MEDIUM);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Test to see if the mixer is available
     *
     * @return boolean If the mixer is available on the system
     */
    public static function test() {
        return true;
    }

    /**
     * Get the block size (the size of the individual blocks used for the mixing)
     *
     * @return int The block size
     */
    protected function getPartSize() {
        return Util::safeStrlen(hash($this->hash, '', true));
    }

    /**
     * Mix 2 parts together using one method
     *
     * @param string $part1 The first part to mix
     * @param string $part2 The second part to mix
     *
     * @return string The mixed data
     */
    protected function mixParts1($part1, $part2) {
        return hash_hmac($this->hash, $part1, $part2, true);
    }

    /**
     * Mix 2 parts together using another different method
     *
     * @param string $part1 The first part to mix
     * @param string $part2 The second part to mix
     *
     * @return string The mixed data
     */
    protected function mixParts2($part1, $part2) {
        return hash_hmac($this->hash, $part2, $part1, true);
    }

}


1			<?php
2			/**
3			* The Hash medium strength mixer class
4			*
5			* This class implements a mixer based upon the recommendations in RFC 4086
6			* section 5.2
7			*
8			* PHP version 5.3
9			*
10			* @see http://tools.ietf.org/html/rfc4086#section-5.2
11			* @category PHPCryptLib
12			* @package Random
13			* @subpackage Mixer
14			* @author Anthony Ferrara <[email protected]>
15			* @copyright 2011 The Authors
16			* @license http://www.opensource.org/licenses/mit-license.html MIT License
17			* @version Build @@version@@
18			*/
19
20			namespace RandomLib\Mixer;
21
22			use \SecurityLib\Strength;
23			use \SecurityLib\Util;
24
25			/**
26			* The Hash medium strength mixer class
27			*
28			* This class implements a mixer based upon the recommendations in RFC 4086
29			* section 5.2
30			*
31			* @see http://tools.ietf.org/html/rfc4086#section-5.2
32			* @category PHPCryptLib
33			* @package Random
34			* @subpackage Mixer
35			* @author Anthony Ferrara <[email protected]>
36			*/
37			class Hash extends \RandomLib\AbstractMixer {
38
39			/**
40			* @var string The hash instance to use
41			*/
42			protected $hash = null;
43
44			/**
45			* Build the hash mixer
46			*
47			* @param string $hash The hash instance to use (defaults to sha512)
48			*
49			* @return void
50			*/
51			public function __construct($hash = 'sha512') {
52			$this->hash = $hash;
53			}
54
55			/**
56			* Return an instance of Strength indicating the strength of the source
57			*
58			* @return Strength An instance of one of the strength classes
59			*/
60			public static function getStrength() {
61			return new Strength(Strength::MEDIUM);
			0 ignored issues – show Bug Best Practice introduced 2016-02-17 18:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \SecurityLib\...yLib\Strength::MEDIUM);` (`SecurityLib\Strength`) is incompatible with the return type declared by the interface `RandomLib\Mixer::getStrength` of type `RandomLib\Strength`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
62			}
63
64			/**
65			* Test to see if the mixer is available
66			*
67			* @return boolean If the mixer is available on the system
68			*/
69			public static function test() {
70			return true;
71			}
72
73			/**
74			* Get the block size (the size of the individual blocks used for the mixing)
75			*
76			* @return int The block size
77			*/
78			protected function getPartSize() {
79			return Util::safeStrlen(hash($this->hash, '', true));
80			}
81
82			/**
83			* Mix 2 parts together using one method
84			*
85			* @param string $part1 The first part to mix
86			* @param string $part2 The second part to mix
87			*
88			* @return string The mixed data
89			*/
90			protected function mixParts1($part1, $part2) {
91			return hash_hmac($this->hash, $part1, $part2, true);
92			}
93
94			/**
95			* Mix 2 parts together using another different method
96			*
97			* @param string $part1 The first part to mix
98			* @param string $part2 The second part to mix
99			*
100			* @return string The mixed data
101			*/
102			protected function mixParts2($part1, $part2) {
103			return hash_hmac($this->hash, $part2, $part1, true);
104			}
105
106			}
107

ircmaxell / RandomLib

Push — master ( 4d4232...ffcfa4 )

lib/RandomLib/Mixer/Hash.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like