Irazasyed\VideoDownloader\Factory

Complexity

Total Complexity

14

Size/Duplication

Total Lines	134
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	make()	0	33	5
A	getVideoInfo()	0	4	1
A	download()	0	4	1
A	getInstance()	0	8	2
A	setProvider()	0	9	2
A	getProvider()	0	4	1

<?php

namespace Irazasyed\VideoDownloader;

use Irazasyed\VideoDownloader\Exceptions\VideoDownloaderException;
use Irazasyed\VideoDownloader\Providers\Facebook;
use Irazasyed\VideoDownloader\Providers\ProviderInterface;

class Factory
{
    /**
     * @var ProviderInterface
     */
    protected $provider;

    /**
     * @var array Get Default Available Providers.
     */
    protected $providers = [
        'facebook' => Facebook::class,
    ];

    /**
     * Factory constructor.
     *
     * @param null $provider
     */
    public function __construct($provider = null)
    {
        if (isset($provider)) {
            return $this->make($provider);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

        }
    }

    /**
     * @param $provider
     *
     * @throws VideoDownloaderException
     *
     * @return $this
     */
    public function make($provider)
    {
        if (!is_object($provider)) {
            if (array_key_exists($provider, $this->providers)) {
                $provider = $this->providers[$provider];
            } elseif (!class_exists($provider)) {
                throw new VideoDownloaderException(
                    sprintf(
                        'Provider class "%s" not found! Please make sure the class exists.',
                        $provider
                    )
                );
            }

            $provider = new $provider();
        }

        if ($provider instanceof ProviderInterface) {
            /*
             * At this stage we definitely have a proper provider to use.
             *
             * @var Provider $provider
             */
            return $this->provider = $provider;

It seems like $provider of type object<Irazasyed\VideoDownloader\Provider> is incompatible with the declared type object<Irazasyed\VideoDownloader\Providers\ProviderInterface> of property $provider.

        }

        throw new VideoDownloaderException(
            sprintf(
                'Provider class "%s" should be an instance of "Irazasyed\VideoDownloader\Providers\ProviderInterface"',
                get_class($provider)
            )
        );
    }

    /**
     * Gets Video Download Links with Meta Data from the Provider.
     * Returns HD & SD Quality Links.
     *
     * @param $url
     *
     * @return array
     */
    public function getVideoInfo($url)
    {
        return $this->provider->getVideoInfo($url);
    }

    /**
     * Download remote file from server
     * and save it locally using HTTP Client.
     *
     * @param string $url            The URL to Remote File to Download.
     * @param string $dstFilename    Destination Filename (Accepts File Path too).
     * @param bool   $isAsyncRequest
     *
     * @return string
     */
    public function download($url, $dstFilename, $isAsyncRequest = false)

The parameter $dstFilename is not used and could be removed.

The parameter $isAsyncRequest is not used and could be removed.

    {
        return $this->provider->download($url);
    }

    /**
     * @param null $provider
     *
     * @return ProviderInterface
     */
    public function getInstance($provider = null)
    {
        if (isset($this->provider)) {
            return $this->provider;
        }

        return $this->providers[$provider];
    }

    /**
     * Add Provider to List.
     *
     * @param ProviderInterface $provider
     *
     * @return $this
     */
    public function setProvider(ProviderInterface $provider)
    {
        $class = get_class($provider);
        if (!array_key_exists($class, $this->providers)) {
            $this->providers[$class] = $provider;
        }

        return $this;
    }

    /**
     * Returns Current Provider Instance.
     */
    public function getProvider()
    {
        return $this->provider;
    }
}