CommandBus::resolveCommandObject() - Code Metrics - Inspection of "Merge pull request #442 from imanghafoori1/master" - irazasyed/telegram-bot-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b445b6...5b77a0 )

by Irfaq

created 2017-09-16 18:20 UTC

CommandBus::resolveCommandObject() B

↳ Parent: Project

Complexity

Conditions	5
Paths	7

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	5.3906

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	6
cts	8
cp	0.75
rs	8.439
c	0
b	0
f	0
cc	5
eloc	14
nc	7
nop	1
crap	5.3906

<?php

namespace Telegram\Bot\Commands;

use Telegram\Bot\Answers\AnswerBus;
use Telegram\Bot\Api;
use Telegram\Bot\Objects\Update;
use Telegram\Bot\Exceptions\TelegramSDKException;

/**
 * Class CommandBus.
 */
class CommandBus extends AnswerBus
{
    /**
     * @var Command[] Holds all commands.
     */
    protected $commands = [];

    /**
     * @var Command[] Holds all commands' aliases.
     */
    protected $commandAliases = [];

    /**
     * Instantiate Command Bus.
     *
     * @param Api $telegram
     *
     * @throws TelegramSDKException
     */
    public function __construct(Api $telegram)
    {
        $this->telegram = $telegram;
    }

    /**
     * Returns the list of commands.
     *
     * @return array
     */
    public function getCommands()
    {
        return $this->commands;
    }

    /**
     * Add a list of commands.
     *
     * @param array $commands
     *
     * @return CommandBus
     */
    public function addCommands(array $commands)
    {
        foreach ($commands as $command) {
            $this->addCommand($command);
        }

        return $this;
    }

    /**
     * Add a command to the commands list.
     *
     * @param CommandInterface|string $command Either an object or full path to the command class.
     *
     * @throws TelegramSDKException
     *
     * @return CommandBus
     */
    public function addCommand($command)
    {
        $command = $this->resolveCommandObject($command);

        /*
         * At this stage we definitely have a proper command to use.
         *
         * @var Command $command
         */
        $this->commands[$command->getName()] = $command;

        $aliases = $command->getAliases();

        if (empty($aliases)) {
            return $this;
        }

        foreach ($command->getAliases() as $alias) {
            if (isset($this->commands[$alias])) {

                throw new TelegramSDKException(sprintf(
                    '[Error] Alias [%s] conflicts with command name of "%s" try with another name or remove this alias from the list.',
                    $alias,
                    get_class($command)
                ));
            }

            if (isset($this->commandAliases[$alias])) {

                throw new TelegramSDKException(sprintf(
                    '[Error] Alias [%s] conflicts with another command\'s alias list: "%s", try with another name or remove this alias from the list.',
                    $alias,
                    get_class($command)
                ));
            }

            $this->commandAliases[$alias] = $command;
        }

        return $this;


    }

    /**
     * Remove a command from the list.
     *
     * @param $name
     *
     * @return CommandBus
     */
    public function removeCommand($name)
    {
        unset($this->commands[$name]);

        return $this;
    }

    /**
     * Removes a list of commands.
     *
     * @param array $names
     *
     * @return CommandBus
     */
    public function removeCommands(array $names)
    {
        foreach ($names as $name) {
            $this->removeCommand($name);
        }

        return $this;
    }

    /**
     * Parse a Command for a Match.
     *
     * @param $text
     *
     * @throws \InvalidArgumentException
     *
     * @return array
     */
    public function parseCommand($text)
    {
        if (trim($text) === '') {
            throw new \InvalidArgumentException('Message is empty, Cannot parse for command');
        }

        preg_match('/^\/([^\s@]+)@?(\S+)?\s?(.*)$/s', $text, $matches);

        return $matches;
    }

    /**
     * Handles Inbound Messages and Executes Appropriate Command.
     *
     * @param $message
     * @param $update
     *
     * @throws TelegramSDKException
     *
     * @return Update
     */
    protected function handler($message, Update $update)
    {
        $match = $this->parseCommand($message);
        if (!empty($match)) {
            $command = strtolower($match[1]); //All commands must be lowercase.

//            $bot = (!empty($match[2])) ? $match[2] : '';
            $arguments = $match[3];

            $this->execute($command, $arguments, $update);
        }

        return $update;
    }

    /**
     * Execute the command.
     *
     * @param $name
     * @param $arguments
     * @param $message
     *
     * @return mixed
     */
    protected function execute($name, $arguments, $message)
    {
        if (array_key_exists($name, $this->commands)) {
            return $this->commands[$name]->make($this->telegram, $arguments, $message);
        } elseif (array_key_exists($name, $this->commandAliases)) {
            return $this->commandAliases[$name]->make($this->telegram, $arguments, $message);
        } elseif (array_key_exists('help', $this->commands)) {
            return $this->commands['help']->make($this->telegram, $arguments, $message);
        }

        return 'Ok';
    }

    /**
     * @param $command
     * @return object
     * @throws \Telegram\Bot\Exceptions\TelegramSDKException
     */
    private function resolveCommandObject($command)
    {
        if (! is_object($command)) {
            if (! class_exists($command)) {
                throw new TelegramSDKException(sprintf('Command class "%s" not found! Please make sure the class exists.', $command));
            }

            if ($this->telegram->hasContainer()) {
                $command = $this->buildDependencyInjectedAnswer($command);
            } else {
                $command = new $command();
            }
        }

        if (!($command instanceof CommandInterface)) {

            throw new TelegramSDKException(
                sprintf(
                    'Command class "%s" should be an instance of "Telegram\Bot\Commands\CommandInterface"',
                    get_class($command)
                )
            );
        }

        return $command;
    }
}


1			<?php
2
3			namespace Telegram\Bot\Commands;
4
5			use Telegram\Bot\Answers\AnswerBus;
6			use Telegram\Bot\Api;
7			use Telegram\Bot\Objects\Update;
8			use Telegram\Bot\Exceptions\TelegramSDKException;
9
10			/**
11			* Class CommandBus.
12			*/
13			class CommandBus extends AnswerBus
14			{
15			/**
16			* @var Command[] Holds all commands.
17			*/
18			protected $commands = [];
19
20			/**
21			* @var Command[] Holds all commands' aliases.
22			*/
23			protected $commandAliases = [];
24
25			/**
26			* Instantiate Command Bus.
27			*
28			* @param Api $telegram
29			*
30			* @throws TelegramSDKException
31			*/
32	92		public function __construct(Api $telegram)
33			{
34	92		$this->telegram = $telegram;
35	92		}
36
37			/**
38			* Returns the list of commands.
39			*
40			* @return array
41			*/
42	10		public function getCommands()
43			{
44	10		return $this->commands;
45			}
46
47			/**
48			* Add a list of commands.
49			*
50			* @param array $commands
51			*
52			* @return CommandBus
53			*/
54	8		public function addCommands(array $commands)
55			{
56	8		foreach ($commands as $command) {
57	8		$this->addCommand($command);
58	8		}
59
60	8		return $this;
61			}
62
63			/**
64			* Add a command to the commands list.
65			*
66			* @param CommandInterface\|string $command Either an object or full path to the command class.
67			*
68			* @throws TelegramSDKException
69			*
70			* @return CommandBus
71			*/
72	20		public function addCommand($command)
73			{
74	20		$command = $this->resolveCommandObject($command);
75	12
76	2		/*
77	2		* At this stage we definitely have a proper command to use.
78	2		*
79			* @var Command $command
80	2		*/
81	2		$this->commands[$command->getName()] = $command;
82
83			$aliases = $command->getAliases();
84	10
85	2		if (empty($aliases)) {
86	2		return $this;
87	8		}
88
89	10		foreach ($command->getAliases() as $alias) {
90		View Code Duplication	if (isset($this->commands[$alias])) {
			0 ignored issues – show Duplication introduced 2016-04-16 01:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91	18		throw new TelegramSDKException(sprintf(
92			'[Error] Alias [%s] conflicts with command name of "%s" try with another name or remove this alias from the list.',
93			$alias,
94			get_class($command)
95			));
96			}
97
98	16	View Code Duplication	if (isset($this->commandAliases[$alias])) {
			0 ignored issues – show Duplication introduced 2016-04-16 01:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
99			throw new TelegramSDKException(sprintf(
100	16		'[Error] Alias [%s] conflicts with another command\'s alias list: "%s", try with another name or remove this alias from the list.',
101			$alias,
102	16		get_class($command)
103	16		));
104			}
105
106			$this->commandAliases[$alias] = $command;
107			}
108
109			return $this;
110
111
112			}
113
114			/**
115			* Remove a command from the list.
116			*
117			* @param $name
118			*
119			* @return CommandBus
120			*/
121			public function removeCommand($name)
122			{
123			unset($this->commands[$name]);
124
125			return $this;
126			}
127
128			/**
129	2		* Removes a list of commands.
130	2		*
131	2		* @param array $names
132	2		*
133	2		* @return CommandBus
134	2		*/
135			public function removeCommands(array $names)
136			{
137			foreach ($names as $name) {
138			$this->removeCommand($name);
139			}
140
141			return $this;
142			}
143
144	4		/**
145			* Parse a Command for a Match.
146	4		*
147			* @param $text
148	4		*
149			* @throws \InvalidArgumentException
150			*
151			* @return array
152			*/
153			public function parseCommand($text)
154			{
155			if (trim($text) === '') {
156			throw new \InvalidArgumentException('Message is empty, Cannot parse for command');
157			}
158	2
159			preg_match('/^\/([^\s@]+)@?(\S+)?\s?(.*)$/s', $text, $matches);
160	2
161	2		return $matches;
162	2		}
163
164	2		/**
165			* Handles Inbound Messages and Executes Appropriate Command.
166			*
167			* @param $message
168			* @param $update
169			*
170			* @throws TelegramSDKException
171			*
172			* @return Update
173			*/
174			protected function handler($message, Update $update)
175			{
176	16		$match = $this->parseCommand($message);
177			if (!empty($match)) {
178	16		$command = strtolower($match[1]); //All commands must be lowercase.
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-25 22:27 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
179	2		// $bot = (!empty($match[2])) ? $match[2] : '';
180			$arguments = $match[3];
181
182	14		$this->execute($command, $arguments, $update);
183			}
184	14
185			return $update;
186			}
187
188			/**
189			* Execute the command.
190			*
191			* @param $name
192			* @param $arguments
193			* @param $message
194			*
195			* @return mixed
196			*/
197	8		protected function execute($name, $arguments, $message)
198			{
199	8		if (array_key_exists($name, $this->commands)) {
200	8		return $this->commands[$name]->make($this->telegram, $arguments, $message);
201	8		} elseif (array_key_exists($name, $this->commandAliases)) {
202			return $this->commandAliases[$name]->make($this->telegram, $arguments, $message);
203	8		} elseif (array_key_exists('help', $this->commands)) {
204			return $this->commands['help']->make($this->telegram, $arguments, $message);
205	8		}
206	8
207			return 'Ok';
208	8		}
209
210			/**
211			* @param $command
212			* @return object
213			* @throws \Telegram\Bot\Exceptions\TelegramSDKException
214			*/
215			private function resolveCommandObject($command)
216			{
217			if (! is_object($command)) {
218			if (! class_exists($command)) {
219			throw new TelegramSDKException(sprintf('Command class "%s" not found! Please make sure the class exists.', $command));
220	10		}
221
222	10		if ($this->telegram->hasContainer()) {
223	6		$command = $this->buildDependencyInjectedAnswer($command);
224	4		} else {
225			$command = new $command();
226	4		}
227			}
228
229			if (!($command instanceof CommandInterface)) {
230	4
231			throw new TelegramSDKException(
232			sprintf(
233			'Command class "%s" should be an instance of "Telegram\Bot\Commands\CommandInterface"',
234			get_class($command)
235			)
236			);
237			}
238
239			return $command;
240			}
241			}
242

irazasyed / telegram-bot-sdk

Push — master ( b445b6...5b77a0 )

CommandBus::resolveCommandObject() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like