Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class Emojify |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var Singleton The reference to *Singleton* instance of this class |
||
| 11 | */ |
||
| 12 | private static $instance; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * The path to the file containing the emoji map. |
||
| 16 | * |
||
| 17 | * @var string |
||
| 18 | */ |
||
| 19 | const DEFAULT_EMOJI_MAP_FILE = '/../Storage/emoji.json'; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * The path to the file containing the emoji map. |
||
| 23 | * |
||
| 24 | * @var string |
||
| 25 | */ |
||
| 26 | protected $emojiMapFile; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * The array mapping words to emoji. |
||
| 30 | * |
||
| 31 | * @var array |
||
| 32 | */ |
||
| 33 | protected $emojiMap; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * The array mapping emoji back to words. |
||
| 37 | 76 | * |
|
| 38 | * @var array |
||
| 39 | 76 | */ |
|
| 40 | 76 | protected $wordMap; |
|
| 41 | 76 | ||
| 42 | /** |
||
| 43 | 76 | * Protected Emojify constructor to prevent creating a new instance of the |
|
| 44 | 2 | * *Singleton* via the `new` operator from outside of this class. |
|
| 45 | * |
||
| 46 | * @throws TelegramEmojiMapFileNotFoundException |
||
| 47 | 76 | */ |
|
| 48 | 76 | protected function __construct() |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Returns the *Singleton* instance of this class. |
||
| 55 | * |
||
| 56 | * @return Singleton The *Singleton* instance. |
||
| 57 | */ |
||
| 58 | public static function getInstance() |
||
| 66 | |||
| 67 | /** |
||
| 68 | * Set File Path to Emoji Map File. |
||
| 69 | * |
||
| 70 | * @param string $emojiMapFile |
||
| 71 | * |
||
| 72 | * @return Emojify |
||
| 73 | */ |
||
| 74 | public function setEmojiMapFile($emojiMapFile) |
||
| 81 | |||
| 82 | /** |
||
| 83 | 10 | * Translate Word to Emoji |
|
| 84 | * |
||
| 85 | 10 | * @param $text |
|
| 86 | * |
||
| 87 | * @return mixed |
||
| 88 | */ |
||
| 89 | public function toEmoji($text) |
||
| 93 | |||
| 94 | /** |
||
| 95 | 8 | * Alias of toEmoji() |
|
| 96 | * |
||
| 97 | 8 | * @param $text |
|
| 98 | * |
||
| 99 | * @return mixed |
||
| 100 | */ |
||
| 101 | public static function text($text) |
||
| 105 | |||
| 106 | /** |
||
| 107 | * Translate Emoji to Word |
||
| 108 | * |
||
| 109 | * @param $text |
||
| 110 | * |
||
| 111 | * @return mixed |
||
| 112 | 14 | */ |
|
| 113 | 14 | public function toWord($text) |
|
| 117 | 14 | ||
| 118 | 10 | /** |
|
| 119 | * Alias of toWord() |
||
| 120 | * |
||
| 121 | 6 | * @param $text |
|
| 122 | * |
||
| 123 | * @return mixed |
||
| 124 | */ |
||
| 125 | public static function translate($text) |
||
| 129 | |||
| 130 | /** |
||
| 131 | * Replace |
||
| 132 | * |
||
| 133 | * @param $line |
||
| 134 | 6 | * @param $replace |
|
| 135 | * @param bool $toWord |
||
| 136 | 6 | * @param string $delimiter |
|
| 137 | 6 | * |
|
| 138 | 6 | * @return mixed |
|
| 139 | */ |
||
| 140 | 6 | protected function replace($line, $replace, $toWord = false, $delimiter = ':') |
|
| 153 | |||
| 154 | 10 | /** |
|
| 155 | 10 | * Finds words enclosed by the delimiter and converts them to the |
|
| 156 | 10 | * appropriate emoji character. |
|
| 157 | * |
||
| 158 | 10 | * @param $line |
|
| 159 | * @param $replace |
||
| 160 | * @param $delimiter |
||
| 161 | * |
||
| 162 | * @return mixed |
||
| 163 | */ |
||
| 164 | View Code Duplication | protected function wordToEmojiReplace($line, $replace, $delimiter) |
|
| 172 | |||
| 173 | /** |
||
| 174 | * Finds emojis and replaces them with text enclosed by the delimiter |
||
| 175 | * |
||
| 176 | * @param $line |
||
| 177 | * @param $replace |
||
| 178 | * @param $delimiter |
||
| 179 | * |
||
| 180 | * @return mixed |
||
| 181 | */ |
||
| 182 | View Code Duplication | protected function emojiToWordReplace($line, $replace, $delimiter) |
|
| 190 | |||
| 191 | /** |
||
| 192 | * Get Emoji Map Array. |
||
| 193 | * |
||
| 194 | * @return array |
||
| 195 | * @throws TelegramEmojiMapFileNotFoundException |
||
| 196 | */ |
||
| 197 | protected function getEmojiMap() |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Setup Emoji Maps. |
||
| 212 | * |
||
| 213 | * @throws TelegramEmojiMapFileNotFoundException |
||
| 214 | */ |
||
| 215 | protected function setupEmojiMaps() |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Private clone method to prevent cloning of the instance of the |
||
| 223 | * *Singleton* instance. |
||
| 224 | * |
||
| 225 | * @return void |
||
| 226 | */ |
||
| 227 | private function __clone() |
||
| 230 | |||
| 231 | /** |
||
| 232 | * Private unserialize method to prevent unserializing of the *Singleton* |
||
| 233 | * instance. |
||
| 234 | * |
||
| 235 | * @return void |
||
| 236 | */ |
||
| 237 | private function __wakeup() |
||
| 240 | } |
||
| 241 |
Let’s assume you have a class which uses late-static binding:
The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the
getSomeVariable()on that sub-class, you will receive a runtime error:In the case above, it makes sense to update
SomeClassto useselfinstead: