Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Emojify |
||
8 | { |
||
9 | /** |
||
10 | * @var Emojify The reference to *Singleton* instance of this class |
||
11 | */ |
||
12 | private static $instance; |
||
13 | |||
14 | /** |
||
15 | * The path to the file containing the emoji map. |
||
16 | * |
||
17 | * @var string |
||
18 | */ |
||
19 | const DEFAULT_EMOJI_MAP_FILE = '/../Storage/emoji.json'; |
||
20 | |||
21 | /** |
||
22 | * The path to the file containing the emoji map. |
||
23 | * |
||
24 | * @var string |
||
25 | */ |
||
26 | protected $emojiMapFile; |
||
27 | |||
28 | /** |
||
29 | * The array mapping words to emoji. |
||
30 | * |
||
31 | * @var array |
||
32 | */ |
||
33 | protected $emojiMap; |
||
34 | |||
35 | /** |
||
36 | * The array mapping emoji back to words. |
||
37 | * |
||
38 | * @var array |
||
39 | */ |
||
40 | protected $wordMap; |
||
41 | |||
42 | /** |
||
43 | * Protected Emojify constructor to prevent creating a new instance of the |
||
44 | * *Singleton* via the `new` operator from outside of this class. |
||
45 | * |
||
46 | * @throws TelegramEmojiMapFileNotFoundException |
||
47 | */ |
||
48 | 12 | protected function __construct() |
|
52 | |||
53 | /** |
||
54 | * Returns the *Singleton* instance of this class. |
||
55 | * |
||
56 | * @return Emojify The *Singleton* instance. |
||
57 | */ |
||
58 | 12 | public static function getInstance() |
|
66 | |||
67 | /** |
||
68 | * Set File Path to Emoji Map File. |
||
69 | * |
||
70 | * @param string $emojiMapFile |
||
71 | * |
||
72 | * @return Emojify |
||
73 | */ |
||
74 | 2 | public function setEmojiMapFile($emojiMapFile) |
|
81 | |||
82 | /** |
||
83 | * Translate Word to Emoji |
||
84 | * |
||
85 | * @param $text |
||
86 | * |
||
87 | * @return mixed |
||
88 | */ |
||
89 | 4 | public function toEmoji($text) |
|
93 | |||
94 | /** |
||
95 | * Alias of toEmoji() |
||
96 | * |
||
97 | * @param $text |
||
98 | * |
||
99 | * @return mixed |
||
100 | */ |
||
101 | 4 | public static function text($text) |
|
105 | |||
106 | /** |
||
107 | * Translate Emoji to Word |
||
108 | * |
||
109 | * @param $text |
||
110 | * |
||
111 | * @return mixed |
||
112 | */ |
||
113 | 4 | public function toWord($text) |
|
117 | |||
118 | /** |
||
119 | * Alias of toWord() |
||
120 | * |
||
121 | * @param $text |
||
122 | * |
||
123 | * @return mixed |
||
124 | */ |
||
125 | 4 | public static function translate($text) |
|
129 | |||
130 | /** |
||
131 | * Replace |
||
132 | * |
||
133 | * @param $line |
||
134 | * @param $replace |
||
135 | * @param bool $toWord |
||
136 | * @param string $delimiter |
||
137 | * |
||
138 | * @return mixed |
||
139 | */ |
||
140 | 8 | protected function replace($line, $replace, $toWord = false, $delimiter = ':') |
|
148 | |||
149 | /** |
||
150 | * Finds words enclosed by the delimiter and converts them to the |
||
151 | * appropriate emoji character. |
||
152 | * |
||
153 | * @param $line |
||
154 | * @param $replace |
||
155 | * @param $delimiter |
||
156 | * |
||
157 | * @return mixed |
||
158 | */ |
||
159 | 4 | View Code Duplication | protected function wordToEmojiReplace($line, $replace, $delimiter) |
167 | |||
168 | /** |
||
169 | * Finds emojis and replaces them with text enclosed by the delimiter |
||
170 | * |
||
171 | * @param $line |
||
172 | * @param $replace |
||
173 | * @param $delimiter |
||
174 | * |
||
175 | * @return mixed |
||
176 | */ |
||
177 | 4 | View Code Duplication | protected function emojiToWordReplace($line, $replace, $delimiter) |
185 | |||
186 | /** |
||
187 | * Get Emoji Map Array. |
||
188 | * |
||
189 | * @return array |
||
190 | * @throws TelegramEmojiMapFileNotFoundException |
||
191 | */ |
||
192 | 12 | protected function getEmojiMap() |
|
204 | |||
205 | /** |
||
206 | * Setup Emoji Maps. |
||
207 | * |
||
208 | * @throws TelegramEmojiMapFileNotFoundException |
||
209 | */ |
||
210 | 12 | protected function setupEmojiMaps() |
|
215 | |||
216 | /** |
||
217 | * Private clone method to prevent cloning of the instance of the |
||
218 | * *Singleton* instance. |
||
219 | * |
||
220 | * @return void |
||
221 | */ |
||
222 | private function __clone() |
||
225 | |||
226 | /** |
||
227 | * Private unserialize method to prevent unserializing of the *Singleton* |
||
228 | * instance. |
||
229 | * |
||
230 | * @return void |
||
231 | */ |
||
232 | private function __wakeup() |
||
235 | } |
||
236 |
Let’s assume you have a class which uses late-static binding:
The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the
getSomeVariable()
on that sub-class, you will receive a runtime error:In the case above, it makes sense to update
SomeClass
to useself
instead: