GeocoderTest::getExpectedData() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/irania..." - iranianpep/geocoder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e0ca5...478748 )

by Ehsan

created 2017-07-01 03:02 UTC

GeocoderTest::getExpectedData() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	58
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	58
rs	9.639
c	1
b	0
f	0

How to fix Long Method

<?php

namespace Geocoder;

use PHPUnit\Framework\TestCase;

class GeocoderTest extends TestCase
{
    const VALID_ADDRESS = 'Melbourne, Australia';
    const VALID_ADDRESS_MULTIPLE_RESULT = 'springfield';
    const UNKNOWN_ADDRESS = 'Dummy Address';

    public function testGeocode()
    {
        $this->assertEquals(
            $this->getExpectedData(),
            (new Geocoder())->geocode(self::VALID_ADDRESS)
        );
    }

    public function testGeocodeMultipleResult()
    {
        $result = (new Geocoder())->geocode(self::VALID_ADDRESS_MULTIPLE_RESULT);
        $result = json_decode($result, true);

        $this->assertEquals(
            6,
            count($result['results'])
        );
    }

    public function testGeocodeUnknownAddress()
    {
        $this->assertEquals(
            $this->getExpectedNullData(),
            (new Geocoder())->geocode(self::UNKNOWN_ADDRESS)
        );
    }

    public function testGetLatLngUnknownAddress()
    {
        $this->assertEquals(
            null,
            (new Geocoder())->getLatLng(self::UNKNOWN_ADDRESS)
        );
    }

    public function testGetLatLng()
    {
        $this->assertEquals(
            [
                [
                    'lat' => '-37.8136276',
                    'lng' => '144.9630576',
                ],
            ],
            (new Geocoder())->getLatLng(self::VALID_ADDRESS)
        );
    }

    public function testGetLatLngMultipleResult()
    {
        $this->assertEquals(
            6,
            count((new Geocoder())->getLatLng(self::VALID_ADDRESS_MULTIPLE_RESULT))
        );
    }

    private function getExpectedNullData()
    {
        return '{
   "results" : [],
   "status" : "ZERO_RESULTS"
}
';
    }

    private function getExpectedData()
    {
        return '{
   "results" : [
      {
         "address_components" : [
            {
               "long_name" : "Melbourne",
               "short_name" : "Melbourne",
               "types" : [ "colloquial_area", "locality", "political" ]
            },
            {
               "long_name" : "Victoria",
               "short_name" : "VIC",
               "types" : [ "administrative_area_level_1", "political" ]
            },
            {
               "long_name" : "Australia",
               "short_name" : "AU",
               "types" : [ "country", "political" ]
            }
         ],
         "formatted_address" : "Melbourne VIC, Australia",
         "geometry" : {
            "bounds" : {
               "northeast" : {
                  "lat" : -37.5112737,
                  "lng" : 145.5125288
               },
               "southwest" : {
                  "lat" : -38.4338593,
                  "lng" : 144.5937418
               }
            },
            "location" : {
               "lat" : -37.8136276,
               "lng" : 144.9630576
            },
            "location_type" : "APPROXIMATE",
            "viewport" : {
               "northeast" : {
                  "lat" : -37.5112737,
                  "lng" : 145.5125288
               },
               "southwest" : {
                  "lat" : -38.4338593,
                  "lng" : 144.5937418
               }
            }
         },
         "place_id" : "ChIJ90260rVG1moRkM2MIXVWBAQ",
         "types" : [ "colloquial_area", "locality", "political" ]
      }
   ],
   "status" : "OK"
}
';
    }
}


1			<?php
2
3			namespace Geocoder;
4
5			use PHPUnit\Framework\TestCase;
6
7			class GeocoderTest extends TestCase
8			{
9			const VALID_ADDRESS = 'Melbourne, Australia';
10			const VALID_ADDRESS_MULTIPLE_RESULT = 'springfield';
11			const UNKNOWN_ADDRESS = 'Dummy Address';
12
13			public function testGeocode()
14			{
15			$this->assertEquals(
16			$this->getExpectedData(),
17			(new Geocoder())->geocode(self::VALID_ADDRESS)
18			);
19			}
20
21			public function testGeocodeMultipleResult()
22			{
23			$result = (new Geocoder())->geocode(self::VALID_ADDRESS_MULTIPLE_RESULT);
24			$result = json_decode($result, true);
25
26			$this->assertEquals(
27			6,
28			count($result['results'])
29			);
30			}
31
32			public function testGeocodeUnknownAddress()
33			{
34			$this->assertEquals(
35			$this->getExpectedNullData(),
36			(new Geocoder())->geocode(self::UNKNOWN_ADDRESS)
37			);
38			}
39
40			public function testGetLatLngUnknownAddress()
41			{
42			$this->assertEquals(
43			null,
44			(new Geocoder())->getLatLng(self::UNKNOWN_ADDRESS)
45			);
46			}
47
48			public function testGetLatLng()
49			{
50			$this->assertEquals(
51			[
52			[
53			'lat' => '-37.8136276',
54			'lng' => '144.9630576',
55			],
56			],
57			(new Geocoder())->getLatLng(self::VALID_ADDRESS)
58			);
59			}
60
61			public function testGetLatLngMultipleResult()
62			{
63			$this->assertEquals(
64			6,
65			count((new Geocoder())->getLatLng(self::VALID_ADDRESS_MULTIPLE_RESULT))
66			);
67			}
68
69			private function getExpectedNullData()
70			{
71			return '{
72			"results" : [],
73			"status" : "ZERO_RESULTS"
74			}
75			';
76			}
77
78			private function getExpectedData()
79			{
80			return '{
81			"results" : [
82			{
83			"address_components" : [
84			{
85			"long_name" : "Melbourne",
86			"short_name" : "Melbourne",
87			"types" : [ "colloquial_area", "locality", "political" ]
88			},
89			{
90			"long_name" : "Victoria",
91			"short_name" : "VIC",
92			"types" : [ "administrative_area_level_1", "political" ]
93			},
94			{
95			"long_name" : "Australia",
96			"short_name" : "AU",
97			"types" : [ "country", "political" ]
98			}
99			],
100			"formatted_address" : "Melbourne VIC, Australia",
101			"geometry" : {
102			"bounds" : {
103			"northeast" : {
104			"lat" : -37.5112737,
105			"lng" : 145.5125288
106			},
107			"southwest" : {
108			"lat" : -38.4338593,
109			"lng" : 144.5937418
110			}
111			},
112			"location" : {
113			"lat" : -37.8136276,
114			"lng" : 144.9630576
115			},
116			"location_type" : "APPROXIMATE",
117			"viewport" : {
118			"northeast" : {
119			"lat" : -37.5112737,
120			"lng" : 145.5125288
121			},
122			"southwest" : {
123			"lat" : -38.4338593,
124			"lng" : 144.5937418
125			}
126			}
127			},
128			"place_id" : "ChIJ90260rVG1moRkM2MIXVWBAQ",
129			"types" : [ "colloquial_area", "locality", "political" ]
130			}
131			],
132			"status" : "OK"
133			}
134			';
135			}
136			}
137

iranianpep / geocoder

Push — master ( 9e0ca5...478748 )

GeocoderTest::getExpectedData() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like