| Conditions | 9 |
| Paths | 20 |
| Total Lines | 99 |
| Code Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 13 | public function dataProvider() |
||
| 14 | { |
||
| 15 | // originalSize, compressedSize, relativeHeaderOffset, diskNumber |
||
| 16 | $sizesLong = [ |
||
| 17 | 0, |
||
| 18 | 12345, |
||
| 19 | MAX_INT_16, |
||
| 20 | MAX_INT_32, |
||
| 21 | 64*1024*1024*1024, |
||
| 22 | \PHP_INT_MAX |
||
| 23 | ]; |
||
| 24 | |||
| 25 | $sizesShort = [ |
||
| 26 | 0, |
||
| 27 | 12345, |
||
| 28 | MAX_INT_16, |
||
| 29 | 2*1024*1024*1024, |
||
| 30 | 0x7FFFFFFF, |
||
| 31 | ]; |
||
| 32 | |||
| 33 | $data = []; |
||
| 34 | foreach ($sizesLong as $originalSize) { |
||
| 35 | foreach ($sizesLong as $compressedSize) { |
||
| 36 | foreach ($sizesLong as $relativeHeaderOffset) { |
||
| 37 | foreach ($sizesShort as $diskNumber) { |
||
| 38 | $name = $originalSize . ', ' . $compressedSize . ', ' . $relativeHeaderOffset . ', ' . $diskNumber; |
||
| 39 | $dataSize = 0; |
||
| 40 | $encoded = ''; |
||
| 41 | |||
| 42 | if ($originalSize >= MAX_INT_32) { |
||
| 43 | $dataSize += 8; |
||
| 44 | $encoded .= \pack('P', $originalSize); |
||
| 45 | $parameterOriginalSize = $originalSize; |
||
| 46 | $legacyOriginalSize = MAX_INT_32; |
||
| 47 | } else { |
||
| 48 | $legacyOriginalSize = $originalSize; |
||
| 49 | $parameterOriginalSize = null; |
||
| 50 | } |
||
| 51 | |||
| 52 | if ($compressedSize >= MAX_INT_32) { |
||
| 53 | $dataSize += 8; |
||
| 54 | $encoded .= \pack('P', $compressedSize); |
||
| 55 | $legacyCompressedSize = MAX_INT_32; |
||
| 56 | $parameterCompressedSize = $compressedSize; |
||
| 57 | } else { |
||
| 58 | $legacyCompressedSize = $compressedSize; |
||
| 59 | $parameterCompressedSize = null; |
||
| 60 | } |
||
| 61 | |||
| 62 | if ($relativeHeaderOffset >= MAX_INT_32) { |
||
| 63 | $dataSize += 8; |
||
| 64 | $encoded .= \pack('P', $relativeHeaderOffset); |
||
| 65 | $legacyRelativeHeaderOffset = MAX_INT_32; |
||
| 66 | $parameterRelativeHeaderOffset = $relativeHeaderOffset; |
||
| 67 | } else { |
||
| 68 | $legacyRelativeHeaderOffset = $relativeHeaderOffset; |
||
| 69 | $parameterRelativeHeaderOffset = null; |
||
| 70 | } |
||
| 71 | |||
| 72 | if ($diskNumber >= MAX_INT_16) { |
||
| 73 | $dataSize += 4; |
||
| 74 | $encoded .= \pack('V', $diskNumber); |
||
| 75 | $legacyDiskNumber = MAX_INT_16; |
||
| 76 | $parameterDiskNumber = $diskNumber; |
||
| 77 | } else { |
||
| 78 | $legacyDiskNumber = $diskNumber; |
||
| 79 | $parameterDiskNumber = null; |
||
| 80 | } |
||
| 81 | |||
| 82 | $encoded = \pack('vv', Zip64ExtendedInformation::ID, $dataSize) . $encoded; |
||
| 83 | |||
| 84 | $data[$name] = [ |
||
| 85 | $parameterOriginalSize, |
||
| 86 | $parameterCompressedSize, |
||
| 87 | $parameterRelativeHeaderOffset, |
||
| 88 | $parameterDiskNumber, |
||
| 89 | new CentralDirectoryHeader( |
||
| 90 | 0, |
||
| 91 | 0, |
||
| 92 | 0, |
||
| 93 | 0, |
||
| 94 | 0, |
||
| 95 | 0, |
||
| 96 | 0, |
||
| 97 | $legacyCompressedSize, |
||
| 98 | $legacyOriginalSize, |
||
| 99 | $legacyDiskNumber, |
||
| 100 | 0, |
||
| 101 | 0, |
||
| 102 | $legacyRelativeHeaderOffset |
||
| 103 | ), |
||
| 104 | $encoded |
||
| 105 | ]; |
||
| 106 | } |
||
| 107 | } |
||
| 108 | } |
||
| 109 | } |
||
| 110 | return $data; |
||
| 111 | } |
||
| 112 | |||
| 181 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.