morgue\zip\FunctionsTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testDos2DateTime()	0	6	2
A	testDateTime2Dos()	0	14	3

<?php

namespace morgue\zip;

use PHPUnit\Framework\TestCase;

class FunctionsTest extends TestCase
{
    private $cases = [
        [0, 0, "1979-11-30 00:00:00", "1979-11-30 00:00:01"],
        [1, 0, "1979-11-30 00:00:02", "1979-11-30 00:00:03"],
        [0, 33, "1980-01-01 00:00:00"],
        [43507, 19583, "2018-03-31 21:15:38"],
    ];


    /**
     * @throws \Exception
     */
    public function testDos2DateTime()
    {
        foreach ($this->cases as list($dosTime, $dosDate, $datetime)) {
            $this->assertEquals(new \DateTimeImmutable($datetime), dos2DateTime($dosTime, $dosDate));
        }
    }

    /**
     * @throws \Exception
     */
    public function testDateTime2Dos()
    {
        foreach ($this->cases as $caseIndex => list($dosTime, $dosDate)) {
            for ($i=2; $i<\count($this->cases[$caseIndex]); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $datetime = $this->cases[$caseIndex][$i];
                $this->assertEquals(DateTime2dos(new \DateTimeImmutable($datetime)), [
                    $dosTime,
                    $dosDate,
                    'time' => $dosTime,
                    'date' => $dosDate,
                ], $datetime);
            }
        }
    }
}