Phone::getControlPart() - Code Metrics - Inspection of "Updated scrutinizer settings" - ipublikuj-ui/form-phone - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( e01736...ba6a43 )

by Adam
created 2015-12-21 00:04 UTC
Phone::getControlPart() C

↳ Parent: Phone
Complexity

Conditions	9
Paths	10
Size

Total Lines	67
Code Lines	41
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	37
CRAP Score	9.3262
Importance

Changes	2
Bugs	1	Features	0
Metric	Value
c	2
b	1
f	0
dl	0
loc	67
ccs	37
cts	44
cp	0.8409
rs	6.3449
cc	9
eloc	41
nc	10
nop	1
crap	9.3262
How to fix Long Method

<?php
/**
 * Phone.php
 *
 * @copyright      More in license.md
 * @license        http://www.ipublikuj.eu
 * @author         Adam Kadlec <[email protected]>
 * @package        iPublikuj:FormPhone!
 * @subpackage     Controls
 * @since          1.0.0
 *
 * @date           15.12.15
 */

namespace IPub\FormPhone\Controls;

use Nette;
use Nette\Application\UI;
use Nette\Bridges;
use Nette\Forms;
use Nette\Localization;
use Nette\Utils;

use Latte;

use IPub;
use IPub\FormPhone;
use IPub\FormPhone\Exceptions;

use IPub\Phone\Phone as PhoneUtils;

use libphonenumber;
use libphonenumber\geocoding;

/**
 * Form phone control element
 *
 * @package        iPublikuj:FormPhone!
 * @subpackage     Controls
 *
 * @author         Adam Kadlec <[email protected]>
 */
class Phone extends Forms\Controls\TextInput
{
	/**
	 * Define filed attributes
	 */
	const FIELD_COUNTRY = 'country';
	const FIELD_NUMBER = 'number';

	/**
	 * @var IPub\Phone\Phone
	 */
	private $phoneUtils;

	/**
	 * List of allowed countries
	 *
	 * @var array
	 */
	private $allowedCountries = [];

	/**
	 * List of allowed phone types
	 *
	 * @var array
	 */
	private $allowedTypes = [];

	/**
	 * @var string
	 */
	private $number;

	/**
	 * @var string
	 */
	private $country;

	/**
	 * @var string
	 */
	private $defaultCountry;

	/**
	 * @var bool
	 */
	private static $registered = FALSE;

	/**
	 * @param PhoneUtils $phoneUtils
	 * @param string|NULL $label
	 * @param int|NULL $maxLength
	 */
	public function __construct(PhoneUtils $phoneUtils, $label = NULL, $maxLength = NULL)
	{
		parent::__construct($label, $maxLength);

		$this->phoneUtils = $phoneUtils;
	}

	/**
	 * @param array $countries
	 *
	 * @return $this
	 *
	 * @throws Exceptions\NoValidCountryException
	 */
	public function setCountries(array $countries = [])
	{
		$this->allowedCountries = [];

		foreach($countries as $country)
		{
			$country = $this->validateCountry($country);
			$this->allowedCountries[] = strtoupper($country);
		}

		// Check for auto country detection
		if (in_array('AUTO', $this->allowedCountries)) {
			$this->allowedCountries = ['AUTO'];
		}

		// Remove duplicities
		array_unique($this->allowedCountries);

		return $this;
	}

	/**
	 * @param string $country
	 *
	 * @return $this
	 *
	 * @throws Exceptions\NoValidCountryException
	 */
	public function addCountry($country)
	{
		$country = $this->validateCountry($country);
		$this->allowedCountries[] = strtoupper($country);

		// Remove duplicities
		array_unique($this->allowedCountries);

		if (strtoupper($country) === 'AUTO') {
			$this->allowedCountries = ['AUTO'];

		} else if ($key = array_search('AUTO', $this->allowedCountries) AND $key !== FALSE) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
			unset($this->allowedCountries[$key]);
		}

		return $this;
	}

	/**
	 * @return array
	 */
	public function getCountries()
	{
		if (in_array('AUTO', $this->allowedCountries, TRUE) || $this->allowedCountries === []) {
			return $this->phoneUtils->getSupportedCountries();

		} else {
			return $this->allowedCountries;
		}
	}

	/**
	 * @param string|NULL $country
	 *
	 * @return $this
	 *
	 * @throws Exceptions\NoValidCountryException
	 */
	public function setDefaultCountry($country = NULL)
	{
		if ($country === NULL) {
			$this->defaultCountry = NULL;

		} else {
			$country = $this->validateCountry($country);

			$this->defaultCountry = strtoupper($country);
		}

		return $this;
	}

	/**
	 * @param array $types
	 *
	 * @return $this
	 *
	 * @throws Exceptions\NoValidTypeException
	 */
	public function setPhoneTypes(array $types = [])
	{
		$this->allowedTypes = [];

		foreach($types as $type)
		{
			$type = $this->validateType($type);
			$this->allowedTypes[] = strtoupper($type);
		}

		// Remove duplicities
		array_unique($this->allowedTypes);

		return $this;
	}

	/**
	 * @param string $type
	 *
	 * @return $this
	 *
	 * @throws Exceptions\NoValidTypeException
	 */
	public function addPhoneType($type)
	{
		$type = $this->validateType($type);
		$this->allowedTypes[] = strtoupper($type);

		// Remove duplicities
		array_unique($this->allowedTypes);

		return $this;
	}

	/**
	 * @return array
	 */
	public function getPhoneTypes()
	{
		return $this->allowedTypes;
	}

	/**
	 * @param string
	 *
	 * @return $this
	 *
	 * @throws Exceptions\InvalidArgumentException
	 */
	public function setValue($value)
	{
		if ($value === NULL) {
			$this->country = NULL;
			$this->number = NULL;

			return $this;
		}

		foreach($this->getCountries() as $country) {
			if ($this->phoneUtils->isValid($value, $country)) {
				$phone = $this->phoneUtils->parse($value, $country);

				$this->country = $phone->getCountry();
				$this->number = $phone->getNationalNumber();

				return $this;
			}
		}

		throw new Exceptions\InvalidArgumentException('Provided value is not valid phone number, or is out of list of allowed countries, "' . $value . '" given.');
	}

	/**
	 * @return string|NULL
	 */
	public function getValue()
	{
		if ($this->country === NULL || $this->number === NULL) {
			return NULL;
		}

		try {
			if (!$this->phoneUtils->isValid($this->number, $this->country)) {
				return NULL;
			}

		} catch (IPub\Phone\Exceptions\NoValidCountryException $ex) {
			return NULL;
		}

		return $this->phoneUtils->format($this->number, $this->country, PhoneUtils::FORMAT_E164);
	}

	/**
	 * Loads HTTP data
	 *
	 * @return void
	 */
	public function loadHttpData()
	{
		$this->country = $this->getHttpData(Forms\Form::DATA_LINE, '[' . static::FIELD_COUNTRY . ']');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		$this->number = $this->getHttpData(Forms\Form::DATA_LINE, '[' . static::FIELD_NUMBER . ']');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
	}

	/**
	 * @return string
	 */
	public function getControl()
	{
		return $this->getControlPart(static::FIELD_COUNTRY) . $this->getControlPart(static::FIELD_NUMBER);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

	/**
	 * @param string
	 *
	 * @return Utils\Html
	 *
	 * @throws Exceptions\InvalidArgumentException
	 */
	public function getControlPart($key)
	{
		$name = $this->getHtmlName();

		if ($translator = $this->getTranslator() AND $translator instanceof Localization\ITranslator AND method_exists($translator, 'getLocale')) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
			$locale = $translator->getLocale();

		} else {
			$locale = 'en_US';
		}

		if ($key === static::FIELD_COUNTRY) {
			$control = Forms\Helpers::createSelectBox(
				array_reduce($this->getCountries(), function (array $result, $row) use ($locale) {
					$countryName = geocoding\Locale::getDisplayRegion(
						geocoding\Locale::countryCodeToLocale($row),
						$locale
					);

					$result[$row] = Utils\Html::el('option')
						->setText('+' . $this->phoneUtils->getCountryCodeForCountry($row) . ' ('. $countryName . ')')
						->addAttributes([
							'data-mask' => preg_replace('/[0-9]/', '9', $this->phoneUtils->getExampleNationalNumber($row)),
						])
						->value($row);

					return $result;
				}, []),
				[
					'selected?' => $this->country === NULL ? $this->defaultCountry : $this->country,
				]
			);

			$control
				->name($name . '[' . static::FIELD_COUNTRY . ']')
				->id($this->getHtmlId() . '-' . static::FIELD_COUNTRY)
				->{'data-ipub-forms-phone'}('')
				->{'data-settings'}(json_encode([
					'field' => $name . '[' . static::FIELD_NUMBER . ']'
				]));

			if ($this->isDisabled()) {
				$control->disabled(TRUE);
			}

			return $control;

		} else if ($key === static::FIELD_NUMBER) {
			$input = parent::getControl();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

			$control = Utils\Html::el('input');

			$control
				->name($name . '[' . static::FIELD_NUMBER . ']')
				->id($this->getHtmlId() . '-' . static::FIELD_NUMBER)
				->value($this->number)
				->type('text')
				->{'data-nette-rules'}($input->attrs['data-nette-rules']);

			if ($this->isDisabled()) {
				$control->disabled(TRUE);
			}

			return $control;
		}

		throw new Exceptions\InvalidArgumentException('Part ' . $key . ' does not exist.');
	}

	/**
	 * @return NULL
	 */
	public function getLabelPart()
	{
		return NULL;
	}

	/**
	 * @param string $country
	 *
	 * @return string
	 *
	 * @throws Exceptions\NoValidCountryException
	 */
	protected function validateCountry($country)
	{
		// Country code have to be upper-cased
		$country = strtoupper($country);

		if ((strlen($country) === 2 && ctype_alpha($country) && ctype_upper($country) && in_array($country, $this->phoneUtils->getSupportedCountries())) || $country === 'AUTO') {
			return $country;

		} else {
			throw new Exceptions\NoValidCountryException('Provided country code "' . $country . '" is not valid. Provide valid country code or AUTO for automatic detection.');
		}
	}

	/**
	 * @param string $type
	 *
	 * @return string
	 *
	 * @throws Exceptions\NoValidTypeException
	 */
	protected function validateType($type)
	{
		// Phone type have to be upper-cased
		$type = strtoupper($type);

		if (defined('\IPub\Phone\Phone::TYPE_' . $type)) {
			return $type;

		} else {
			throw new Exceptions\NoValidTypeException('Provided phone type "' . $type . '" is not valid. Provide valid phone type.');
		}
	}

	/**
	 * @param PhoneUtils $phoneUtils
	 * @param string $method
	 */
	public static function register(PhoneUtils $phoneUtils, $method = 'addPhone')
	{
		// Check for multiple registration
		if (static::$registered) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
			throw new Nette\InvalidStateException('Phone control already registered.');
		}

		static::$registered = TRUE;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}

		$class = function_exists('get_called_class') ? get_called_class() : __CLASS__;
		Forms\Container::extensionMethod(
			$method, function (Forms\Container $form, $name, $label = NULL, $maxLength = NULL) use ($class, $phoneUtils) {
			$component = new $class($phoneUtils, $label, $maxLength);
			$form->addComponent($component, $name);

			return $component;
		}
		);
	}
}

Push — master ( e01736...ba6a43 )

Phone::getControlPart() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

ipublikuj-ui / form-phone

Push — master ( e01736...ba6a43 )

Phone::getControlPart() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like
