DnsDockResolver::stripSlashFromImageName() - Code Metrics - Inspection of "Merge pull request #115 from wodor/feature/strip_s..." - inviqa/dock-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9c5afe...e73e2f )

by Samuel

created 2016-05-24 23:37 UTC

DnsDockResolver::stripSlashFromImageName() A

↳ Parent: DnsDockResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	8
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Dock\Docker\Dns;

class DnsDockResolver implements ContainerAddressResolver
{
    /**
     * {@inheritdoc}
     */
    public function getDnsByContainerNameAndImage($containerName, $imageName)
    {
        $imageName = $this->stripTagNameFromImageName($imageName);
        $imageName = $this->stripSlashFromImageName($imageName);

        return [
            $imageName.'.docker',
            $containerName.'.'.$imageName.'.docker',
        ];
    }

    /**
     * @param string $imageName
     *
     * @return string
     */
    private function stripTagNameFromImageName($imageName)

    {
        if (false !== ($position = strpos($imageName, ':'))) {
            $imageName = substr($imageName, 0, $position);
        }

        return $imageName;
    }
    
    private function stripSlashFromImageName($imageName)

    {
        if (false !== ($position = strpos($imageName, '/'))) {
            $imageName = substr($imageName, $position+1 );
        }

        return $imageName;
    }
}


1		<?php
2
3		namespace Dock\Docker\Dns;
4
5		class DnsDockResolver implements ContainerAddressResolver
6		{
7		/**
8		* {@inheritdoc}
9		*/
10		public function getDnsByContainerNameAndImage($containerName, $imageName)
11		{
12		$imageName = $this->stripTagNameFromImageName($imageName);
13		$imageName = $this->stripSlashFromImageName($imageName);
14
15		return [
16		$imageName.'.docker',
17		$containerName.'.'.$imageName.'.docker',
18		];
19		}
20
21		/**
22		* @param string $imageName
23		*
24		* @return string
25		*/
26	View Code Duplication	private function stripTagNameFromImageName($imageName)
		0 ignored issues – show Duplication introduced 2016-05-24 16:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		if (false !== ($position = strpos($imageName, ':'))) {
29		$imageName = substr($imageName, 0, $position);
30		}
31
32		return $imageName;
33		}
34
35	View Code Duplication	private function stripSlashFromImageName($imageName)
		0 ignored issues – show Duplication introduced 2016-05-24 16:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		if (false !== ($position = strpos($imageName, '/'))) {
38		$imageName = substr($imageName, $position+1 );
39		}
40
41		return $imageName;
42		}
43		}
44

inviqa / dock-cli

Push — master ( 9c5afe...e73e2f )

DnsDockResolver::stripSlashFromImageName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like