DnsDock::hasDockerOptions() - Code Metrics - Inspection of "Add method to check for current docker0 IP" - inviqa/dock-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#108)

by Marek

created 2016-02-06 14:39 UTC

DnsDock::hasDockerOptions() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Dock\Installer\DNS\Linux;

use Dock\Installer\InstallerTask;
use Dock\IO\ProcessRunner;
use Dock\IO\UserInteraction;
use SRIO\ChainOfResponsibility\DependentChainProcessInterface;

class DnsDock extends InstallerTask implements DependentChainProcessInterface
{
    const IP = '172.17.42.1';

    /**
     * @var ProcessRunner
     */
    private $processRunner;
    /**
     * @var UserInteraction
     */
    private $userInteraction;

    /**
     * @param UserInteraction $userInteraction
     * @param ProcessRunner   $processRunner
     */
    public function __construct(UserInteraction $userInteraction, ProcessRunner $processRunner)
    {
        $this->userInteraction = $userInteraction;
        $this->processRunner = $processRunner;
    }

    /**
     * {@inheritdoc}
     */
    public function dependsOn()
    {
        return ['docker'];
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'dns';
    }

    public function run()
    {
        $ip = $this->getDockerIp();

        $this->processRunner->run('sudo docker start dnsdock || sudo docker run -d -v /var/run/docker.sock:/var/run/docker.sock --name dnsdock -p '.$ip.':53:53/udp tonistiigi/dnsdock');
    }

    private function getDockerIp()

    {
        $output = $this->processRunner->run("ip addr show docker0 | grep 'inet ' | awk -F\\  '{print $2}' | awk '{print $1}'");
        $network = explode('/', trim($output));

        return $network[0];
    }
}


1		<?php
2
3		namespace Dock\Installer\DNS\Linux;
4
5		use Dock\Installer\InstallerTask;
6		use Dock\IO\ProcessRunner;
7		use Dock\IO\UserInteraction;
8		use SRIO\ChainOfResponsibility\DependentChainProcessInterface;
9
10		class DnsDock extends InstallerTask implements DependentChainProcessInterface
11		{
12		const IP = '172.17.42.1';
13
14		/**
15		* @var ProcessRunner
16		*/
17		private $processRunner;
18		/**
19		* @var UserInteraction
20		*/
21		private $userInteraction;
22
23		/**
24		* @param UserInteraction $userInteraction
25		* @param ProcessRunner $processRunner
26		*/
27		public function __construct(UserInteraction $userInteraction, ProcessRunner $processRunner)
28		{
29		$this->userInteraction = $userInteraction;
30		$this->processRunner = $processRunner;
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36		public function dependsOn()
37		{
38		return ['docker'];
39		}
40
41		/**
42		* {@inheritdoc}
43		*/
44		public function getName()
45		{
46		return 'dns';
47		}
48
49		public function run()
50		{
51		$ip = $this->getDockerIp();
52
53		$this->processRunner->run('sudo docker start dnsdock \|\| sudo docker run -d -v /var/run/docker.sock:/var/run/docker.sock --name dnsdock -p '.$ip.':53:53/udp tonistiigi/dnsdock');
54		}
55
56	View Code Duplication	private function getDockerIp()
		0 ignored issues – show Duplication introduced 2016-02-06 14:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$output = $this->processRunner->run("ip addr show docker0 \| grep 'inet ' \| awk -F\\ '{print $2}' \| awk '{print $1}'");
59		$network = explode('/', trim($output));
60
61		return $network[0];
62		}
63		}
64

inviqa / dock-cli

Pull Request — master (#108)

DnsDock::hasDockerOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like