Inspection of "Add support for loading php config files" - intraxia/jaxion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e26cf8...177698 )

by James

created 2019-11-18 03:05 UTC

Status

Indentation +128 added lines, -128 removed lines patch added patch discarded remove patch

@@ -11,132 +11,132 @@
 block discarded – undo
  * @subpackage Core
  */
 class Config {
-	/**
-	 * Configuration type.
-	 *
-	 * @var ConfigType
-	 */
-	public $type;
-
-	/**
-	 * App entry file.
-	 *
-	 * @var string
-	 */
-	public $file;
-
-	/**
-	 * App url.
-	 *
-	 * @var string
-	 */
-	public $url;
-
-	/**
-	 * App path.
-	 *
-	 * @var string
-	 */
-	public $path;
-
-	/**
-	 * App slug.
-	 *
-	 * @var string
-	 */
-	public $slug;
-
-	/**
-	 * App basename.
-	 *
-	 * @var string
-	 */
-	public $basename;
-
-	/**
-	 * Loaded JSON configuration files.
-	 *
-	 * @var array
-	 */
-	private $json = array();
-
-	/**
-	 * Loaded PHP configuration files.
-	 *
-	 * @var array
-	 */
-	private $php = array();
-
-	/**
-	 * Config constructor.
-	 *
-	 * @param string $type
-	 * @param string $file
-	 */
-	public function __construct( $type, $file ) {
-		$this->type = new ConfigType( $type );
-		$this->file = $file;
-
-		switch ( $this->type->getValue() ) {
-			case ConfigType::PLUGIN:
-			case ConfigType::MU_PLUGIN:
-				$this->url = plugin_dir_url( $file );
-				$this->path = plugin_dir_path( $file );
-				$this->slug = dirname( $this->basename = plugin_basename( $file ) );
-				break;
-			case ConfigType::THEME:
-				$this->url = get_stylesheet_directory_uri() . '/';
-				$this->path = get_stylesheet_directory() . '/';
-				$this->slug = dirname( $this->basename = plugin_basename( $file ) );
-				break;
-		}
-	}
-
-	/**
-	 * Load a configuration JSON file from the config folder.
-	 *
-	 * @param string $filename
-	 *
-	 * @return array|null
-	 */
-	public function get_config_json( $filename ) {
-		if ( isset( $this->json[ $filename ] ) ) {
-			return $this->json[ $filename ];
-		}
-
-		$path = $this->path . 'config/' . $filename . '.json';
-
-		if ( ! file_exists( $path ) ) {
-			return null;
-		}
-
-		$contents = file_get_contents( $path );
-
-		if ( false === $contents ) {
-			return null;
-		}
-
-		return $this->json[ $filename ] = json_decode( $contents, true );
-	}
-
-	/**
-	 * Load a configuration PHP file from the config folder.
-	 *
-	 * @param string $filename
-	 *
-	 * @return array|null
-	 */
-	public function get_config_php( $filename ) {
-		if ( isset( $this->php[ $filename ] ) ) {
-			return $this->php[ $filename ];
-		}
-
-		$path = $this->path . 'config/' . $filename . '.php';
-
-		if ( ! file_exists( $path ) ) {
-			return null;
-		}
-
-		return $this->php[ $filename ] = require $path;
-	}
+    /**
+     * Configuration type.
+     *
+     * @var ConfigType
+     */
+    public $type;
+
+    /**
+     * App entry file.
+     *
+     * @var string
+     */
+    public $file;
+
+    /**
+     * App url.
+     *
+     * @var string
+     */
+    public $url;
+
+    /**
+     * App path.
+     *
+     * @var string
+     */
+    public $path;
+
+    /**
+     * App slug.
+     *
+     * @var string
+     */
+    public $slug;
+
+    /**
+     * App basename.
+     *
+     * @var string
+     */
+    public $basename;
+
+    /**
+     * Loaded JSON configuration files.
+     *
+     * @var array
+     */
+    private $json = array();
+
+    /**
+     * Loaded PHP configuration files.
+     *
+     * @var array
+     */
+    private $php = array();
+
+    /**
+     * Config constructor.
+     *
+     * @param string $type
+     * @param string $file
+     */
+    public function __construct( $type, $file ) {
+        $this->type = new ConfigType( $type );
+        $this->file = $file;
+
+        switch ( $this->type->getValue() ) {
+            case ConfigType::PLUGIN:
+            case ConfigType::MU_PLUGIN:
+                $this->url = plugin_dir_url( $file );
+                $this->path = plugin_dir_path( $file );
+                $this->slug = dirname( $this->basename = plugin_basename( $file ) );
+                break;
+            case ConfigType::THEME:
+                $this->url = get_stylesheet_directory_uri() . '/';
+                $this->path = get_stylesheet_directory() . '/';
+                $this->slug = dirname( $this->basename = plugin_basename( $file ) );
+                break;
+        }
+    }
+
+    /**
+     * Load a configuration JSON file from the config folder.
+     *
+     * @param string $filename
+     *
+     * @return array|null
+     */
+    public function get_config_json( $filename ) {
+        if ( isset( $this->json[ $filename ] ) ) {
+            return $this->json[ $filename ];
+        }
+
+        $path = $this->path . 'config/' . $filename . '.json';
+
+        if ( ! file_exists( $path ) ) {
+            return null;
+        }
+
+        $contents = file_get_contents( $path );
+
+        if ( false === $contents ) {
+            return null;
+        }
+
+        return $this->json[ $filename ] = json_decode( $contents, true );
+    }
+
+    /**
+     * Load a configuration PHP file from the config folder.
+     *
+     * @param string $filename
+     *
+     * @return array|null
+     */
+    public function get_config_php( $filename ) {
+        if ( isset( $this->php[ $filename ] ) ) {
+            return $this->php[ $filename ];
+        }
+
+        $path = $this->path . 'config/' . $filename . '.php';
+
+        if ( ! file_exists( $path ) ) {
+            return null;
+        }
+
+        return $this->php[ $filename ] = require $path;
+    }
 }

Please login to merge, or discard this patch.

		@@ -11,132 +11,132 @@
		block discarded – undo
11	11	* @subpackage Core
12	12	*/
13	13	class Config {
14		- /**
15		- * Configuration type.
16		- *
17		- * @var ConfigType
18		- */
19		- public $type;
20		-
21		- /**
22		- * App entry file.
23		- *
24		- * @var string
25		- */
26		- public $file;
27		-
28		- /**
29		- * App url.
30		- *
31		- * @var string
32		- */
33		- public $url;
34		-
35		- /**
36		- * App path.
37		- *
38		- * @var string
39		- */
40		- public $path;
41		-
42		- /**
43		- * App slug.
44		- *
45		- * @var string
46		- */
47		- public $slug;
48		-
49		- /**
50		- * App basename.
51		- *
52		- * @var string
53		- */
54		- public $basename;
55		-
56		- /**
57		- * Loaded JSON configuration files.
58		- *
59		- * @var array
60		- */
61		- private $json = array();
62		-
63		- /**
64		- * Loaded PHP configuration files.
65		- *
66		- * @var array
67		- */
68		- private $php = array();
69		-
70		- /**
71		- * Config constructor.
72		- *
73		- * @param string $type
74		- * @param string $file
75		- */
76		- public function __construct( $type, $file ) {
77		- $this->type = new ConfigType( $type );
78		- $this->file = $file;
79		-
80		- switch ( $this->type->getValue() ) {
81		- case ConfigType::PLUGIN:
82		- case ConfigType::MU_PLUGIN:
83		- $this->url = plugin_dir_url( $file );
84		- $this->path = plugin_dir_path( $file );
85		- $this->slug = dirname( $this->basename = plugin_basename( $file ) );
86		- break;
87		- case ConfigType::THEME:
88		- $this->url = get_stylesheet_directory_uri() . '/';
89		- $this->path = get_stylesheet_directory() . '/';
90		- $this->slug = dirname( $this->basename = plugin_basename( $file ) );
91		- break;
92		- }
93		- }
94		-
95		- /**
96		- * Load a configuration JSON file from the config folder.
97		- *
98		- * @param string $filename
99		- *
100		- * @return array\|null
101		- */
102		- public function get_config_json( $filename ) {
103		- if ( isset( $this->json[ $filename ] ) ) {
104		- return $this->json[ $filename ];
105		- }
106		-
107		- $path = $this->path . 'config/' . $filename . '.json';
108		-
109		- if ( ! file_exists( $path ) ) {
110		- return null;
111		- }
112		-
113		- $contents = file_get_contents( $path );
114		-
115		- if ( false === $contents ) {
116		- return null;
117		- }
118		-
119		- return $this->json[ $filename ] = json_decode( $contents, true );
120		- }
121		-
122		- /**
123		- * Load a configuration PHP file from the config folder.
124		- *
125		- * @param string $filename
126		- *
127		- * @return array\|null
128		- */
129		- public function get_config_php( $filename ) {
130		- if ( isset( $this->php[ $filename ] ) ) {
131		- return $this->php[ $filename ];
132		- }
133		-
134		- $path = $this->path . 'config/' . $filename . '.php';
135		-
136		- if ( ! file_exists( $path ) ) {
137		- return null;
138		- }
139		-
140		- return $this->php[ $filename ] = require $path;
141		- }
	14	+ /**
	15	+ * Configuration type.
	16	+ *
	17	+ * @var ConfigType
	18	+ */
	19	+ public $type;
	20	+
	21	+ /**
	22	+ * App entry file.
	23	+ *
	24	+ * @var string
	25	+ */
	26	+ public $file;
	27	+
	28	+ /**
	29	+ * App url.
	30	+ *
	31	+ * @var string
	32	+ */
	33	+ public $url;
	34	+
	35	+ /**
	36	+ * App path.
	37	+ *
	38	+ * @var string
	39	+ */
	40	+ public $path;
	41	+
	42	+ /**
	43	+ * App slug.
	44	+ *
	45	+ * @var string
	46	+ */
	47	+ public $slug;
	48	+
	49	+ /**
	50	+ * App basename.
	51	+ *
	52	+ * @var string
	53	+ */
	54	+ public $basename;
	55	+
	56	+ /**
	57	+ * Loaded JSON configuration files.
	58	+ *
	59	+ * @var array
	60	+ */
	61	+ private $json = array();
	62	+
	63	+ /**
	64	+ * Loaded PHP configuration files.
	65	+ *
	66	+ * @var array
	67	+ */
	68	+ private $php = array();
	69	+
	70	+ /**
	71	+ * Config constructor.
	72	+ *
	73	+ * @param string $type
	74	+ * @param string $file
	75	+ */
	76	+ public function __construct( $type, $file ) {
	77	+ $this->type = new ConfigType( $type );
	78	+ $this->file = $file;
	79	+
	80	+ switch ( $this->type->getValue() ) {
	81	+ case ConfigType::PLUGIN:
	82	+ case ConfigType::MU_PLUGIN:
	83	+ $this->url = plugin_dir_url( $file );
	84	+ $this->path = plugin_dir_path( $file );
	85	+ $this->slug = dirname( $this->basename = plugin_basename( $file ) );
	86	+ break;
	87	+ case ConfigType::THEME:
	88	+ $this->url = get_stylesheet_directory_uri() . '/';
	89	+ $this->path = get_stylesheet_directory() . '/';
	90	+ $this->slug = dirname( $this->basename = plugin_basename( $file ) );
	91	+ break;
	92	+ }
	93	+ }
	94	+
	95	+ /**
	96	+ * Load a configuration JSON file from the config folder.
	97	+ *
	98	+ * @param string $filename
	99	+ *
	100	+ * @return array\|null
	101	+ */
	102	+ public function get_config_json( $filename ) {
	103	+ if ( isset( $this->json[ $filename ] ) ) {
	104	+ return $this->json[ $filename ];
	105	+ }
	106	+
	107	+ $path = $this->path . 'config/' . $filename . '.json';
	108	+
	109	+ if ( ! file_exists( $path ) ) {
	110	+ return null;
	111	+ }
	112	+
	113	+ $contents = file_get_contents( $path );
	114	+
	115	+ if ( false === $contents ) {
	116	+ return null;
	117	+ }
	118	+
	119	+ return $this->json[ $filename ] = json_decode( $contents, true );
	120	+ }
	121	+
	122	+ /**
	123	+ * Load a configuration PHP file from the config folder.
	124	+ *
	125	+ * @param string $filename
	126	+ *
	127	+ * @return array\|null
	128	+ */
	129	+ public function get_config_php( $filename ) {
	130	+ if ( isset( $this->php[ $filename ] ) ) {
	131	+ return $this->php[ $filename ];
	132	+ }
	133	+
	134	+ $path = $this->path . 'config/' . $filename . '.php';
	135	+
	136	+ if ( ! file_exists( $path ) ) {
	137	+ return null;
	138	+ }
	139	+
	140	+ return $this->php[ $filename ] = require $path;
	141	+ }
142	142	}

intraxia / jaxion

Push — master ( e26cf8...177698 )

Status

Category

Indentation +128 added lines, -128 removed lines patch added patch discarded remove patch