Intraxia\Jaxion\Core\HooksReader

Complexity

Total Complexity

8

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	reader()	0	3	1
A	instance()	0	9	2
A	read()	0	21	4

<?php
namespace Intraxia\Jaxion\Core;

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\AnnotationRegistry;
use ReflectionClass;

/**
 * HooksReader class.
 */
class HooksReader {

	/**
	 * Construct a new HooksReader instance.
	 */
	private function __construct() {
		$this->reader = new AnnotationReader();

The property reader does not exist. Did you maybe forget to declare it?

		AnnotationRegistry::registerFile(

The method Doctrine\Common\Annotations\AnnotationRegistry::registerFile() has been deprecated with message: this method is deprecated and will be removed in doctrine/annotations 2.0 autoloading should be deferred to the globally registered autoloader by then. For now, use @example AnnotationRegistry::registerLoader('class_exists')

			__DIR__ . '/Annotations.php'
		);
	}

	/**
	 * Get the Annotation reader.
	 *
	 * @return AnnotationReader
	 */
	private function reader() {
		return $this->reader;
	}

	/**
	 * Get the shared reader instance.
	 *
	 * @return HooksReader
	 */
	static private function instance() {
		static $instance;

		if ( ! $instance ) {
			$instance = new HooksReader();
		}

		return $instance;
	}

	/**
	 * Shared implementation of hook reading logic.
	 *
	 * @param  object   $target    Object to read annotations from.
	 * @param  \Closure $condition Whether the annotation should be registered.
	 * @return array
	 */
	static public function read( $target, $condition ) {
		$reader = static::instance()->reader();

Since instance() is declared private, calling it with static will lead to errors in possible sub-classes. You can either use self, or increase the visibility of instance() to at least protected.

		$rmethods = (new ReflectionClass( $target ))->getMethods();

		$hooks = [];

		foreach ( $rmethods as $rmethod ) {
			foreach ( $reader->getMethodAnnotations( $rmethod ) as $annotation ) {
				if ( $condition( $annotation ) ) {
					$hooks[] = [
						'hook' => $annotation->hook,
						'method' => $rmethod->getName(),

Consider using $rmethod->name. There is an issue with getName() and APC-enabled PHP versions.

						'priority' => $annotation->priority,
						'args' => $annotation->args,
					];
				}
			}
		}

		return $hooks;
	}
}