Issues in YearTest.php (master) - Issues in master - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4714)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/unit/Accounting/YearTest.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
require_once 'Intraface/modules/accounting/Year.php';
require_once 'Intraface/functions.php';

class YearTest extends PHPUnit_Framework_TestCase
{
    function setUp()
    {
        $this->kernel = new Stub_Kernel();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->kernel->setting->set('intranet', 'vatpercent', 25);
        $this->kernel->setting->set('user', 'accounting.active_year', 0);
        $this->kernel->setting->set('intranet', 'accounting.result_account_id', 25);
        $this->kernel->setting->set('intranet', 'accounting.debtor_account_id', 25);
        $this->kernel->setting->set('intranet', 'accounting.credit_account_id', 25);
        $this->kernel->setting->set('intranet', 'accounting.balance_accounts', serialize(array()));
        $this->kernel->setting->set('intranet', 'accounting.result_account_id_start', 0);
        $this->kernel->setting->set('intranet', 'accounting.result_account_id_end', 0);
        $this->kernel->setting->set('intranet', 'accounting.balance_account_id_start', 0);
        $this->kernel->setting->set('intranet', 'accounting.balance_account_id_end', 0);
        $this->kernel->setting->set('intranet', 'accounting.capital_account_id', 0);

        $this->kernel->setting->set('intranet', 'accounting.vat_in_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.vat_out_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.vat_abroad_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.vat_balance_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.vat_free_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.eu_sale_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.result_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.debtor_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.credit_account_id', 0);
        $this->kernel->setting->set('intranet', 'accounting.balance_accounts', serialize(array()));
        $this->kernel->setting->set('intranet', 'accounting.buy_eu_accounts', serialize(array()));
        $this->kernel->setting->set('intranet', 'accounting.buy_abroad_accounts', serialize(array()));

        $this->kernel->setting->set('intranet', 'accounting.result_account_id_start', 0);
        $this->kernel->setting->set('intranet', 'accounting.result_account_id_end', 0);
        $this->kernel->setting->set('intranet', 'accounting.balance_account_id_start', 0);
        $this->kernel->setting->set('intranet', 'accounting.balance_account_id_end', 0);

        $this->kernel->setting->set('intranet', 'accounting.capital_account_id', 0);
    }

    function tearDown()
    {
        $db = MDB2::singleton(DB_DSN);
        $db->exec('TRUNCATE accounting_year');
    }

    function testSetYearReturnsFalseWhenYearObjectIsNotSet()
    {
        $year = new Year($this->kernel);
        $this->assertFalse($year->setYear());
    }

    function testSetYearReturnsTrueWhenYearObjectIsSet()

    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertTrue($id > 0);
        $this->assertTrue($year->setYear());
        $this->assertEquals($id, $year->getActiveYear());
    }

    function testCheckYearReturnsTrueIfActiveYearIsset()

    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertTrue($id > 0);
        $this->assertTrue($year->setYear());
        $this->assertTrue($year->checkYear());
    }

    function testCheckYearReturnsFalseIfActiveYearIsNotset()
    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->assertFalse($year->checkYear(false));
    }

    function testIsYearSetReturnsTrueWhenYearIsset()

    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertTrue($id > 0);
        $this->assertTrue($year->setYear());
        $this->assertTrue($year->isYearSet());
    }

    function testSaveMethod()
    {
        // TODO needs to be updated
        $year = new Year($this->kernel);
        $this->assertFalse($year->get('id') > 0);
        $this->assertTrue($year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0)) > 0);
        $this->assertEquals('2000', $year->get('label'));

        $new_year = new Year($this->kernel, $year->get('id'), false);
        $this->assertTrue($new_year->save(array('label' => '2000 - edited', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0)) > 0);
        $this->assertEquals($new_year->get('id'), $year->get('id'));
        $this->assertEquals($new_year->get('label'), '2000 - edited');
    }

    function testIsBalancedReturnsTrueWhenNoPostsHasBeenAdded()
    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->assertTrue($year->isBalanced());
    }

    function testGetList()
    {
        $year = new Year($this->kernel);
        $this->assertTrue(is_array($year->getList()));
    }

    function testGetBalanceAccountsThrowsEceptionIfBalanceAccountsIsNotAnArray()
    {
        $year = new Year($this->kernel);
        $id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        try {
            $year->getBalanceAccounts();
            $this->assertTrue(false);
        } catch (Exception $e) {
            $this->assertTrue(true);
        }
    }

    function testCreateAccounts()
    {
        $year = new Year($this->kernel);
        $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $res = $year->createAccounts('standard');
        $this->assertTrue($res);
    }

    function testIsSettingsSet()
    {
        $year = new Year($this->kernel);
        $this->assertFalse($year->isSettingsSet());
    }

    function testGetSettings()
    {
        $year = new Year($this->kernel);
        $this->assertTrue(is_array($year->getSettings()));
    }

    function testSetSettings()
    {
        $year = new Year($this->kernel);
        $data = array();
        $this->assertTrue($year->setSettings($data));
    }

    function testReadyForState()
    {
        $year = new Year($this->kernel);
        $data = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->assertFalse($year->readyForState());
    }

    function testIsYearOpen()
    {
        $year = new Year($this->kernel);
        $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertTrue($year->isYearOpen());
    }

    function testIsDateInYear()
    {
        $year = new Year($this->kernel);
        $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertFalse($year->isDateinYear(date('Y-m-d')));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    function testVatAccountIsSetReturnsTrueWhenVatOnYearIsNotSet()
    {
        $year = new Year($this->kernel);
        $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
        $this->assertTrue($year->vatAccountIsSet());
    }
}


1		<?php
2		require_once 'Intraface/modules/accounting/Year.php';
3		require_once 'Intraface/functions.php';
4
5		class YearTest extends PHPUnit_Framework_TestCase
6		{
7		function setUp()
8		{
9		$this->kernel = new Stub_Kernel();
		0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `kernel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10		$this->kernel->setting->set('intranet', 'vatpercent', 25);
11		$this->kernel->setting->set('user', 'accounting.active_year', 0);
12		$this->kernel->setting->set('intranet', 'accounting.result_account_id', 25);
13		$this->kernel->setting->set('intranet', 'accounting.debtor_account_id', 25);
14		$this->kernel->setting->set('intranet', 'accounting.credit_account_id', 25);
15		$this->kernel->setting->set('intranet', 'accounting.balance_accounts', serialize(array()));
16		$this->kernel->setting->set('intranet', 'accounting.result_account_id_start', 0);
17		$this->kernel->setting->set('intranet', 'accounting.result_account_id_end', 0);
18		$this->kernel->setting->set('intranet', 'accounting.balance_account_id_start', 0);
19		$this->kernel->setting->set('intranet', 'accounting.balance_account_id_end', 0);
20		$this->kernel->setting->set('intranet', 'accounting.capital_account_id', 0);
21
22		$this->kernel->setting->set('intranet', 'accounting.vat_in_account_id', 0);
23		$this->kernel->setting->set('intranet', 'accounting.vat_out_account_id', 0);
24		$this->kernel->setting->set('intranet', 'accounting.vat_abroad_account_id', 0);
25		$this->kernel->setting->set('intranet', 'accounting.vat_balance_account_id', 0);
26		$this->kernel->setting->set('intranet', 'accounting.vat_free_account_id', 0);
27		$this->kernel->setting->set('intranet', 'accounting.eu_sale_account_id', 0);
28		$this->kernel->setting->set('intranet', 'accounting.result_account_id', 0);
29		$this->kernel->setting->set('intranet', 'accounting.debtor_account_id', 0);
30		$this->kernel->setting->set('intranet', 'accounting.credit_account_id', 0);
31		$this->kernel->setting->set('intranet', 'accounting.balance_accounts', serialize(array()));
32		$this->kernel->setting->set('intranet', 'accounting.buy_eu_accounts', serialize(array()));
33		$this->kernel->setting->set('intranet', 'accounting.buy_abroad_accounts', serialize(array()));
34
35		$this->kernel->setting->set('intranet', 'accounting.result_account_id_start', 0);
36		$this->kernel->setting->set('intranet', 'accounting.result_account_id_end', 0);
37		$this->kernel->setting->set('intranet', 'accounting.balance_account_id_start', 0);
38		$this->kernel->setting->set('intranet', 'accounting.balance_account_id_end', 0);
39
40		$this->kernel->setting->set('intranet', 'accounting.capital_account_id', 0);
41		}
42
43		function tearDown()
44		{
45		$db = MDB2::singleton(DB_DSN);
46		$db->exec('TRUNCATE accounting_year');
47		}
48
49		function testSetYearReturnsFalseWhenYearObjectIsNotSet()
50		{
51		$year = new Year($this->kernel);
52		$this->assertFalse($year->setYear());
53		}
54
55	View Code Duplication	function testSetYearReturnsTrueWhenYearObjectIsSet()
		0 ignored issues – show Duplication introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		$year = new Year($this->kernel);
58		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
59		$this->assertTrue($id > 0);
60		$this->assertTrue($year->setYear());
61		$this->assertEquals($id, $year->getActiveYear());
62		}
63
64	View Code Duplication	function testCheckYearReturnsTrueIfActiveYearIsset()
		0 ignored issues – show Duplication introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$year = new Year($this->kernel);
67		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
68		$this->assertTrue($id > 0);
69		$this->assertTrue($year->setYear());
70		$this->assertTrue($year->checkYear());
71		}
72
73		function testCheckYearReturnsFalseIfActiveYearIsNotset()
74		{
75		$year = new Year($this->kernel);
76		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
		0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
77		$this->assertFalse($year->checkYear(false));
78		}
79
80	View Code Duplication	function testIsYearSetReturnsTrueWhenYearIsset()
		0 ignored issues – show Duplication introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		{
82		$year = new Year($this->kernel);
83		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
84		$this->assertTrue($id > 0);
85		$this->assertTrue($year->setYear());
86		$this->assertTrue($year->isYearSet());
87		}
88
89		function testSaveMethod()
90		{
91		// TODO needs to be updated
92		$year = new Year($this->kernel);
93		$this->assertFalse($year->get('id') > 0);
94		$this->assertTrue($year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0)) > 0);
95		$this->assertEquals('2000', $year->get('label'));
96
97		$new_year = new Year($this->kernel, $year->get('id'), false);
98		$this->assertTrue($new_year->save(array('label' => '2000 - edited', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0)) > 0);
99		$this->assertEquals($new_year->get('id'), $year->get('id'));
100		$this->assertEquals($new_year->get('label'), '2000 - edited');
101		}
102
103		function testIsBalancedReturnsTrueWhenNoPostsHasBeenAdded()
104		{
105		$year = new Year($this->kernel);
106		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
		0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
107		$this->assertTrue($year->isBalanced());
108		}
109
110		function testGetList()
111		{
112		$year = new Year($this->kernel);
113		$this->assertTrue(is_array($year->getList()));
114		}
115
116		function testGetBalanceAccountsThrowsEceptionIfBalanceAccountsIsNotAnArray()
117		{
118		$year = new Year($this->kernel);
119		$id = $year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
		0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
120
121		try {
122		$year->getBalanceAccounts();
123		$this->assertTrue(false);
124		} catch (Exception $e) {
125		$this->assertTrue(true);
126		}
127		}
128
129		function testCreateAccounts()
130		{
131		$year = new Year($this->kernel);
132		$year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
133		$res = $year->createAccounts('standard');
134		$this->assertTrue($res);
135		}
136
137		function testIsSettingsSet()
138		{
139		$year = new Year($this->kernel);
140		$this->assertFalse($year->isSettingsSet());
141		}
142
143		function testGetSettings()
144		{
145		$year = new Year($this->kernel);
146		$this->assertTrue(is_array($year->getSettings()));
147		}
148
149		function testSetSettings()
150		{
151		$year = new Year($this->kernel);
152		$data = array();
153		$this->assertTrue($year->setSettings($data));
154		}
155
156		function testReadyForState()
157		{
158		$year = new Year($this->kernel);
159		$data = array();
		0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
160		$this->assertFalse($year->readyForState());
161		}
162
163		function testIsYearOpen()
164		{
165		$year = new Year($this->kernel);
166		$year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
167		$this->assertTrue($year->isYearOpen());
168		}
169
170		function testIsDateInYear()
171		{
172		$year = new Year($this->kernel);
173		$year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
174		$this->assertFalse($year->isDateinYear(date('Y-m-d')));
		0 ignored issues – show Documentation introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `date('Y-m-d')` is of type `string`, but the function expects a `object<date>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
175		}
176
177		function testVatAccountIsSetReturnsTrueWhenVatOnYearIsNotSet()
178		{
179		$year = new Year($this->kernel);
180		$year->save(array('label' => '2000', 'locked' => 0, 'from_date' => '2000-1-1', 'to_date' => '2000-12-31', 'last_year_id' => 0));
181		$this->assertTrue($year->vatAccountIsSet());
182		}
183		}
184

intraface / intraface.dk

Issues (4714)

Security Analysis not enabled

tests/unit/Accounting/YearTest.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like