Issues in ProcurementItem.php (master) - Issues in master - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4714)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Intraface/modules/procurement/ProcurementItem.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Handles items to procurement
 *
 * @package Intraface_Procurement
 * @author Sune Jensen <[email protected]>
 * @author Lars Olesen <[email protected]>
 */

/**
 * Handles items to procurement
 *
 * @package Intraface_Procurement
 * @author Sune Jensen <[email protected]>
 * @author Lars Olesen <[email protected]>
 */
require_once 'Intraface/modules/product/Product.php';

class ProcurementItem extends Intraface_Standard
{
    /**
     * @var integer id of item
     */
    private $id;

    /**
     * @var object DB_sql
     */
    private $db;


    /**
     * @var object procurement
     */
    private $procurement;

    /**
     * @var object product
     */
    private $product;

    /**
     * @var object product variation
     */
    private $product_variation;

    /**
     * @var obejct product variation detail
     */
    private $product_variation_detail;

    /**
     * @var object Ilib_Error
     */
    public $error;

    /**
     * Constructor
     *
     * @param object Procurement
     * @param integer item id
     * @return void

     */
    public function __construct($procurement, $id)

    {
        $this->procurement = $procurement;
        $this->error = new Intraface_Error;
        $this->id = (int) $id;

        if ($this->id > 0) {
            $this->load();
        }
    }

    /**
     * load data to object
     *
     * @return void
     */
    private function load()
    {
        if ($this->id == 0) {
            return;
        }

        $db = new DB_Sql;

        $db->query("SELECT procurement_item.* FROM procurement_item
                    INNER JOIN procurement ON procurement_item.procurement_id = procurement.id
                    WHERE procurement_item.id = " . $this->id . " AND procurement.id = " . $this->procurement->get('id') . " AND procurement_item.intranet_id = " . $this->procurement->kernel->intranet->get("id"));
        if ($db->nextRecord()) {
            $this->value["id"] = $db->f("id");
            $this->value["product_id"] = $db->f("product_id");
            $this->value["product_detail_id"] = $db->f("product_detail_id");
            $this->value["product_variation_id"] = $db->f("product_variation_id");
            $this->value["product_variation_detail_id"] = $db->f("product_variation_detail_id");
            $this->value["unit_purchase_price"] = $db->f("unit_purchase_price");
            $this->value["dk_unit_purchase_price"] = number_format($db->f("unit_purchase_price"), 2, ",", ".");
            $this->value["quantity"] = $db->f("quantity");
        } else {
            $this->id = 0;
            $this->value['id'] = 0;
        }
    }

    /**
     * Returns product object with loaded from item
     *
     * @return object Product
     */
    private function getProduct()

    {
        if (!$this->product) {
            if ($this->get('product_id') == '' || $this->get('product_detail_id') == '') {
                throw new Exception('The item is not loaded');
            }
            $this->product = new Product($this->procurement->kernel, $this->get('product_id'), $this->get('product_detail_id'));
        }
        return $this->product;
    }

    /**
     * Returns Product variation loaded from item
     *
     * @return object Intraface_modules_product_Variation
     */
    private function getProductVariation()

    {
        if (!$this->getProduct()->get('has_variation')) {
            throw new Exception('The product must have variation to request variations');
        }
        if (!$this->product_variation) {
            if (intval($this->get('product_variation_id')) == 0) {
                throw new Exception('The product variation id is not valid on item '.$this->get('id'));
            }
            $this->product_variation = $this->product->getVariation($this->get('product_variation_id'));
        }
        return $this->product_variation;
    }

    /**
     * Returns product variation detail loaded from item
     *
     * @return object Intraface_modules_product_Variation_Detail
     */
    private function getProductVariationDetail()

    {
        if (!$this->getProduct()->get('has_variation')) {
            throw new Exception('The product must have variation to request variations');
        }
        if (!$this->product_variation_detail) {
            if (intval($this->get('product_variation_detail_id')) == 0) {
                throw new Exception('The product variation detail id is not valid on item '.$this->get('id'));
            }
            $this->product_variation_detail = $this->getProductVariation()->getDetail($this->get('product_variation_detail_id'));
        }
        return $this->product_variation_detail;
    }

    /**
     * Returns price of product without vat
     *
     * @return float price of product
     */
    public function getProductPrice()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProductVariationDetail()->getPrice($this->getProduct());
        } else {
            return $this->getProduct()->getDetails()->getPrice();
        }
    }

    /**
     * Returns number of product
     *
     * @return string product number
     */
    public function getProductNumber()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProduct()->get("number").'.'.$this->getProductVariation()->getNumber();
        } else {
            return $this->getProduct()->get("number");
        }
    }

    /**
     * Returns name of product
     *
     * @return string name of product
     */
    public function getProductName()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProduct()->get("name").' - '.$this->getProductVariation()->getName();
        } else {
            return $this->getProduct()->get("name");
        }
    }

    /**
     * Gets the tax percent on the individual product
     *
     * @return float
     */
    public function getProductTaxPercent()
    {
        if ($this->getProduct()->get('vat')) {
            return 25;
        } else {
            return 0;
        }
    }

    /**
     * Saves item
     *
     * @param array input to be saved
     * @return integer id of item
     */
    function save($input)
    {
        $input = safeToDb($input);

        $validator = new Intraface_Validator($this->error);

        settype($input["product_id"], 'integer');
        if ($validator->isNumeric($input["product_id"], "Du skal v�lge et produkt", "greater_than_zero")) {
            if (!isset($input['product_detail_id'])) {
                $input['product_detail_id'] = 0;
            }

            require_once 'Intraface/modules/product/Product.php';
            $product = new Product($this->procurement->kernel, $input["product_id"], $input['product_detail_id']);

            if (!is_object($product) || $product->get('id') == 0) {
                 $this->error->set("Ugyldigt produkt");
            } else {
                $product_detail_id = $product->get("detail_id");
            }

            if (!isset($input['product_variation_id'])) {
                $input['product_variation_id'] = 0;
            }
            if (intval($input['product_variation_id']) != 0) {
                $variation = $product->getVariation(intval($input['product_variation_id']));
                if (!$variation->getId()) {
                    $this->error->set("Invalid product variation");
                }

                if (!isset($input['product_variation_detail_id'])) {
                    $input['product_variation_detail_id'] = 0;
                }
                $detail = $variation->getDetail(intval($input['product_variation_detail_id']));
                if (!$detail->getId()) {
                    $this->error->set("Invalid product variation detail");
                }

                $variation_id = $variation->getId();
                $variation_detail_id = $detail->getId();
            } else {
                $variation_id = 0;
                $variation_detail_id = 0;
            }
        }

        $validator->isNumeric($input["quantity"], "Du skal angive et antal", "greater_than_zero,integer");

        if (!isset($input["dk_unit_purchase_price"])) {
            $input["dk_unit_purchase_price"] = 0;
        }
        $validator->isDouble($input["dk_unit_purchase_price"], "Du skal angive en indk�bspris", "zero_or_greater");
        $unit_purchase_price = new Intraface_Amount($input["dk_unit_purchase_price"]);
        if ($unit_purchase_price->convert2db()) {
            $input["unit_purchase_price"] = $unit_purchase_price->get();
        } else {
            $this->error->set("Invalid purchase price");
        }

        if ($this->error->isError()) {
            return (false);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            exit;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        $sql = "product_id = " . $product->getId() . ",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                product_detail_id = " . $product_detail_id . ",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                product_variation_id = " . $variation_id . ",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                product_variation_detail_id = " . $variation_detail_id . ",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                quantity = " . $input["quantity"] . ",
                unit_purchase_price = " . $input["unit_purchase_price"];

        $db = new DB_Sql;

        if ($this->id == 0) {
            $db->query("INSERT INTO procurement_item SET " . $sql . ", intranet_id = " . $this->procurement->kernel->intranet->get("id") . ", procurement_id = " . $this->procurement->get("id") . ", active = 1");
            $this->id = $db->InsertedId();
        } else {
            $db->query("UPDATE procurement_item SET " . $sql . " WHERE id = " . $this->id . " AND procurement_id = " . $this->procurement->get("id") . " AND intranet_id = " . $this->procurement->kernel->intranet->get("id"));
        }

        return $this->id;
    }

    /**
     * Sets the purchase price of an item
     *
     * @param float $price
     * @return boolean true on success
     */
    public function setPurchasePrice($price)
    {

        if ($this->id == 0) {
            throw new Exception('You can only set purchase price when item has been saved');
        }
        $validator = new Intraface_Validator($this->error);
        if ($validator->isDouble($price, "Ugyldig indk�bspris", "zero_or_greater")) {
            $unit_purchase_price = new Intraface_Amount($price);
            $unit_purchase_price->convert2db();
        }

        if ($this->error->isError()) {
            return false;
        }

        $sql = "unit_purchase_price = " . $unit_purchase_price->get();
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $db = new DB_Sql;
        $db->query("UPDATE procurement_item SET " . $sql . " WHERE id = " . $this->id . " AND procurement_id = " . $this->procurement->get("id") . " AND intranet_id = " . $this->procurement->kernel->intranet->get("id"));
        return true;
    }

    /**
     * Changes the product assigned to the item
     *
     * @param integer $product_id
     * @param integer $product_variation_id
     * @return boolean true on success
     */
    public function changeProduct($product_id, $product_variation_id = 0)
    {
        if (!$this->id) {
            throw new Exception('You cannot change product when not saved');
        }

        require_once 'Intraface/modules/product/Product.php';
        $product = new Product($this->procurement->kernel, $product_id);

        if (!is_object($product) || $product->get('id') == 0) {
             throw new Excetion('Invalid product id');
        } else {
            $product_detail_id = $product->get("detail_id");
        }

        if (intval($product_variation_id) != 0) {
            $variation = $product->getVariation(intval($product_variation_id));
            if (!$variation->getId()) {
                throw new Exception('Invalid product variation id');
            }

            $detail = $variation->getDetail();
            if (!$detail->getId()) {
                throw new Exception("Invalid product variation detail");
            }

            $variation_id = $variation->getId();
            $variation_detail_id = $detail->getId();
        } else {
            $variation_id = 0;
            $variation_detail_id = 0;
        }

        $sql = "product_id = ".$product->getId().",
            product_detail_id = ".$product_detail_id.",
            product_variation_id = ".$variation_id.",
            product_variation_detail_id = ".$variation_detail_id;

        $db = new DB_Sql;
        $db->query("UPDATE procurement_item SET " . $sql . " WHERE id = " . $this->id . " AND procurement_id = " . $this->procurement->get("id") . " AND intranet_id = " . $this->procurement->kernel->intranet->get("id"));

        return true;
    }

    /**
     * Deletes item
     *
     */
    public function delete()

    {
        $db = new DB_Sql;
        $db->query("UPDATE procurement_item SET active = 0 WHERE intranet_id = " . $this->procurement->kernel->intranet->get('id') . " AND id = " . $this->id . " AND procurement_id = " . $this->procurement->get("id"));
        $this->id = 0;

        return 1;
    }

    /**
     * Returns list of items
     *
     * @return array list of items
     */
    public function getList()
    {
        $db = new DB_Sql;
        $db->query("SELECT * FROM procurement_item WHERE active = 1 AND intranet_id = " . $this->procurement->kernel->intranet->get("id") . " AND procurement_id = " . $this->procurement->get("id") . " ORDER BY id ASC");
        $i = 0;
        $item = array ();

        if ($this->procurement->get("price_items") > 0) {
            // calculates shipment etc per item price kr
            $calculated = $this->procurement->get("price_shipment_etc") / $this->procurement->get("price_items");
        } else {
            $calculated = 0;
        }

        while ($db->nextRecord()) {
            $product = new Product($this->procurement->kernel, $db->f("product_id"), $db->f("product_detail_id"));
            $item[$i]["id"] = $db->f("id");

            $unit = $product->get("unit");
            if ($db->f("quantity") == 1) {
                $item[$i]["unit"] = $unit['singular'];
            } else {
                $item[$i]["unit"] = $unit['plural'];
            }
            $item[$i]["unit_purchase_price"] = $db->f("unit_purchase_price");
            $item[$i]["calculated_unit_price"] = $db->f("unit_purchase_price") + $db->f("unit_purchase_price") * $calculated;
            $item[$i]["quantity"] = $db->f("quantity");
            $item[$i]["vat"] = $product->get("vat");
            $item[$i]["product_id"] = $product->get("id");
            $item[$i]["amount"] = $db->f("quantity") * $db->f("unit_purchase_price");

            if ($product->get('has_variation')) {
                $variation = $product->getVariation($db->f('product_variation_id'));
                $detail = $variation->getDetail($db->f('product_variation_detail_id'));
                $item[$i]["name"] = $product->get("name").' - '.$variation->getName();
                $item[$i]["number"]= $product->get("number").'.'.$variation->getNumber();
                $item[$i]["price"] = $detail->getPrice($product);
            } else {
                $item[$i]["name"] = $product->get("name");
                $item[$i]["number"] = $product->get("number");
                $item[$i]["price"] = $product->getDetails()->getPrice();
            }
            $i++;
        }
        return $item;
    }

    /**
     * Returns the quantity of a given product used
     */
    public function getQuantity($status, $product_id, $product_variation_id, $from_date = "")
    {
        if (!in_array($status, array (
                'ordered',
                'delivered'
            ))) {
            throw new Exception("Ugyldig status", FATAL);
        }

        $db = new DB_sql;

        if ($status == "ordered") {
            $db->query("SELECT SUM(quantity) AS on_order
                        FROM procurement_item INNER JOIN procurement
                            ON procurement_item.procurement_id = procurement.id
                        WHERE procurement_item.active = 1 AND procurement.active = 1
                            AND procurement_item.intranet_id = " . $this->procurement->kernel->intranet->get("id") . " AND procurement.intranet_id = " . $this->procurement->kernel->intranet->get("id") . "
                            AND procurement_item.product_id = " . $product_id . " AND procurement.status_key = 0
                            AND procurement_item.product_variation_id = ".$product_variation_id);
            $db->nextRecord(); // a post will always be present
            return intval($db->f("on_order"));
        } else {
            // delivered
            $db->query("SELECT SUM(quantity) AS stock_in
                        FROM procurement_item INNER JOIN procurement
                            ON procurement_item.procurement_id = procurement.id
                        WHERE procurement_item.active = 1 AND procurement.active = 1
                            AND procurement_item.intranet_id = " . $this->procurement->kernel->intranet->get("id") . " AND procurement.intranet_id = " . $this->procurement->kernel->intranet->get("id") . "
                            AND procurement_item.product_id = " . $product_id . "
                            AND procurement_item.product_variation_id = ".$product_variation_id."
                            AND procurement.status_key = 1
                            AND procurement.date_recieved > \"" . $from_date . "\"");
            $db->nextRecord(); // a post will always be present
            return intval($db->f("stock_in"));
        }
    }
}


Issues (4714)

Security Analysis not enabled

Intraface/modules/procurement/ProcurementItem.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

intraface / intraface.dk

Issues (4714)

Security Analysis not enabled

Intraface/modules/procurement/ProcurementItem.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like