Issues in ModuleHandler.php (master) - Issues in master - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4714)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Intraface/ModuleHandler.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Module
 *
 * @package Intraface
 * @author  Lars Olesen <[email protected]>
 * @author  Sune Jensen <[email protected]>
 * @since   0.1.0
 * @version @package-version@
 */
class Intraface_ModuleHandler
{
    private $user;
    private $internet;

    private $modules = array();
    private $primary_module_name;
    private $primary_module_object;
    private $shared = array();

    public function __construct($intranet = '', $user = '')
    {
        $this->user = $user;
        $this->intranet = $intranet;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Returns the primary module
     *
     * Used for instance in Page to give the correct submenu.
     *
     * @return module object or false
     */
    function getPrimaryModule()
    {
        if (!empty($this->modules[$this->primary_module_name]) and is_object($this->modules[$this->primary_module_name])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            return($this->modules[$this->primary_module_name]);
        } else {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
    }

    function setPrimaryModule($module_name)
    {
        if (!empty($this->primary_module_object) and is_object($this->primary_module_object)) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            throw new Exception('Primary module has been set');
        } else {
            $module = $this->useModule($module_name);

            if (is_object($module)) {
                $this->primary_module_name = $module_name;

                // Finds dependent modules
                // @todo Maybe this should be moved to useModule()
                $dependent_modules = $module->getDependentModules();

                foreach ($dependent_modules as $dependent) {
                    $no_use = $this->useModule($dependent);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }

                return $module;
            } else {
                // @todo Den fejlmeddelse er egentlig irrelevant, da useModul ikke enten returnere et objekt eller throw new Exception.
                throw new Exception('Du har ikke adgang til modulet');
            }
        }
    }

    /**
     * useModule()
     *
     * @todo Need to handle access
     *
     * @param  string  $module_name
     * @param  boolean $ignore_user_access
     *
     * @return object  $module
     */
    public function useModule($module_name, $ignore_user_access = false)
    {
        if (!self::isValidModuleName($module_name)) {
            throw new Exception($module_name . ' is not a valid module name');
        }

        if (!empty($this->modules[$module_name]) and is_object($this->modules[$module_name])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            return $this->modules[$module_name];
        }

        $this->modules[$module_name] = $module_name;

        // @todo check whether a module has any limitations in access here? - we have not asked for shared

        // access control here
        $access = false;

        if (!is_object($this->user)) {
            if (!is_object($this->intranet)) {
                throw new Exception('Cannot use a module when no intranet is available');
            }
            // Det er et weblogin.
            if ($this->intranet->hasModuleAccess($module_name)) {
                $access = true;
            }
        } elseif ($ignore_user_access) {
            if (!is_object($this->intranet)) {
                throw new Exception('Cannot use a module when no intranet is available');
            }
            // Skal kun kontrollere om intranettet har adgang, for at benytte modullet
            if ($this->intranet->hasModuleAccess($module_name)) {
                $access = true;
            }
        } else {
            // Almindelig login
            if ($this->user->hasModuleAccess($module_name)) {
                $access = true;
            }
        }

        if ($access !== true) {
            throw new Exception('You need access to a required module to see this page, maybe it is ' . $module_name);
        }

        $main_class_name = "Main" . ucfirst($module_name);
        $main_class_path = PATH_INCLUDE_MODULE . $module_name . "/" . $main_class_name . ".php";

        if (file_exists($main_class_path)) {
            require_once($main_class_path);
            $object = new $main_class_name;
            $object->load($this);
            $this->modules[$module_name] = $object;
            return $object;
        } else {
            // @TODO this should not fail as hard - but what should happen then?
            throw new Exception('ModuleHandler: ' . $main_class_path . ' does not exist');
        }
    }

    /**
     * Gives access to a shared module
     *
     * @param string $shared_name Name on module to load
     *
     * @return object or false
     */
    public function useShared($shared_name)
    {
        if (!self::isValidModuleName($shared_name)) {
            throw new Exception($shared_name. ' is not a valid shared module name');
        }

        // Tjekker om shared allerede er loaded
        if (!empty($this->shared[$shared_name]) and is_object($this->shared[$shared_name])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            return $this->shared[$shared_name];
        }

        $main_shared_name = 'Shared' . ucfirst($shared_name);
        $main_shared_path = PATH_INCLUDE_SHARED . $shared_name . '/' . $main_shared_name . '.php';

        if (file_exists($main_shared_path)) {
            require_once $main_shared_path;
            $object = new $main_shared_name;
            $object->load();
            $this->shared[$shared_name] = $object;
            return $object;
        } else {
            throw new Exception($shared_name . ' cannot be found on ' . $main_shared_path . ' with PATH_INCLUDE_SHARED: ' . PATH_INCLUDE_SHARED);
        }
    }

    /**
     * getModule()
     *
     * @param string $module_name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return object
     */
    function getModule($name)
    {
        if (is_object($this->modules[$name])) {
            return($this->modules[$name]);
        } else {
            throw new Exception('getModule() module ' . $name . ' not loaded');
        }
    }

    /**
     * getModules()
     *
     * @param string $order_by
     *
     * @return array
     */
    public static function getModules($db, $order_by = 'frontpage_index')
    {
        $modules = array();

        if ($order_by != '') {
            $order_by = "ORDER BY ".$db->quoteIdentifier($order_by, 'text');
        }

        $i = 0;
        $result = $db->query("SELECT id, menu_label, name, show_menu FROM module WHERE active = 1 ".$order_by);
        if (PEAR::isError($result)) {
            throw new Exception($result->getUserInfo());
        }
        while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $modules[$i]['id'] = $row['id'];
            $modules[$i]['name'] = $row['name'];
            $modules[$i]['menu_label'] = $row['menu_label'];
            $modules[$i]['show_menu'] = $row['show_menu'];

            $j = 0;
            $result_sub = $db->query("SELECT id, description FROM module_sub_access WHERE active = 1 AND module_id = ".$db->quote($row["id"], 'integer')." ORDER BY description");
            if (PEAR::isError($result_sub)) {
                throw new Exception($result_sub->getUserInfo());
            }

            while ($row_sub = $result_sub->fetchRow(MDB2_FETCHMODE_ASSOC)) {
                $modules[$i]['sub_access'][$j]['id'] = $row_sub['id'];
                $modules[$i]['sub_access'][$j]['description'] = $row_sub['description'];
                $j++;
            }

            $i++;
        }
        return $modules;
    }

    /**
     * Function to check whether the module has been registered
     * Made temporarily for /main/index.php
     */
    public static function exists($db, $module_id)
    {
        if (is_numeric($module_id)) {
            throw new Exception("Not yet implemented!");
        } else {
            $result = $db->query('SELECT id FROM module WHERE name = '.$db->quote($module_id, 'text'));
            if (PEAR::isError($result)) {
                throw new Exception('Error in query: '.$result->getUserInfo());
            }

            if ($result->numRows() > 0) {
                return true;
            } else {
                return false;
            }
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    private static function isValidModuleName($name)
    {
        return preg_match("/^[a-z0-9]+$/", $name);
    }
}


Issues (4714)

Security Analysis not enabled

src/Intraface/ModuleHandler.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

intraface / intraface.dk

Issues (4714)

Security Analysis not enabled

src/Intraface/ModuleHandler.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like