intraface / intraface.dk

src/Intraface/ModuleGateway.php

<?php
/**
 * // @todo could probably extend ModuleHandler, and therefore not need the
 *          constant pointing to the modules.
@package Intraface_IntranetMaintenance
 */
require_once 'Intraface/modules/intranetmaintenance/ModuleMaintenance.php';

class Intraface_ModuleGateway
{
    private $id;

The property $id is not used and could be removed.

    private $db;
    private $value;

The property $value is not used and could be removed.

    public $error;
    private $sub_access;

The property $sub_access is not used and could be removed.

    public function __construct(MDB2_Driver_Common $db)
    {
        $this->db =  $db;
        $this->error = new Intraface_Error;
    }

    function findById($id)
    {
        return new ModuleMaintenance($id);
    }

    function findByName($name)
    {
        $result = $this->db->query("SELECT id FROM module WHERE name = ".$this->db->quote($name, 'text'));
        if (PEAR::isError($result)) {
            throw new Exception("Error in query: ".$result->getUserInfo());
        }

        if ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            return new ModuleMaintenance($row['id']);
        } else {
            throw new Exception("invalid module name ".$name."!");
        }
    }

    public function registerByName($module_name)
    {
        $db = new DB_Sql;
        $updated_sub_access_id = array();
        $module_msg = array();
        $updated_module_id = 0;

        $main_class_name = "Main".ucfirst($module_name);
        $main_class_path = PATH_INCLUDE_MODULE.$module_name."/".$main_class_name.".php";


        if (!file_exists($main_class_path)) {
            $this->error->set("Filen ".$main_class_path." eksistere ikke!");
        } else {
            include_once $main_class_path;
            $module = new $main_class_name;

            if (!is_object($module)) {
                $this->error->set($main_class_name." kunne ikke initialiseres!");
            } else {
                // her kan vi oprette tabellerne n�dvendige for det enkelte modul i stedet for at have dem i starten.

                if (empty($module->menu_label) && empty($module->active) && empty($module->menu_index)) {
                    $this->error->set('Properties for module "'.$module_name.'" er ikke loadet. Kontrol er constructor er sat rigtigt op i modulet');
                } else {
                    $sql = "menu_label = \"".$module->getMenuLabel()."\",
                            show_menu = ".$module->getShowMenu().",
                            active = ".$module->isActive().",
                            menu_index = ".intval($module->getMenuIndex()).",
                            frontpage_index = ".intval($module->getFrontpageIndex()).",
                            required = " . intval($module->isRequired());

                    $db->query("SELECT id FROM module WHERE name = \"".$module_name."\"");
                    if ($db->nextRecord()) {
                        $module_id = $db->f("id");
                        $db->query("UPDATE module SET ".$sql." WHERE id = ".$module_id);
                        $module_msg[$module_name] = "Opdateret";
                    } else {
                        $db->query("INSERT INTO module SET name = \"".$module_name."\", ".$sql);
                        $module_id = $db->insertedId();
                        $module_msg[$module_name] = "Registreret";
                    }
                    $db->free();

                    $updated_module_id = $module_id;
                    $count_subaccess = count($module->sub_access);

                    for ($i = 0; $i < $count_subaccess; $i++) {
                        $db->query("SELECT id FROM module_sub_access WHERE module_id = ".$module_id." AND name = \"".$module->sub_access[$i]."\"");
                        if ($db->nextRecord()) {
                            $updated_sub_access_id[] = $db->f('id');
                            $db->query("UPDATE module_sub_access SET description = \"".$module->sub_access_description[$i]."\", active = 1 WHERE id = ".$db->f("id"));
                        } else {
                            $db->query("INSERT INTO module_sub_access SET module_id = ".$module_id.", name = \"".$module->sub_access[$i]."\", description = \"".$module->sub_access_description[$i]."\", active = 1");
                            $updated_sub_access_id[] = $db->insertedId();
                        }
                        $db->free();
                    }
                }
            }
        }

        return array('module_msg' => $module_msg, 'updated_module_id' => $updated_module_id, 'updated_sub_access_id' => $updated_sub_access_id);
    }

    public function registerAll()
    {
        $msg = array();

$msg is not used, you could remove the assignment.

        $module_msg = array();
        $db = new DB_Sql;
        $updated_sub_access_id = array();

$updated_sub_access_id is not used, you could remove the assignment.

        if ($handle = opendir(PATH_INCLUDE_MODULE)) {
            $updated_module_id = array();
            $updated_sub_access_id = array();

            while (false !== ($module_name = readdir($handle))) {
                if (substr($module_name, 0, 1) == ".") {
                    continue; // starter forfra p� n�ste directory
                }

                if (substr($module_name, 0, 5) == "_old_") {
                    // Det er et slettet modul - det f�r lov at blive uden en besked
                    continue;
                }

                if (!preg_match("/^[a-z0-9]+$/", $module_name)) {
                    $this->error->set($module_name." er et ugyldigt navn");
                    // $msg[] = $module_name." er et ugyldigt navn";

55% of this comment could be valid code. Did you maybe forget this after debugging?

                    continue; // starter forfra p� n�ste directory
                }

                $updated = $this->registerByName($module_name);

                $updated_module_id[] = (int)$updated['updated_module_id'];
                $updated_sub_access_id = array_merge($updated_sub_access_id, $updated['updated_sub_access_id']);
                $module_msg = array_merge($module_msg, $updated['module_msg']);
            }

            // S�tte alle moduler som ikke l�ngere eksistere til active = 0
            if (count($updated_module_id) > 0) {
                $db->query("UPDATE module SET active = 0 WHERE id NOT IN (".implode(",", $updated_module_id).")");
                $module_msg['update'] = $db->affectedRows()." moduler er fjernet og blevet deaktiveret.<br />";
            }

            if (count($updated_sub_access_id) > 0) {
                $db->query("UPDATE module_sub_access SET active = 0 WHERE id NOT IN (".implode(",", $updated_sub_access_id).")");
                $module_msg['update'] .= $db->affectedRows()." sub access' er fjernet og blevet deaktiveret.";
            }
        }

        return $module_msg;
    }

    public function getList()
    {
        $db = new DB_Sql;

        $i = 0;
        $result = $this->db->query("SELECT id, name, menu_label, show_menu, menu_index, frontpage_index FROM module WHERE active = 1 ORDER BY menu_index");
        if (PEAR::isError($result)) {
            throw new Exception("Error in query: ".$result->getUserInfo());
        }

        while ($row = $result->fetchRow()) {
            $value[$i] = $row;

$value was never initialized. Although not strictly required by PHP, it is generally a good practice to add $value = array(); before regardless.

            $j = 0;
            $db->query("SELECT id, name, description FROM module_sub_access WHERE active = 1 AND module_id = ".$row['id']." ORDER BY description");
            while ($db->nextRecord()) {
                $value[$i]["sub_access"][$j]["id"] = $db->f("id");

The variable $value does not seem to be defined for all execution paths leading up to this point.

                $value[$i]["sub_access"][$j]["name"] = $db->f("name");
                $value[$i]["sub_access"][$j]["description"] = $db->f("description");
                $j++;
            }
            $i++;
        }

        return $value;
    }
}