Issues in Restricted.php (master) - Issues in master - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4714)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Intraface/Controller/Restricted.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class Intraface_Controller_Restricted extends k_Component
{
    protected $mdb2;
    protected $db_sql;
    protected $kernel;
    protected $user_gateway;
    protected $kernel_gateway;
    protected $template;
    protected $cache;

    function __construct(Cache_Lite $cache, DB_Sql $db_sql, MDB2_Driver_Common $mdb2, Intraface_UserGateway $gateway, Intraface_KernelGateway $kernel_gateway, k_TemplateFactory $template)
    {
        $this->mdb2 = $mdb2; // this is here to make sure set names utf8 is run as the first thing in the app
        $this->db_sql = $db_sql;
        $this->user_gateway = $gateway;
        $this->kernel_gateway = $kernel_gateway;
        $this->template = $template;
        $this->cache = $cache;
    }

    function document()
    {
        return $this->document;
    }

    protected function map($name)
    {
        if ($name == 'switchintranet') {
            return 'Intraface_Controller_SwitchIntranet';
        } elseif ($name == 'module') {
            return 'Intraface_Controller_ModuleGatekeeper';
        }
    }

    function dispatch()
    {
        if ($this->identity()->anonymous()) {
            throw new k_NotAuthorized();
        }

        return parent::dispatch();
    }

    function renderHtml()
    {
        $this->document->setTitle('Dashboard');

        $_advice[] = array();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $_attention_needed[] = array();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        if (in_array($this->query('message'), array('hide'))) {
            $this->getKernel()->setting->set('user', 'homepage.message', 'hide');
        }

        $kernel = $this->getKernel();

        // getting stuff to show on the dashboard
        $modules = $this->getKernel()->getModules();

        foreach ($modules as $module) {
            if (!$this->getKernel()->intranet->hasModuleAccess(intval($module['id']))) {
                continue;
            }
            if (!$this->getKernel()->user->hasModuleAccess(intval($module['id']))) {
                continue;
            }

            $module = $this->getKernel()->useModule($module['name']);
            $frontpage_files = $module->getFrontpageFiles();

            if (!is_array($frontpage_files) or count($frontpage_files) == 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                continue;
            }

            foreach ($frontpage_files as $file) {
                $file = PATH_INCLUDE_MODULE . $module->getName() . '/' .$file;
                if (file_exists($file)) {
                    include($file);
                }
            }
        }
        // Adds link for id user details is filled in. They are going to be in the top.
        if ($this->getKernel()->user->hasModuleAccess('controlpanel')) {
            if (!$this->getKernel()->user->isFilledIn()) {
                $_advice[] = array(
                    'msg' => 'all information about you has not been filled in',
                    'link' => $this->url('core/restricted/module/controlpanel/user', array('edit')),
                    'module' => 'dashboard'
                );
            }
        }

        $data = array(
            '_attention_needed' => $_attention_needed,
            '_advice' => $_advice
        );

        $smarty = $this->template->create(dirname(__FILE__) . '/templates/restricted');
        return $smarty->render($this, $data);
    }

    function wrapHtml($content)
    {
        if ($this->document()->title() == 'No Title') {
            $this->document->setTitle('Intraface.dk');
        }

        $tpl = $this->template->create(dirname(__FILE__) . '/templates/main');
        $content = $tpl->render($this, array('content' => $content));
        return new k_HttpResponse(200, $content);
    }

    function execute()
    {
        return $this->wrap(parent::execute());
    }

    /**
     * @todo Maybe move to a user object implementing getIntranet()
     * In $intranet we can have the transient gateways.
     *
     * class component_ShowProduct {
     *   protected $user_gateway;
     *   function __construct(UserGateway $user_gateway) {
     *     $this->user_gateway = $user_gateway;
     *   }
     *   function GET() {
     *     $user = $user_gateway->getByUsername($this->identity()->getUsername());
     *     return $this->render('product.tpl.php', array('product' => $user->getIntranet()->getProduct()));
     *   }
     * }
     *
     * http://pastie.org/683209
     *
     * @return object
     */
    function getKernel()
    {
        if (is_object($this->kernel)) {
            return $this->kernel;
        }
        try {
            return $this->kernel = $this->kernel_gateway->findByUserobject($this->user_gateway->findByUsername($this->identity()->user()));
        } catch (Exception $e) {
            return new k_SeeOther($this->url('/logout'));
        }
    }

    function getLastView()
    {
        $last_view = $this->getKernel()->setting->get('user', 'homepage.last_view');
        $this->getKernel()->setting->set('user', 'homepage.last_view', date('Y-m-d H:i:s'));
        return $last_view;
    }

    function getUserMenu()
    {
        $this->usermenu = array();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->usermenu[0]['name'] = $this->t('Logout');
        $this->usermenu[0]['url'] = $this->url('/logout');
        if (count($this->getKernel()->user->getIntranetList()) > 1) {
            $this->usermenu[1]['name'] = $this->t('Switch intranet');
            $this->usermenu[1]['url'] = $this->url('/restricted/switchintranet');
        }
        $this->usermenu[2]['name'] = $this->t('Modules');
        $this->usermenu[2]['url'] = $this->url('/restricted/module');
        $this->usermenu[3]['name'] = $this->t('Control panel');
        $this->usermenu[3]['url'] = $this->url('/restricted/module/controlpanel');

        return $this->usermenu;
    }

    function getMenu()
    {
        $this->menu = array();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $i = 0;
        $this->menu[$i]['name'] = $this->t('dashboard');
        $this->menu[$i]['url'] = $this->url('/restricted/');
        $i++;
        $this->db = new DB_Sql;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->db->query("SELECT name, menu_label, name FROM module WHERE active = 1 AND show_menu = 1 ORDER BY menu_index");
        while ($this->db->nextRecord()) {
            if ($this->getKernel()->user->hasModuleAccess($this->db->f('name'))) {
                $this->menu[$i]['name'] = $this->t($this->db->f('name'));
                $this->menu[$i]['url'] = $this->url('/restricted/module/' . $this->db->f("name"));
                $i++;
            }
        }
        return $this->menu;
    }

    function getSubmenu()
    {
        $this->primary_module = $this->kernel->getPrimaryModule();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->submenu = array();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if (is_object($this->primary_module)) {
            $all_submenu = $this->primary_module->getSubmenu();
            if (count($all_submenu) > 0) { // added to avoid error messages
                $j = 0;
                for ($i = 0, $max = count($all_submenu); $i < $max; $i++) {
                    $access = false;
                    if ($all_submenu[$i]['sub_access'] != '') {
                        $sub = explode(":", $all_submenu[$i]['sub_access']);

                        switch ($sub[0]) {
                            case 'sub_access':
                                if ($this->getKernel()->user->hasSubAccess($this->primary_module->module_name, $sub[1])) {
                                    $access = true;
                                }
                                break;
                            case 'module':
                                if ($this->getKernel()->user->hasModuleAccess($sub[1])) {
                                    $access = true;
                                }
                                break;
                            default:
                                throw new Exception('Der er ikke angivet om submenu skal tjekke efter sub_access eller module adgang, for undermenupunktet i Page->start();');
                                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                        }
                    } else {
                        $access = true;
                    }

                    if ($access) {
                        $this->submenu[$j]['name'] = $this->t($all_submenu[$i]['label']);
                        $this->submenu[$j]['url'] = $this->primary_module->getPath(). $all_submenu[$i]['url'];
                        $j++;
                    }
                }
            }
        }

        return $this->submenu;
    }

    function getIntranetName()
    {
        return $this->getKernel()->intranet->get('name');
        ;
    }
    
    function getThemeKey()
    {
        return $this->getKernel()->setting->get('user', 'theme');
    }

    function getFontSize()
    {
         return $this->getKernel()->setting->get('user', 'ptextsize');
    }
}


Issues (4714)

Security Analysis not enabled

src/Intraface/Controller/Restricted.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

intraface / intraface.dk

Issues (4714)

Security Analysis not enabled

src/Intraface/Controller/Restricted.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like