intraface / intraface.dk

src/DB/Sql.php

<?php
/**
 * This is an old PHP4 database abstraction class. It has be rewritten to use
 * a singleton of PEARs MDB2.
 */
require_once 'MDB2.php';

class DB_Sql
{
    var $db;
    var $row;
    var $result;

    function DB_Sql($dbhost = '', $dbuser = '', $dbpass = '', $dbname = '')

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        if (empty($dbhost) OR empty($dbuser) OR empty($dbpass) OR empty($dbname)) {

Using logical operators such as or instead of || is generally not recommended.

As per coding-style, PHP keywords should be in lowercase; expected or, but found OR.

            $this->db = MDB2::singleton(DB_DSN);
        } else {
            $this->db = MDB2::singleton('mysql://' . $dbuser . ':' . $dbpass . '@' . $dbhost . '/' . $dbname);
        }

        if (PEAR::isError($this->db)) {
            die($this->db->getMessage() . ' ' . $this->db->getUserInfo());

The method DB_Sql() contains an exit expression.

        }
        $this->db->query('SET NAMES utf8');
        $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
    }

    function query($SQL)

This method seems to be duplicated in your project.

    {
        $this->result = $this->db->query($SQL);
        if (PEAR::isError($this->result)) {
            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());

The method query() contains an exit expression.

        }
    }

    function exec($SQL)

This method seems to be duplicated in your project.

    {
        $this->result = $this->db->exec($SQL);
        if (PEAR::isError($this->result)) {
            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());

The method exec() contains an exit expression.

        }

        $this->result->free();
    }

    function nextRecord()

This method seems to be duplicated in your project.

    {
        // Gennemsøger recordset.
        // Går videre til næste post hver gang den kaldes.
        // Returnere true så længe der er en post
        // while($db->next_record()) {

73% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->row = $this->result->fetchRow(MDB2_FETCHMODE_ASSOC);
        if (PEAR::isError($this->row)) {
            die($this->row->getMessage() . '' . $this->row->getUserInfo());

The method nextRecord() contains an exit expression.

        }

        return($this->row);
    }

    function affectedRows()
    {
        // returnere antallet af berørte rækker ved INSERT, UPDATE, DELETE
        // print($db->affected_rows());

80% of this comment could be valid code. Did you maybe forget this after debugging?

        return($this->db->_affectedRows(NULL));

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    }

    function f($name)
    {
        // Returnere værdien fra feltet med navet som er angivet.
        // Print($db->f("felt"));

82% of this comment could be valid code. Did you maybe forget this after debugging?

        return($this->row[$name]);
    }

    function free()
    {
        // Frigør hukommelse til resultatet
        // $db->free();

72% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->result->free();
    }

    function insertedId()
    {
        // Returnere det id som lige er blevet indsat
        // $sidste_id = $db->inserted_id();

55% of this comment could be valid code. Did you maybe forget this after debugging?

        return($this->db->lastInsertID());
    }

    function numRows()
    {
        // Returnere antallet af rækker
        // print($db->num_rows());

80% of this comment could be valid code. Did you maybe forget this after debugging?

        return($this->result->numRows());
    }

    function escape($value)
    {
        return mysql_escape_string($value);

The function mysql_escape_string() has been deprecated with message: Deprecated as of PHP 5.3.0. Relying on this feature is highly discouraged (use mysql_real_escape_string() instead).

    }

    function quote($value, $type)
    {
        return $this->db->quote($value, $type);
    }
}