Issues in Install.php (master) - Issues in master - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4714)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

install/Install.php (16 issues)

Labels

Severity

Lars Olesen 16

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class Intraface_Install
{
    /**
     * @var object database connection
     */
    private $db;

    /**
     * constructor. Checks if the script can be run. Connects to database.
     */
    function __construct()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!defined('SERVER_STATUS') OR SERVER_STATUS == 'PRODUCTION') {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            die('Can not be performed on PRODUCTION SERVER');

        } elseif (!empty($_SERVER['HTTP_HOST']) AND $_SERVER['HTTP_HOST'] == 'www.intraface.dk') {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            die('Can not be performed on www.intraface.dk');

        }

        $this->db = MDB2::singleton(DB_DSN);

        if (PEAR::isError($this->db)) {
            throw new Exception($this->db->getUserInfo());
        }
    }

    function dropDatabase()

    {
        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);
        if (PEAR::isError($result)) {
            throw new Exception($result->getUserInfo());
        }

        while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $drop = $this->db->exec('DROP TABLE ' . $line['tables_in_' . DB_NAME]);
            if (PEAR::IsError($drop)) {
                throw new Exception($drop->getUserInfo());
            }
        }
        return true;
    }

    function createDatabaseSchema()
    {
        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-structure.sql');
        $sql_arr = Intraface_Install::splitSql($sql_structure);

        foreach ($sql_arr as $sql) {
            if (empty($sql)) { continue; }
            $result = $this->db->exec($sql);
            if (PEAR::isError($result)) {
                throw new Exception($result->getUserInfo());
            }
        }

        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-update.sql');
        $sql_arr = Intraface_Install::splitSql($sql_structure);

        foreach ($sql_arr as $sql) {
            if (empty($sql)) { continue; }
            $result = $this->db->exec($sql);
            if (PEAR::isError($result)) {
                throw new Exception($result->getUserInfo());
            }
        }
        return true;
    }

    function emptyDatabase()

    {
        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);
        if (PEAR::isError($result)) {
            throw new Exception($result->getUserInfo());
        }
        while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $truncate = $this->db->exec('TRUNCATE TABLE ' . $line['Tables_in_'.DB_NAME]);
            if (PEAR::IsError($truncate)) {
                throw new Exception($truncate->getUserInfo());
            }
        }
        return true;

    }

    function createStartingValues()
    {
        $sql_values = file_get_contents(dirname(__FILE__) . '/database-values.sql');
        $sql_arr = Intraface_Install::splitSql($sql_values);

        foreach ($sql_arr as $sql) {
            if (empty($sql)) { continue; }
            $result = $this->db->exec($sql);
            if (PEAR::isError($result)) {
                throw new Exception($result->getUserInfo());
            }
        }
        return true;
    }

    function resetServer()
    {
        /*
        if (!$this->dropDatabase()) {
            throw new Exception('could not drop database');
        }
        if (!$this->createDatabaseSchema()) {
            throw new Exception('could not create schema');
        }
        */

        if (!$this->emptyDatabase()) {
            throw new Exception('could not empty database');
        }

        if (!$this->createStartingValues()) {
            throw new Exception('could not create values');
        }

        $this->deleteUploadDirectory(PATH_UPLOAD);

        if (!file_exists(PATH_UPLOAD)) {
            mkdir(PATH_UPLOAD);
        }

        return true;

    }

    function deleteUploadDirectory($f)

    {
        if ( is_dir( $f ) ){
            foreach ( scandir( $f ) as $item ){

                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) )
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
                    continue;
                $this->deleteUploadDirectory( $f . "/" . $item );
            }
            rmdir( $f );
        } else{
            @unlink( $f );
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    /**
     * grants access to given modules
     */
    public function grantModuleAccess($modules)
    {
        $this->registerModules();
        $modules = explode(',', $modules);

        require_once 'Intraface/modules/intranetmaintenance/IntranetMaintenance.php';
        // The moduleaccess only goes for intranet_id 1
        $intranet = new IntranetMaintenance(1);
        require_once 'Intraface/modules/intranetmaintenance/UserMaintenance.php';
        $user = new UserMaintenance(1);
        $user->setIntranetAccess(1);

        require_once 'Intraface/modules/intranetmaintenance/ModuleMaintenance.php';
        foreach ($modules as $module_name) {
            $module = ModuleMaintenance::factory($module_name);

            if ($module->get('id') == 0) {
                throw new Exception('Invalid module '.$module_name);
            }
            $intranet->setModuleAccess($module->get('id'));
            $user->setModuleAccess($module->get('id'), 1);
            $sub_accesss = $module->get('sub_access');
            foreach ($sub_accesss as $sub_access) {
                $user->setSubAccess($module->get('id'), $sub_access['id'], 1);
            }
        }

        return true;

    }

    /**
     * login the user
     */
    function loginUser()
    {
        /* session_start(); */ // session_start is in reset_staging_server. Should only be one place.

        $adapter = new Intraface_Auth_User($this->db, session_id(), '[email protected]', 'startup');
        $auth = new Intraface_Auth(session_id());
        $user = $auth->authenticate($adapter);

        return $user;

    }

    /**
     * run helper functions
     */
    public function runHelperFunction($functions)
    {
        $functions = explode(',', $functions);

        // We create kernel so it can be used in the helper functions
        if (session_id() != '') {
            $kernel = new Intraface_Kernel(session_id());
        } else {
            $kernel = new Intraface_Kernel;
        }
        $kernel->user = new Intraface_User(1);
        $kernel->user->setIntranetId(1);
        $kernel->intranet = new Intraface_Intranet(1);
        $kernel->setting = new Intraface_Setting(1, 1);

        // adds the intranet_id to Doctrine!
        Intraface_Doctrine_Intranet::singleton(1);

        foreach ($functions AS $function) {

            $object_method = explode(':', trim($function));
            $object_method[0] = str_replace('/', '', $object_method[0]);
            $object_method[0] = str_replace('\\', '', $object_method[0]);

            require_once dirname(__FILE__) . '/Helper/'.$object_method[0].'.php';
            $object_name = 'Install_Helper_'.$object_method[0];
            $object = new $object_name($kernel, $this->db);
            $object->$object_method[1]();
        }
    }

    /**
     * register modules
     */
    private function registerModules()
    {
        require_once 'Intraface/modules/intranetmaintenance/ModuleMaintenance.php';
        $modulemaintenance = new ModuleMaintenance;
        $modulemaintenance->register();
    }

    /**
     * splits a mysql export into separate
     */
    static function splitSql($sql)
    {
        if (strpos($sql, "\r\n")) {
            $str_sep = "\r\n";
        } else {
            $str_sep = "\n";
        }
        if (substr($sql, 0, 2) == '--') {
            $sql = substr($sql, strpos($sql, $str_sep));
        }
        $sql = preg_replace($str_sep."/--[a-zA-Z0-9\/\:\`,. _-]*/", '', $sql);
        $parts = preg_split("/;( )*".$str_sep.'/', $sql);
        $parts = array_map('trim', $parts);
        return $parts;

    }
}


Issues (4714)

Security Analysis not enabled

install/Install.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

intraface / intraface.dk

Issues (4714)

Security Analysis not enabled

install/Install.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like