Product::save() - Code Metrics - Inspection of "Composer update" - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#27)

by Lars
created 2017-03-20 07:22 UTC
Product::save() D

↳ Parent: Product
Complexity

Conditions	13
Paths	133
Size

Total Lines	75
Code Lines	34
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	33
CRAP Score	13.3851
Importance

Changes
Metric	Value
cc	13
eloc	34
nc	133
nop	1
dl	0
loc	75
rs	4.94
c	0
b	0
f	0
ccs	33
cts	38
cp	0.8684
crap	13.3851
How to fix Long Method Complexity

<?php
/**
 * Product
 *
 * Bruges til at holde styr p� varerne.
 *
 * @package Intraface_Product
 * @author Lars Olesen <[email protected]>
 * @see ProductDetail
 * @see Stock
 */
require_once 'Intraface/modules/product/ProductDetail.php';

class Product extends Intraface_Standard
{
    /**
     * @var object
     */
    public $kernel;

    /**
     * @var object
     */
    public $user;

    /**
     * @var integer
     */
    private $id;

    /**
     * @var object
     */
    private $detail;

    /**
     * @var integer
     */
    private $old_product_detail_id;

    /**
     * @var array
     */
    public $value = array();

    /**
     * Fields to update
     * @var array
     */
    private $fields;

    /**
     * @var object
     */
    private $db;

    /**
     * @var object
     *
     * Made private now. Please use getStock() instead.
     */
    private $stock;

    /**
     * @var object
     */
    public $error;

    /**
     * @var object
     */
    public $keywords;

    /**
     * @var object
     */
    private $dbquery;

    /**
     * Constructor
     *
     * @param object  $kernel                The kernel object
     * @param integer $product_id            The product id
     * @param integer $old_product_detail_id If we want to find old details, e.g. for an invoice
     *
     * @return void

     */
    function __construct($kernel, $product_id = 0, $old_product_detail_id = 0)
    {
        $this->kernel                = $kernel;
        $this->user                  = $kernel->user;
        $this->intranet              = $kernel->intranet;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->db                    = new DB_Sql;
        $this->id                    = (int)$product_id;
        $this->old_product_detail_id = (int)$old_product_detail_id;
        $this->fields                = array('do_show', 'stock', 'has_variation');
        $this->error                 = new Intraface_Error;

        if ($this->id > 0) {
            $this->id = $this->load();
        }
    }

    /**
     * Used by Keyword
     *
     * @see Keyword
     *
     * @return string
     */
    function identify()
    {
        return 'product';
    }

    /**
     * Creates the dbquery object

     * @return void
     */
    public function getDBQuery()
    {
        if ($this->dbquery) {
            return $this->dbquery;
        }

        $gateway = new Intraface_modules_product_Gateway($this->kernel);
        return $this->dbquery = $gateway->getDBQuery();

        /*

        $this->dbquery = new Intraface_DBQuery($this->kernel, "product", "product.active = 1 AND product.intranet_id = ".$this->intranet->getId());
        $this->dbquery->setJoin("LEFT", "product_detail detail", "detail.product_id = product.id", "detail.active = 1");
        //$this->dbquery->setFindCharacterFromField("detail.name");
        $this->dbquery->useErrorObject($this->error);
        return $this->dbquery;
        */
    }

    /**
     * Loads data into an array
     *
     * Should load both the specific product details, but also the product details
     *
     * @return integer product id or 0
     */
    public function load()
    {
        $this->db->query("SELECT id, active, locked, changed_date, ".implode(',', $this->fields)." FROM product
                WHERE intranet_id = " . $this->kernel->intranet->getId() . "
                    AND id = " . $this->id . " LIMIT 1");

        if (!$this->db->nextRecord()) {
            $this->value['id'] = 0;
            return 0;
        }

        // TODO HACK::HACK::HACK::HACK::HACK::HACK::HACK*

        //
        //  Vi bliver n�dt til at hente value['id'] b�de f�r og efter,
        //  for n�r jeg k�rer arrayet fra produktdetaljerne ind i value
        //  s� sletter det gamle array. Derfor hentes det f�r og efter
        //
        // HACK::HACK::HACK::HACK::HACK::HACK::HACK*


        // hente id
        $this->value['id'] = $this->db->f('id');

        // hente produktdetaljerne
        $this->detail = $this->getDetails();
        $this->value  = $this->detail->get();
        // hente id igen for ovenst�ende har overskrevet det
        $this->value['id']           = $this->db->f('id');
        $this->value['locked']       = $this->db->f('locked');
        $this->value['changed_date'] = $this->db->f('changed_date');
        $this->value['active']       = $this->db->f('active');

        // udtr�k af produktdetaljer
        for ($i = 0, $max = count($this->fields); $i < $max; $i++) {
            $this->value[$this->fields[$i]] = $this->db->f($this->fields[$i]);
        }

        // We now remove stock from load. It can be obtained manaully!
        // $this->getStock();


        // desuden skal copy lige opdateres!
        // hvad med at vi bruger det �verste billede som primary. Det betyder dog, at
        // der skal laves noget position p� AppendFile, men det er jo ogs� smart nok.

        $this->value['id'] = $this->db->f('id');

        $this->db->free();
        return $this->value['id'];
    }

    /**
     * Gets the stock module
     *
     * @return object
     */
    public function getStock()
    {
        if ($this->hasVariation()) {
            throw new Exception('You cannot get stock from product with variations. Use stock for variation');
        }

        if (isset($this->value['stock']) and $this->value['stock'] == 0 and isset($this->value['do_show']) and $this->value['do_show'] == 1) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->value['stock_status'] = array('for_sale' => 100); // kun til at stock_status
        }
        // hvis det er en lagervare og intranettet har adgang til stock skal det startes op

        if ($this->kernel->intranet->hasModuleAccess('stock') and $this->get('stock') == 1) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            if (!is_object($this->stock)) {
                // hvis klassen ikke er startet op skal det ske
                $module = $this->kernel->useModule('stock', true); // true ignorere bruger adgang
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $this->stock                 = new Stock($this);
                $this->value['stock_status'] = $this->stock->get();
            }
            return $this->stock;
        }
        return false;
    }

    function getKernel()
    {
        return $this->kernel;
    }

    /**
     * @todo How should we handle the function to get pictures?
     */
    function getNewPictures()
    {
        require_once 'Intraface/modules/filemanager/AppendFile.php';
        //$filehandler = new Ilib_Filehandler($this->kernel);

        $append_file = new AppendFile($this->kernel, 'product', $this->get('id'));
        $appendix_list = $append_file->getList();

        $this->value['pictures'] = array();

        if (count($appendix_list) > 0) {
            foreach ($appendix_list as $key => $appendix) {
                $tmp_filehandler = new Ilib_Filehandler($this->kernel, $appendix['file_handler_id']);
                $this->value['pictures'][$key]['id']                   = $appendix['file_handler_id'];
                $this->value['pictures'][$key]['original']['icon_uri'] = $tmp_filehandler->get('icon_uri');
                $this->value['pictures'][$key]['original']['name']     = $tmp_filehandler->get('file_name');
                $this->value['pictures'][$key]['original']['width']    = $tmp_filehandler->get('width');
                $this->value['pictures'][$key]['original']['height']   = $tmp_filehandler->get('height');
                $this->value['pictures'][$key]['original']['file_uri'] = $tmp_filehandler->get('file_uri');
                $this->value['pictures'][$key]['appended_file_id']     = $appendix['id'];

                if ($tmp_filehandler->get('is_image')) {
                    $tmp_filehandler->createInstance();

                    $instances = $tmp_filehandler->instance->getList('include_hidden');
                    foreach ($instances as $instance) {
                        $this->value['pictures'][$key][$instance['name']]['file_uri'] = $instance['file_uri'];
                        $this->value['pictures'][$key][$instance['name']]['name']     = $instance['name'];
                        $this->value['pictures'][$key][$instance['name']]['width']    = $instance['width'];
                        $this->value['pictures'][$key][$instance['name']]['height']   = $instance['height'];
                    }
                }
            }
        }
        return $this->value['pictures'];
    }

    /**
     * Gets pictures for the product
     *
     * @return array
     */
    function getPictures()
    {
        $shared_filehandler = $this->kernel->useModule('filemanager');
        $shared_filehandler->includeFile('AppendFile.php');

        $filehandler = new FileHandler($this->kernel);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $append_file = new AppendFile($this->kernel, 'product', $this->get('id'));
        $appendix_list = $append_file->getList();

        $this->value['pictures'] = array();

        if (count($appendix_list) > 0) {
            foreach ($appendix_list as $key => $appendix) {
                $tmp_filehandler = new FileHandler($this->kernel, $appendix['file_handler_id']);
                $this->value['pictures'][$key]['id']                   = $appendix['file_handler_id'];
                $this->value['pictures'][$key]['original']['icon_uri'] = $tmp_filehandler->get('icon_uri');
                $this->value['pictures'][$key]['original']['name']     = $tmp_filehandler->get('file_name');
                $this->value['pictures'][$key]['original']['width']    = $tmp_filehandler->get('width');
                $this->value['pictures'][$key]['original']['height']   = $tmp_filehandler->get('height');
                $this->value['pictures'][$key]['original']['file_uri'] = $tmp_filehandler->get('file_uri');
                $this->value['pictures'][$key]['appended_file_id']     = $appendix['id'];

                if ($tmp_filehandler->get('is_image')) {
                    $tmp_filehandler->createInstance();
                    $instances = $tmp_filehandler->instance->getList('include_hidden');
                    foreach ($instances as $instance) {
                        $this->value['pictures'][$key][$instance['name']]['file_uri'] = $instance['file_uri'];
                        $this->value['pictures'][$key][$instance['name']]['name']     = $instance['name'];
                        $this->value['pictures'][$key][$instance['name']]['width']    = $instance['width'];
                        $this->value['pictures'][$key][$instance['name']]['height']   = $instance['height'];
                    }
                }
                $tmp_filehandler->__destruct();
                unset($tmp_filehandler);
            }
        }
        return $this->value['pictures'];
    }

    /**
     * Validates
     *
     * @param array $array_var The array to validate
     *
     * @return boolean
     */
    private function validate($array_var)
    {
        if (!is_array($array_var)) {
            throw new Exception('Product::save() skal have et array');
        }

        $validator = new Intraface_Validator($this->error);

        if (!$this->isNumberFree($array_var['number'])) {
            $this->error->set('Produktnummeret er ikke frit');
        }

        $validator->isNumeric($array_var['number'], 'Produktnummeret skal v�re et tal');
        settype($array_var['stock'], 'integer');
        $validator->isNumeric($array_var['stock'], 'stock', 'allow_empty');
        settype($array_var['do_show'], 'integer');
        $validator->isNumeric($array_var['do_show'], 'do_show', 'allow_empty');

        if ($this->error->isError()) {
            return false;
        }

        return true;
    }

    /**
     * Saves product
     *
     * @param array $array_var Array with details to save, @see $this->fields
     *
     * @return integer 0 on error
     */
    public function save($array_var)
    {
        if ($this->id > 0 and $this->get('locked') == 1) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->error->set('Produktet er l�st og kan ikke opdateres');
            return 0;
        }

        if (empty($array_var['number']) and $this->get('number') > 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $array_var['number'] = $this->get('number');
        }

        if (empty($array_var['number'])) {
            $array_var['number'] = $this->getMaxNumber() + 1;
        }

        if (!$this->validate($array_var)) {
            return 0;
        }

        // lave sql-s�tningen
        $sql = '';
        /*

        for ($i=0, $max = sizeof($this->fields); $i<$max; $i++) {
            if (!array_key_exists($this->fields[$i], $array_var)) {
                continue;
            }

            if (isset($array_var[$this->fields[$i]])) {
                $sql .= $this->fields[$i]." = '".safeToDb($array_var[$this->fields[$i]])."', ";
            } else {
                $sql .= $this->fields[$i]." = '', ";
            }
        }
        */

        foreach ($this->fields as $field) {
            if (!array_key_exists($field, $array_var)) {
                continue;
            }

            if (isset($array_var[$field])) {
                $sql .= $field." = '".safeToDb($array_var[$field])."', ";
            } else {
                $sql .= $field." = '', ";
            }
        }

        if ($this->id > 0) {
            $sql_type = "UPDATE ";
            $sql_end  = " WHERE id = " . $this->id . " AND intranet_id = " . $this->intranet->getId();
        } else {
            $sql_type = "INSERT INTO";
            $sql_end  = ", intranet_id = " . $this->intranet->getId();
        }

        $this->db->query($sql_type . " product SET ".$sql." changed_date = NOW()"    . $sql_end);

        if (empty($this->id)) {
            $this->id = $this->db->insertedId();
        }

        $this->load();

        // gemme produktdetaljerne
        $product_detail = new ProductDetail($this);
        $product_detail->save($array_var);

        if ($this->error->isError()) {
            return 0;
        }
        $this->load();

        // should return id
        return $this->id;
    }

    /**
     * Copies product to a new product
     *
     * @return integer Id for the new product
     */
    public function copy()
    {
        $product = new Product($this->kernel);
        $product->getKeywords();


        $new_id = $product->save(
            array(
                'name' => $this->get('name') . ' (kopi)',
                'description' => $this->get('description'),
                'price' => amountToForm($this->get('price')), // make sure that this is formatted to local format
                'weight' => (float)$this->get('weight'),
                'unit' => $this->get('unit_key'),
                'vat' => $this->get('vat'),
                'state_account_id' => $this->get('state_account_id'),
                'stock' => $this->get('stock')
            )
        );

        // Relaterede produkter
        $related = $this->getRelatedProducts();
        if (is_array($related) and count($related) > 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            foreach ($related as $p) {
                $product->setRelatedProduct($p['id']);
            }
        }

        // N�gleord
        $appender = $this->getKeywordAppender();
        $this->getKeywords();

        $keywords = $appender->getConnectedKeywords();

        // @todo does not transfer keywords correctly
        if (is_array($keywords)) {
            $appender = $product->getKeywordAppender();
            foreach ($keywords as $k) {
                $appender->addKeyword(new Keyword($this, $k['id']));
            }
        }

        // Billede
        $shared_filehandler = $this->kernel->useModule('filemanager');
        $shared_filehandler->includeFile('AppendFile.php');

        $append_file = new AppendFile($this->kernel, 'product', $product->get('id'));

        $pictures = $this->getPictures();
        if (is_array($pictures)) {
            foreach ($pictures as $pic) {
                $append_file->addFile(new FileHandler($this->kernel, $pic['id']));
            }
        }

        return $new_id;
    }

    /**
     * Deletes product
     *
     * Only set active to 0. Products must never be deleted from the database. It should always be
     * possible to go back to earlier products.
     *
     * @return boolean
     */
    public function delete()
    {
        if ($this->id == 0) {
            $this->error->set('Produktet kan ikke slettes, for produktid er ikke sat');
            return false;
        }
        if ($this->get('locked') == 1) {
            $this->error->set('Produktet kan ikke slettes, for det er l�st.');
            return false;
        }

        $db = new Db_Sql;
        $sql = "UPDATE product
            SET active = 0
            WHERE id = " . $this->id. "
                AND intranet_id = " . $this->intranet->getId() . "
                AND locked = 0";
        $db->query($sql);

        $this->value['active'] = 0;
        return true;
    }

    /**
     * Undeletes a product
     *
     * @return boolean
     */
    public function undelete()
    {
        if ($this->id == 0) {
            $this->error->set('Produktet kan ikke findes igen, for produktid er ikke sat');

            return false;
        }
        $db = new Db_Sql;
        $sql = "UPDATE product
            SET active = 1
            WHERE id = " . $this->id. "
                AND intranet_id = " . $this->intranet->getId();
        $db->query($sql);
        $this->value['active'] = 1;
        return true;
    }

    /**
     * Returnerer det h�jeste produktnummer
     *
     * @return integer produktnummer
     */
    public function getMaxNumber()

    {
        $db = new DB_Sql;
        $sql = "SELECT product_detail.number
            FROM product
            INNER JOIN product_detail
                ON product_detail.product_id = product.id
            WHERE product.intranet_id = " . $this->intranet->getId() . "
            ORDER BY product_detail.number DESC LIMIT 1";
        $db->query($sql);
        if (!$db->nextRecord()) {
            return 0;
        }
        return $db->f('number');
    }

    /**
     * Checks whether number is free
     *
     * @param integer $product_number Product number to check
     *
     * @return boolean
     */
    public function isNumberFree($product_number)
    {
        $product_number = (int)$product_number;

        $db = new DB_Sql;
         $sql = "SELECT product.id FROM product
          INNER JOIN product_detail detail
            ON product.id = detail.product_id
            WHERE detail.number = '" . $product_number . "'
                AND detail.product_id <> " . $this->id . "
                AND detail.active = 1
                AND product.active=1
                AND product.intranet_id = ".$this->intranet->getId()." LIMIT 1";
        $db->query($sql);
        if ($db->numRows() == 0) {
            return true;
        }

        return false;
    }

    /**
     * Get keywords object
     *
     * @deprecated
     *
     * @return object
     */
    public function getKeywords()
    {
        return ($this->keywords = new Keyword($this));
    }

    /**
     * Get keywords object
     *
     * @return object
     */
    public function getKeyword()
    {
        return ($this->keywords = new Keyword($this));
    }


    public function getKeywordAppender()
    {
        return new Intraface_Keyword_Appender($this);
    }

    /**
     * Set related product
     *
     * @param integer $id     Product id to relate to this product
     * @param string  $status Can be relate or remove
     *
     * @return boolean
     */
    public function setRelatedProduct($id, $status = 'relate')
    {
        if (empty($status)) {
            $status = 'remove';
        }

        $db = new DB_Sql;

        if ($status == 'relate') {
            $db->query("SELECT * FROM product_related WHERE product_id=" . $this->id  . " AND related_product_id = " . (int)$id . " AND intranet_id =" .$this->intranet->getId());
            if ($db->nextRecord()) {
                return true;
            }
            if ($id == $this->id) {
                return false;
            }
            $db->query("INSERT INTO product_related SET product_id = " . $this->id . ", related_product_id = " . (int)$id . ", intranet_id = " . $this->intranet->getId());
            return true;
        } else {
            $db->query("DELETE FROM product_related WHERE product_id = " . $this->id . " AND intranet_id = " . $this->intranet->getId() . " AND related_product_id = " . (int)$id);
            return true;
        }
    }

    /**
     * Delete related product
     *
     * @param integer $id     Product id to relate to this product
     *
     * @return boolean
     */
    public function deleteRelatedProduct($id)
    {
        $db = new DB_Sql;
        $db->query("DELETE FROM product_related WHERE product_id = " . $this->id . " AND intranet_id = " . $this->intranet->getId() . " AND related_product_id = " . (int)$id);
        return true;
    }

    /**
     * Delete all related product
     *
     * @param integer $id     Product id to relate to this product
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return boolean
     */
    public function deleteRelatedProducts()
    {
        $db = new DB_Sql;
        $db->query("DELETE FROM product_related WHERE product_id = " . $this->id . " AND intranet_id = " . $this->intranet->getId());
        return true;
    }

    /**
     * Get all related products
     *
     * @return array
     */
    public function getRelatedProducts($currencies = false, $show = 'all')
    {
        $products = array();
        $key      = 0;
        $ids      = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $db       = new DB_Sql;
        $sql      = "SELECT related_product_id FROM product_related WHERE product_id = " . $this->id . " AND intranet_id = " . $this->intranet->getId();
        $db->query($sql);

        // r�kkef�lgen er vigtig - f�rst hente fra product og bagefter tilf�je nye v�rdier til arrayet
        while ($db->nextRecord()) {
            $product                      = new Product($this->kernel, $db->f('related_product_id'));
            if ($product->get('id') == 0 || $product->get('active') == 0 || ($show == 'webshop' && $product->get('do_show') == 0)) {
                continue;
            }
            $products[$key]               = $product->get();
            $products[$key]['related_id'] = $db->f('related_product_id');

            $products[$key]['currency']['DKK']['price'] = $product->getDetails()->getPrice();
            $products[$key]['currency']['DKK']['price_incl_vat'] = $product->getDetails()->getPriceIncludingVat();
            $products[$key]['currency']['DKK']['before_price'] = $product->getDetails()->getBeforePrice();
            $products[$key]['currency']['DKK']['before_price_incl_vat'] = $product->getDetails()->getBeforePriceIncludingVat();

            $products[$key]['pictures'] = $product->getPictures();

            if ($currencies && $currencies->count() > 0) {

                foreach ($currencies as $currency) {

                    $products[$key]['currency'][$currency->getType()->getIsoCode()]['price'] = $product->getDetails()->getPriceInCurrency($currency);
                    $products[$key]['currency'][$currency->getType()->getIsoCode()]['price_incl_vat'] = $product->getDetails()->getPriceIncludingVatInCurrency($currency);
                    $products[$key]['currency'][$currency->getType()->getIsoCode()]['before_price'] = $product->getDetails()->getBeforePriceInCurrency($currency);
                    $products[$key]['currency'][$currency->getType()->getIsoCode()]['before_price_incl_vat'] = $product->getDetails()->getBeforePriceIncludingVatInCurrency($currency);
                }
            }

            if (!$product->hasVariation() and is_object($product->getStock())) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                $products[$key]['stock_status'] = $product->getStock()->get();
            } else {
                // alle ikke lagervarer der skal vises i webshop skal have en for_sale
                if ($product->get('stock') == 0 and $product->get('do_show') == 1) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    $products[$key]['stock_status'] = array('for_sale' => 100); // kun til at stock_status
                } else {
                    $products[$key]['stock_status'] = array();
                }
            }
            // den her skal vist lige kigges igennem, for den tager jo alt med p� nettet?
            // 0 = only stock
            if ($this->kernel->setting->get('intranet', 'webshop.show_online') == 0 and !empty($which) and $which=='webshop') { // only stock
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                if (array_key_exists('for_sale', $products[$key]['stock_status']) and $products[$key]['stock_status']['for_sale'] <= 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    continue;
                }
            }
            $key++;
        }
        return $products;
    }

    function hasVariation()
    {
        return $this->get('has_variation');
    }

    /**
     * Set attribute for product
     *
     * @param integer $id     Attribute id to relate to this product
     *
     * @return boolean
     */
    public function setAttributeGroup($id)
    {
        if (!$this->get('has_variation')) {
            throw new Exception('You can not set attribute group for a product without variations!');
        }

        $db = MDB2::singleton(DB_DSN);
        $result = $db->query("SELECT id FROM product_x_attribute_group WHERE intranet_id = ".$db->quote($this->intranet->getId())." AND product_id=" . $this->getId()  . " AND product_attribute_group_id = " . (int)$id);
        if (PEAR::isError($result)) {
            throw new Exception('Error in query :'.$result->getUserInfo());
        }

        if ($result->numRows() > 0) {
            return true;
        }
        $result = $db->exec("INSERT INTO product_x_attribute_group SET product_id = " . $this->getId() . ", product_attribute_group_id = " . (int)$id . ", intranet_id = " . $this->intranet->getId());
        if (PEAR::isError($result)) {
            throw new Exception('Error in insert :'.$result->getUserInfo());
        }

        return true;
    }

    /**
     * Remove attribute for product
     *
     * @param integer $id     Attribute id to relate to this product
     *
     * @return boolean
     */
    public function removeAttributeGroup($id)
    {
        if (!$this->get('has_variation')) {
            throw new Exception('You can not remove attribute group for a product without variations!');
        }

        $db = MDB2::singleton(DB_DSN);
        $result = $db->exec("DELETE FROM product_x_attribute_group WHERE intranet_id = ".$db->quote($this->intranet->getId())." AND product_id=" . $this->getId()  . " AND product_attribute_group_id = " . (int)$id);
        if (PEAR::isError($result)) {
            throw new Exception('Error in query :'.$result->getUserInfo());
        }

        return ($result > 0);
    }

    /**
     * Get all attributes related to the product
     *
     * @todo Rewrite product_x_attribute_group to Doctrine.
     * @todo Add a field named attribute_number to product_x_attribute_group, to be sure
     *       that a attribute always relates to the correct attribute number on the variation.
     *
     * @return array
     */
    public function getAttributeGroups()
    {
        if (!$this->get('has_variation')) {
            throw new Exception('You can not get attribute groups for a product without variations!');
        }

        // takes groups despite the are deleted. That is probably the best behaviour for now
        // NOTE: Very important that it is ordered by product_attribute_group.id so the groups
        // does always get attached to the correct attribute number on the variation. Se above todo in method doc
        $db = MDB2::singleton(DB_DSN);
        $result = $db->query("SELECT product_attribute_group.* FROM product_x_attribute_group " .
                "INNER JOIN product_attribute_group " .
                    "ON product_x_attribute_group.product_attribute_group_id = product_attribute_group.id " .
                    "AND product_attribute_group.intranet_id = ".$db->quote($this->intranet->getId())." " .
                "WHERE product_x_attribute_group.intranet_id = ".$db->quote($this->intranet->getId())." " .
                    "AND product_x_attribute_group.product_id=" . $this->getId()  . " " .
                 "ORDER BY product_attribute_group.id");

        if (PEAR::isError($result)) {
            throw new Exception('Error in query :'.$result->getUserInfo());
        }

        return $result->fetchAll(MDB2_FETCHMODE_ASSOC);
    }

    /**
     * returns variation
     */
    public function getVariation($id = 0)

    {
        $gateway = new Intraface_modules_product_Variation_Gateway($this);
        if (intval($id) > 0) {
            return $gateway->findById($id);
        }
        $object = $gateway->getObject();
        unset($gateway);
        $object->product_id = $this->getId();
        return $object;
    }

    /**
     * Returns variation on the basis of attributes
     *
     * @param array $attributes Attributes to find variation from
     *        array('attribte1' => [id1], 'attribute2' => [id2]);
     */
    public function getVariationFromAttributes($attributes)
    {
        $gateway = new Intraface_modules_product_Variation_Gateway($this);
        return $gateway->findByAttributes($attributes);
    }

    /**
     * Returns all variations on product
     */
    public function getVariations()
    {
        $gateway = new Intraface_modules_product_Variation_Gateway($this);
        return $gateway->findAll();
    }

    /**
     * Checks whether any products has been created before
     *
     * @return integer
     */
    public function isFilledIn()

    {
        $db = new DB_Sql;
        $db->query("SELECT count(*) AS antal FROM product WHERE intranet_id = " . $this->intranet->getId());
        if ($db->nextRecord()) {
            return $db->f('antal');
        }
        return 0;
    }

    /**
     * Checks whether there is any active products. Differs from isFilledIn() by checking for active = 1
     *
     * @return integer
     */
    public function any()
    {
        $db = new DB_Sql;
        $db->query("SELECT id FROM product WHERE intranet_id = " . $this->intranet->getId()." AND active = 1");
        return $db->numRows();
    }

    public function isActive()
    {
        if ($this->value['active'] == 0) {
            return false;
        }

        return true;
    }

    /**
     * Public: Finde data til en liste
     *
     * Hvis den er fra webshop b�r den faktisk opsamle oplysninger om s�gningen
     * s� man kan se, hvad folk er interesseret i.
     * S�gemaskinen skal v�re tolerant for stavefejl
     *
     * @todo It is wrong to give currencies as parameter. Instead the list should
     *       be given as an object collection, and then currency should be given
     *       to the getPrice method.
     *
     * @param string $which valgfri s�geparameter - ikke aktiv endnu
     * @param object $currencies Collection of valid currencies.
     * @return array indeholdende kundedata til liste
     */
    function getList($which = 'all', $currencies = false)
    {
        $gateway = new Intraface_modules_product_Gateway($this->kernel);
        $gateway->setDBQuery($this->getDBQuery());
        return $gateway->getAllProducts($which, $currencies);

        /*

        switch ($this->getDBQuery()->getFilter('sorting')) {
            case 'date':
                    $this->getDBQuery()->setSorting("product.changed_date DESC");
                break;
            default:
                    $this->getDBQuery()->setSorting("detail.name ASC");
                break;
        }

        if ($search = $this->getDBQuery()->getFilter("search")) {
            $this->getDBQuery()->setCondition("detail.number = '".$search."'
                OR detail.name LIKE '%".$search."%'
                OR detail.description LIKE '%".$search."%'");
        }
        if ($keywords = $this->getDBQuery()->getFilter("keywords")) {
            $this->getDBQuery()->setKeyword($keywords);
        }

        if ($this->getDBQuery()->checkFilter('shop_id') && $this->getDBQuery()->checkFilter('category')) {
            $category_type = new Intraface_Category_Type('shop', $this->getDBQuery()->getFilter('shop_id'));
            $this->getDBQuery()->setJoin(
                'INNER',
                'ilib_category_append',
                'ilib_category_append.object_id = product.id',
                'ilib_category_append.intranet_id = '.$this->kernel->intranet->getId());
            $this->getDBQuery()->setJoin(
                'INNER',
                'ilib_category',
                'ilib_category_append.category_id = ilib_category.id',
                'ilib_category.intranet_id = '.$this->kernel->intranet->getId(). ' ' .
                    'AND ilib_category.belong_to = '.$category_type->getBelongTo().' ' .
                    'AND ilib_category.belong_to_id = '.$category_type->getBelongToId());

            $this->getDBQuery()->setCondition('ilib_category.id = '.$this->getDBQuery()->getFilter("category"));

        }

        if ($ids = $this->getDBQuery()->getFilter("ids")) {
            if (is_array($ids) && count($ids) > 0) {
                $this->getDBQuery()->setCondition("product.id IN (".implode(', ', $ids).")");
            } else {
                $this->getDBQuery()->setCondition('1 = 0');
            }
        }

        // @todo DEN OUTPUTTER IKKE DET RIGTIGE VED KEYWORD
        switch ($which) {
            case 'webshop':
                $this->getDBQuery()->setCondition("product.do_show = 1");
                break;
            case 'stock':
                $this->getDBQuery()->setCondition("product.stock = 1");
                break;
            case 'notpublished':
                $this->getDBQuery()->setCondition("product.do_show = 0");
                break;
            case 'all': // fall through
            default:
                $sql = '';
             break;
        }

        $i        = 0; // til at give arrayet en key
        $db       = $this->getDBQuery()->getRecordset("product.id", "", false);
        $products = array();

        while ($db->nextRecord()) {
            $product = new Product($this->kernel, $db->f("id"));
            $product->getPictures();
            $products[$i] = $product->get();

            $products[$i]['currency']['DKK']['price'] = $product->getDetails()->getPrice();
            $products[$i]['currency']['DKK']['price_incl_vat'] = $product->getDetails()->getPriceIncludingVat();
            $products[$i]['currency']['DKK']['before_price'] = $product->getDetails()->getBeforePrice();
            $products[$i]['currency']['DKK']['before_price_incl_vat'] = $product->getDetails()->getBeforePriceIncludingVat();
            if ($currencies && $currencies->count() > 0) {
                foreach ($currencies AS $currency) {
                    $products[$i]['currency'][$currency->getType()->getIsoCode()]['price'] = $product->getDetails()->getPriceInCurrency($currency);
                    $products[$i]['currency'][$currency->getType()->getIsoCode()]['price_incl_vat'] = $product->getDetails()->getPriceIncludingVatInCurrency($currency);
                    $products[$i]['currency'][$currency->getType()->getIsoCode()]['before_price'] = $product->getDetails()->getBeforePriceInCurrency($currency);
                    $products[$i]['currency'][$currency->getType()->getIsoCode()]['before_price_incl_vat'] = $product->getDetails()->getBeforePriceIncludingVatInCurrency($currency);
                }
            }

            if (!$product->get('has_variation') AND is_object($product->getStock()) AND strtolower(get_class($product->getStock())) == "stock") {
                $products[$i]['stock_status'] = $product->getStock()->get();
            } else {
                // alle ikke lagervarer der skal vises i webshop skal have en for_sale
                if ($product->get('stock') == 0 AND $product->get('do_show') == 1) {
                    $products[$i]['stock_status'] = array('for_sale' => 100); // kun til at stock_status
                } else {
                    $products[$i]['stock_status'] = array();
                }

            }

            // den her skal vist lige kigges igennem, for den tager jo alt med p� nettet?
            // 0 = only stock
            if ($this->kernel->setting->get('intranet', 'webshop.show_online') == 0 AND $which=='webshop') { // only stock
                if (array_key_exists('for_sale', $products[$i]['stock_status']) AND $products[$i]['stock_status']['for_sale'] <= 0) {
                    continue;
                }
            }
            $i++;
        }
        $db->free();
        return $products;
        */
    }

    /**
     * Gets id
     *
     * @return integer
     */
    function getId()
    {
        return $this->id;
    }

    /**
     * Gets the details
     *
     * @return object
     */
    function getDetails()
    {
        return new ProductDetail($this, $this->old_product_detail_id);
    }

    /**
     * returns the possible units
     *
     * @return array units
     */
    public static function getUnits()
    {
        return ProductDetail::getUnits();
    }
}

Pull Request — master (#27)

Product::save() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

intraface / intraface.dk

Pull Request — master (#27)

Product::save() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like
