Completed
Pull Request — master (#26)
by Lars
10:03
created
src/Intraface/Shared.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -60,6 +60,9 @@  discard block
 block discarded – undo
60 60
         return $this->controlpanel_files;
61 61
     }
62 62
 
63
+    /**
64
+     * @param string $file
65
+     */
63 66
     function addPreloadFile($file)
64 67
     {
65 68
         $this->preload_file[] = $file;
@@ -82,6 +85,7 @@  discard block
 block discarded – undo
82 85
 
83 86
     /**
84 87
      * @todo why is this not using getPath()
88
+     * @param string $file
85 89
      */
86 90
     function includeSettingFile($file)
87 91
     {
Please login to merge, or discard this patch.
src/Intraface/XMLRPC/Contact/Server.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
      * Checking credentials
264 264
      *
265 265
      * @param struct $credentials
266
-     * @return array
266
+     * @return boolean
267 267
      */
268 268
     protected function checkCredentials($credentials)
269 269
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@
 block discarded – undo
269 269
     {
270 270
         if (count($credentials) != 2) { // -4
271 271
             require_once 'XML/RPC2/Exception.php';
272
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
272
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
273 273
         }
274 274
         if (empty($credentials['private_key'])) { // -5
275 275
             require_once 'XML/RPC2/Exception.php';
Please login to merge, or discard this patch.
src/Intraface/XMLRPC/Server0100.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      *
53 53
      * @param struct $credentials Credentials to use the server
54 54
      *
55
-     * @return array
55
+     * @return boolean
56 56
      */
57 57
     protected function checkCredentials($credentials)
58 58
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 
71 71
         if (count($credentials) != 2) { // -4
72 72
             require_once 'XML/RPC2/Exception.php';
73
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
73
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
74 74
         }
75 75
         if (empty($credentials['private_key'])) { // -5
76 76
             require_once 'XML/RPC2/Exception.php';
Please login to merge, or discard this patch.
tests/unit/Shop/ShopGatewayTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -18,6 +18,9 @@
 block discarded – undo
18 18
         $result = $this->db->query('TRUNCATE shop');
19 19
     }
20 20
 
21
+    /**
22
+     * @return integer
23
+     */
21 24
     private function createShop($values = array())
22 25
     {
23 26
         $shop = new Intraface_modules_shop_Shop();
Please login to merge, or discard this patch.
tests/unit/Product/ProductDoctrineTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -373,7 +373,7 @@
 block discarded – undo
373 373
         try {
374 374
             $product->setAttributeGroup($group);
375 375
             $this->assertTrue(false, 'An excpetion is not thrown');
376
-        } catch(Exception $e) {
376
+        } catch (Exception $e) {
377 377
             $this->assertEquals('You can not set attribute group for a product without variations!', $e->getMessage());
378 378
         }
379 379
     }
Please login to merge, or discard this patch.
tests/unit/Currency/ExchangeRateTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
         try {
40 40
             $object->save();
41
-        } catch(Exception $e) {
41
+        } catch (Exception $e) {
42 42
             // $this->assertTrue(false, $e->getErrorMessage());
43 43
         }
44 44
     }
Please login to merge, or discard this patch.
tests/unit/Currency/CurrencyTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
         $object->setType($type->getByIsoCode('EUR'));
28 28
         try {
29 29
             $object->save();
30
-        } catch(Exception $e) {
30
+        } catch (Exception $e) {
31 31
             $this->assertTrue(false, $e->getMessage());
32 32
         }
33 33
     }
Please login to merge, or discard this patch.
src/intraface.dk/demo/Demo/Shop/Root.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 
11 11
     function renderHtml()
12 12
     {
13
-        return get_class($this) . ' intentionally left blank';
13
+        return get_class($this).' intentionally left blank';
14 14
     }
15 15
 
16 16
     function getPrivateKey()
Please login to merge, or discard this patch.
src/intraface.dk/demo/Demo/Identifier.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 
11 11
     function renderHtml()
12 12
     {
13
-        return get_class($this) . ' intentionally left blank';
13
+        return get_class($this).' intentionally left blank';
14 14
     }
15 15
 
16 16
     function getPrivateKey()
Please login to merge, or discard this patch.