intraface / intraface.dk

src/Intraface/XMLRPC/Shop/Server0100.php

Doc Comments +4 added lines, -3 removed lines

@@ -250,6 +250,7 @@ 
      * Formats array to return from product list from Doctrine
      *
      * @param object $doctrine_products Doctrine_Collection
+     * @param integer $attribute_id
      * @return array with products
      */
     private function createDoctrineProductsListArray($doctrine_products, $attribute_id = null)
@@ -563,7 +564,6 @@ 
      *
      * @param struct  $credentials Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $id          Product id
      *
      * @return array
      */
@@ -741,7 +741,7 @@ 
      *
      * @param struct  $credentials       Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $produt_id         Product id to add
+     * @param integer $product_id         Product id to add
      * @param integer $product_variation_id Product variation id to change
      * @param integer $quantity          Optional quantity
      * @param string  $text              Extra text to the itemline
@@ -784,7 +784,7 @@ 
      * @param string  $text              Extra text to the itemline
      * @param integer $product_detail_id Product detail id
      *
-     * @return mixed
+     * @return boolean
      */
     public function changeProductInBasket($credentials, $shop_id, $product_id, $product_variation_id, $quantity, $text = '', $product_detail_id = 0)
     {
@@ -1238,6 +1238,7 @@ 
     /**
      * Initialize the webshop
      *
+     * @param integer $shop_id
      * @return void
      */
     private function _factoryWebshop($shop_id)

Indentation +2 added lines, -2 removed lines

@@ -426,7 +426,7 @@ 
         return $this->prepareResponseData($this->cleanUpProductList($product->getRelatedProducts($currencies, 'webshop')));
     }
 
-   /**
+    /**
      * Gets featured products
      *
      * Method is experimental and only used by discimport.dk. If you need to use it
@@ -477,7 +477,7 @@ 
 
     }
 
-   /**
+    /**
      * Gets product keywords which can be used to sort ones webshop
      *
      *

Spacing +14 added lines, -14 removed lines

@@ -72,40 +72,40 @@ 
         }
 
         // sublevel has to be used so other searches are not overwritten
-        $product->getDBQuery()->storeResult('use_stored', 'webshop_' . $area . '_' .  md5($this->credentials['session_id']), 'sublevel');
+        $product->getDBQuery()->storeResult('use_stored', 'webshop_'.$area.'_'.md5($this->credentials['session_id']), 'sublevel');
         $debug2 = serialize($mixed);
         if (isset($mixed['offset']) and is_numeric($mixed['offset']) and $mixed['offset'] > 0) {
             $product->getDBQuery()->useStored(true);
             $product->getDBQuery()->setPagingOffset((int)$mixed['offset']);
-            $debug2 .= 'offset ' . $mixed['offset'];
+            $debug2 .= 'offset '.$mixed['offset'];
         } elseif (isset($mixed['use_stored']) and array_key_exists('use_stored', $mixed) and $mixed['use_stored'] == 'true') {
             $product->getDBQuery()->useStored(true);
             $debug2 .= 'use_stored true';
         } else {
             if (array_key_exists('search', $mixed) and !empty($mixed['search'])) {
                 $product->getDBQuery()->setFilter('search', $mixed['search']);
-                $debug2 .= 'search ' . $mixed['search'];
+                $debug2 .= 'search '.$mixed['search'];
             }
 
             if (array_key_exists('keywords', $mixed) and !empty($mixed['keywords'])) {
                 $product->getDBQuery()->setFilter('keywords', $mixed['keywords']);
-                $debug2 .= 'keyword ' . $mixed['keywords'];
+                $debug2 .= 'keyword '.$mixed['keywords'];
             }
 
             if (array_key_exists('category', $mixed) and !empty($mixed['category'])) {
                 $product->getDBQuery()->setFilter('shop_id', $shop_id);
                 $product->getDBQuery()->setFilter('category', $mixed['category']);
-                $debug2 .= 'category ' . $mixed['category'];
+                $debug2 .= 'category '.$mixed['category'];
             }
 
             if (isset($mixed['ids']) and array_key_exists('ids', $mixed) and is_array($mixed['ids'])) {
                 $product->getDBQuery()->setFilter('ids', $mixed['ids']);
-                $debug2 .= 'ids ' . implode(', ', $mixed['ids']);
+                $debug2 .= 'ids '.implode(', ', $mixed['ids']);
             }
 
             if (array_key_exists('sorting', $mixed) and !empty($mixed['sorting'])) {
                 $product->getDBQuery()->setFilter('sorting', $mixed['sorting']);
-                $debug2 .= 'sorting ' . $mixed['sorting'];
+                $debug2 .= 'sorting '.$mixed['sorting'];
             }
         }
 
@@ -449,7 +449,7 @@ 
 
         if (PEAR::isError($db)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException($db->getMessage() . $db->getUserInfo(), -1);
+            throw new XML_RPC2_FaultException($db->getMessage().$db->getUserInfo(), -1);
         }
 
         $featured = new Intraface_modules_shop_FeaturedProducts($this->kernel->intranet, $this->webshop->getShop(), $db);
@@ -716,7 +716,7 @@ 
 
         if (!$order_id = $this->webshop->placeOrder($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData($this->webshop->getOrderIdentifierKey());
@@ -746,7 +746,7 @@ 
 
         if (!$this->webshop->getBasket()->saveAddress($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -787,7 +787,7 @@ 
         $customer_coupon = $this->processRequestData($customer_coupon);
         if (!$this->webshop->getBasket()->saveCustomerCoupon($customer_coupon)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -828,7 +828,7 @@ 
         $customer_ean = $this->processRequestData($customer_ean);
         if (!$this->webshop->getBasket()->saveCustomerEan($customer_ean)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('ean could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('ean could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -870,7 +870,7 @@ 
         $customer_comment = $this->processRequestData($customer_comment);
         if (!$this->webshop->getBasket()->saveCustomerComment($customer_comment)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -929,7 +929,7 @@ 
         $payment_method = $this->processRequestData($payment_method);
         if (!$this->webshop->getBasket()->savePaymentMethod($payment_method)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);

tests/unit/Accounting/VatPeriodTest.php

Doc Comments +6 added lines

@@ -48,6 +48,9 @@ 
         $this->value['saldo'] = 100;
     }
 
+    /**
+     * @param string $type
+     */
     function getSaldo($type, $date_from, $date_to)
     {
 
@@ -79,6 +82,9 @@ 
         return 1;
     }
 
+    /**
+     * @param integer $id
+     */
     function getAccount($id)
     {
         return new FakeVatPeriodAccount(new FakeVatPeriodYear, $id);

Spacing +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
 
         // ganges med -1 for at f� rigtigt fortegn til udregning
         $this->value['saldo_vat_out'] = $account_vat_in->get('saldo');
-        $saldo_total += -1 * $this->value['saldo_vat_out']; // total
+        $saldo_total += -1*$this->value['saldo_vat_out']; // total
 
 
         // Moms af varek�b i udlandet
@@ -115,7 +115,7 @@ 
 
         // ganges med -1 for at f� rigtigt fortegn til udregning
         $this->value['saldo_vat_abroad'] = $account_vat_abroad->get('saldo');
-        $saldo_total += -1 * $this->value['saldo_vat_abroad'];
+        $saldo_total += -1*$this->value['saldo_vat_abroad'];
 
         // K�bsmoms
         // K�bsmomsen inkluderer ogs� den udregnede moms af moms af varek�b i udlandet.

tests/unit/CMS/CMSStubs.php

Doc Comments +8 added lines

@@ -8,6 +8,10 @@ 
     public $kernel;
     public $cmssite;
     public $dbquery;
+
+    /**
+     * @param FakeCMSSite $site
+     */
     function __construct($site)
     {
         $this->cmssite = $site;
@@ -37,6 +41,10 @@ 
 {
     public $kernel;
     public $cmssite;
+
+    /**
+     * @param FakeCMSPage $page
+     */
     function __construct($page)
     {
         $this->cmspage = $page;

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     {
         $this->cmssite = $site;
         $this->kernel = $site->kernel;
-        $this->dbquery = new Intraface_DBQuery($this->kernel, 'cms_page', 'cms_page.intranet_id = '.$this->kernel->intranet->get('id').' AND cms_page.active = 1 AND site_id = ' . $this->cmssite->get('id'));
+        $this->dbquery = new Intraface_DBQuery($this->kernel, 'cms_page', 'cms_page.intranet_id = '.$this->kernel->intranet->get('id').' AND cms_page.active = 1 AND site_id = '.$this->cmssite->get('id'));
     }
     function get()
     {

tests/unit/CMS/PageTest.php

Doc Comments +3 added lines

@@ -6,6 +6,9 @@
 {
     public $kernel;
 
+    /**
+     * @param Stub_Kernel $kernel
+     */
     function __construct($kernel)
     {
         $this->kernel = $kernel;

tests/unit/CMS/SectionTest.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
     public $kernel;
     public $cmssite;
 
+    /**
+     * @param Stub_Kernel $kernel
+     */
     function __construct($kernel)
     {
         $this->kernel = $kernel;

tests/unit/Common/DBQueryTest.php

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
         }
     }
 
+    /**
+     * @param string $post
+     */
     function createPost($post)
     {
         $result = $this->db->exec('INSERT INTO ' . $this->table . ' (name) VALUES ('.$this->db->quote($post, 'text').')');

Spacing +10 added lines, -10 removed lines

@@ -17,7 +17,7 @@ 
 
         $result = $this->db->exec('TRUNCATE TABLE dbquery_result');
 
-        $result = $this->db->exec('DROP TABLE ' . $this->table);
+        $result = $this->db->exec('DROP TABLE '.$this->table);
         /*
          TODO: DROP THE TABLE IF IT EXISTS
 
@@ -28,7 +28,7 @@ 
         }
         */
 
-        $result = $this->db->exec('CREATE TABLE ' . $this->table . '(
+        $result = $this->db->exec('CREATE TABLE '.$this->table.'(
             id int(11) NOT NULL auto_increment, name varchar(255) NOT NULL, PRIMARY KEY  (id))');
 
         if (PEAR::isError($result)) {
@@ -54,7 +54,7 @@ 
 
     function createPost($post)
     {
-        $result = $this->db->exec('INSERT INTO ' . $this->table . ' (name) VALUES ('.$this->db->quote($post, 'text').')');
+        $result = $this->db->exec('INSERT INTO '.$this->table.' (name) VALUES ('.$this->db->quote($post, 'text').')');
         if (PEAR::isError($result)) {
             die($result->getUserInfo());
         }
@@ -62,7 +62,7 @@ 
 
     function tearDown()
     {
-        $result = $this->db->exec('DROP TABLE ' . $this->table);
+        $result = $this->db->exec('DROP TABLE '.$this->table);
     }
 
     ///////////////////////////////////////////////////////////////////////////
@@ -105,7 +105,7 @@ 
         $this->assertEquals($paging_name, $dbquery->getPagingVarName());
 
         $paging = $dbquery->getPaging();
-        $expected_offset = array(1=>0, 2=>2, 3=>4, 4=>6, 5=>8, 6=>10, 7=>12, 8=>14, 9=>16,10=>18,11=>20);
+        $expected_offset = array(1=>0, 2=>2, 3=>4, 4=>6, 5=>8, 6=>10, 7=>12, 8=>14, 9=>16, 10=>18, 11=>20);
         $this->assertEquals($expected_offset, $paging['offset']);
         $this->assertEquals(0, $paging['previous']);
         $this->assertEquals(2, $paging['next']);
@@ -119,7 +119,7 @@ 
 
         $db = $dbquery->getRecordset('id, name');
         $i = 0;
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $result[$i]['id'] = $db->f('id');
             $result[$i]['name'] = $db->f('name');
             $i++;
@@ -141,7 +141,7 @@ 
         $dbquery->storeResult("use_stored", 'unittest', "toplevel");
         $db = $dbquery->getRecordset('id, name');
         $i = 0;
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $result[$i]['id'] = $db->f('id');
             $result[$i]['name'] = $db->f('name');
             $i++;
@@ -168,7 +168,7 @@ 
         $dbquery->storeResult("use_stored", 'unittest', "toplevel");
         $db = $dbquery->getRecordset('id, name');
         $i = 0;
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $result[$i]['id'] = $db->f('id');
             $result[$i]['name'] = $db->f('name');
             $i++;
@@ -195,7 +195,7 @@ 
         $dbquery->storeResult("use_stored", 'unittest', "toplevel");
         $db = $dbquery->getRecordset('id, name');
         $i = 0;
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $result[$i]['id'] = $db->f('id');
             $result[$i]['name'] = $db->f('name');
             $i++;
@@ -222,7 +222,7 @@ 
         $dbquery->storeResult("use_stored", 'unittest', "toplevel");
         $db = $dbquery->getRecordset('id, name');
         $i = 0;
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $result[$i]['id'] = $db->f('id');
             $result[$i]['name'] = $db->f('name');
             $i++;

tests/unit/Contact/ContactStubs.php

Doc Comments +3 added lines

@@ -4,6 +4,9 @@
     private $id = 1;
     public $kernel;
 
+    /**
+     * @param FakeContactKernel $kernel
+     */
     function __construct($kernel)
     {
         $this->kernel = $kernel;

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 
     function useShared($shared)
     {
-        switch($shared) {
+        switch ($shared) {
             case 'email':
                 require_once 'Intraface/shared/email/Email.php';
                 break;

tests/unit/Debtor/DebtorTest.php

Doc Comments +7 added lines

@@ -63,6 +63,10 @@ 
 class FakeDebtorSetting
 {
 
+    /**
+     * @param string $type
+     * @param string $setting
+     */
     function get($type, $setting)
     {
 
@@ -145,6 +149,9 @@ 
 
     }
 
+    /**
+     * @param Invoice $debtor
+     */
     function createPayment($debtor)
     {
         $payment = new Payment($debtor);

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     }
     function get($key = '')
     {
-        $info = array('name' => 'Intranetname', 'contact_person' => '','id' => 1);
+        $info = array('name' => 'Intranetname', 'contact_person' => '', 'id' => 1);
         if (empty($key)) {
             return $info;
         } else {

tests/unit/Filehandler/file_functions.php

Doc Comments +6 added lines

@@ -1,4 +1,7 @@ 
 <?php
+/**
+ * @param string $f
+ */
 function fht_deltree($f)
 {
 
@@ -16,6 +19,9 @@ 
 }
 
 
+/**
+ * @param string $f
+ */
 function iht_deltree($f)
 {
 

Spacing +4 added lines, -4 removed lines

@@ -7,10 +7,10 @@ 
             if (!strcmp($item, '.') || !strcmp($item, '..')) {
                 continue;
             }
-            fht_deltree($f . "/" . $item);
+            fht_deltree($f."/".$item);
         }
         rmdir($f);
-    } else{
+    } else {
         @unlink($f);
     }
 }
@@ -24,10 +24,10 @@ 
             if (!strcmp($item, '.') || !strcmp($item, '..')) {
                 continue;
             }
-            iht_deltree($f . "/" . $item);
+            iht_deltree($f."/".$item);
         }
         rmdir($f);
-    } else{
+    } else {
         @unlink($f);
     }
 }