intraface / intraface.dk

scripts/user/elevforeningen/newsletter_submit.php

Braces +7 added lines, -3 removed lines

@@ -72,9 +72,13 @@
 $contacts = $contact->getList();
 $i = 0;
 foreach ($contacts as $contact) {
-    if (empty($contact['email'])) continue;
-    if ($subscriber->addContact(new Contact($kernel, $contact['id']))) $i++;
-}
+    if (empty($contact['email'])) {
+        continue;
+    }
+    if ($subscriber->addContact(new Contact($kernel, $contact['id']))) {
+        $i++;
+    }
+    }
 echo $i;
 
 

scripts/user/elevforeningen/ef.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
         continue;
     }
 
-    echo $debtor['id'] . ' order set as sent';
+    echo $debtor['id'].' order set as sent';
     $d = Debtor::factory($kernel, $debtor['id']);
     $d->setStatus('sent');
 

scripts/user/carmakoma_contacts_to_newsletter.php

Spacing +3 added lines, -3 removed lines

@@ -43,9 +43,9 @@ 
 }
 
 while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
-    echo $row['number']. ', ' . $row['id']. ', ' . $row['date_created'] . ', '.$row['email']. ', '. $row['name']. ', ';
+    echo $row['number'].', '.$row['id'].', '.$row['date_created'].', '.$row['email'].', '.$row['name'].', ';
     
-    $newsletter = $db->query('SELECT id FROM newsletter_subscriber WHERE contact_id = '. $row['id']);
+    $newsletter = $db->query('SELECT id FROM newsletter_subscriber WHERE contact_id = '.$row['id']);
     if ($newsletter->numRows() == 0) {
         $subscriber = new NewsletterSubscriber($list);
         $contact = new Contact($kernel, $row['id']);
@@ -60,6 +60,6 @@ 
     $i++;
 }
 
-echo $i. " number of contacts";
+echo $i." number of contacts";
 
 ?>
\ No newline at end of file

scripts/cleanup_database.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 }
 
 if (empty($opts->k) OR empty($opts->fk) OR empty($opts->ft) OR empty($opts->t)) {
-    echo 'not used correctly' . "\n";
+    echo 'not used correctly'."\n";
     exit(1);
 }
 

install/Install.php

Doc Comments +5 added lines

@@ -126,6 +126,9 @@ 
 
     }
 
+    /**
+     * @param string $f
+     */
     function deleteUploadDirectory($f)
     {
         if ( is_dir( $f ) ){
@@ -142,6 +145,7 @@ 
 
     /**
      * grants access to given modules
+     * @param string $modules
      */
     public function grantModuleAccess($modules)
     {
@@ -234,6 +238,7 @@ 
 
     /**
      * splits a mysql export into separate
+     * @param string $sql
      */
     static function splitSql($sql)
     {

Spacing +15 added lines, -15 removed lines

@@ -26,13 +26,13 @@ 
 
     function dropDatabase()
     {
-        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);
+        $result = $this->db->query("SHOW TABLES FROM ".DB_NAME);
         if (PEAR::isError($result)) {
             throw new Exception($result->getUserInfo());
         }
 
         while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
-            $drop = $this->db->exec('DROP TABLE ' . $line['tables_in_' . DB_NAME]);
+            $drop = $this->db->exec('DROP TABLE '.$line['tables_in_'.DB_NAME]);
             if (PEAR::IsError($drop)) {
                 throw new Exception($drop->getUserInfo());
             }
@@ -42,7 +42,7 @@ 
 
     function createDatabaseSchema()
     {
-        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-structure.sql');
+        $sql_structure = file_get_contents(dirname(__FILE__).'/database-structure.sql');
         $sql_arr = Intraface_Install::splitSql($sql_structure);
 
         foreach ($sql_arr as $sql) {
@@ -53,7 +53,7 @@ 
             }
         }
 
-        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-update.sql');
+        $sql_structure = file_get_contents(dirname(__FILE__).'/database-update.sql');
         $sql_arr = Intraface_Install::splitSql($sql_structure);
 
         foreach ($sql_arr as $sql) {
@@ -68,12 +68,12 @@ 
 
     function emptyDatabase()
     {
-        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);
+        $result = $this->db->query("SHOW TABLES FROM ".DB_NAME);
         if (PEAR::isError($result)) {
             throw new Exception($result->getUserInfo());
         }
         while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
-            $truncate = $this->db->exec('TRUNCATE TABLE ' . $line['Tables_in_'.DB_NAME]);
+            $truncate = $this->db->exec('TRUNCATE TABLE '.$line['Tables_in_'.DB_NAME]);
             if (PEAR::IsError($truncate)) {
                 throw new Exception($truncate->getUserInfo());
             }
@@ -84,7 +84,7 @@ 
 
     function createStartingValues()
     {
-        $sql_values = file_get_contents(dirname(__FILE__) . '/database-values.sql');
+        $sql_values = file_get_contents(dirname(__FILE__).'/database-values.sql');
         $sql_arr = Intraface_Install::splitSql($sql_values);
 
         foreach ($sql_arr as $sql) {
@@ -128,15 +128,15 @@ 
 
     function deleteUploadDirectory($f)
     {
-        if ( is_dir( $f ) ){
-            foreach ( scandir( $f ) as $item ){
-                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) )
+        if (is_dir($f)) {
+            foreach (scandir($f) as $item) {
+                if (!strcmp($item, '.') || !strcmp($item, '..'))
                     continue;
-                $this->deleteUploadDirectory( $f . "/" . $item );
+                $this->deleteUploadDirectory($f."/".$item);
             }
-            rmdir( $f );
-        } else{
-            @unlink( $f );
+            rmdir($f);
+        } else {
+            @unlink($f);
         }
     }
 
@@ -215,7 +215,7 @@ 
             $object_method[0] = str_replace('/', '', $object_method[0]);
             $object_method[0] = str_replace('\\', '', $object_method[0]);
 
-            require_once dirname(__FILE__) . '/Helper/'.$object_method[0].'.php';
+            require_once dirname(__FILE__).'/Helper/'.$object_method[0].'.php';
             $object_name = 'Install_Helper_'.$object_method[0];
             $object = new $object_name($kernel, $this->db);
             $object->$object_method[1]();

Braces +3 added lines, -2 removed lines

@@ -130,8 +130,9 @@
     {
         if ( is_dir( $f ) ){
             foreach ( scandir( $f ) as $item ){
-                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) )
-                    continue;
+                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) ) {
+                                    continue;
+                }
                 $this->deleteUploadDirectory( $f . "/" . $item );
             }
             rmdir( $f );

src/Intraface/Amount.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     /**
      * Public: henter beløbet efter konvertering
-     * @return beløb
+     * @return double
      */
     function get()
     {

src/Intraface/Auth.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
     /**
      * hasIdentity()
      *
-     * @return mixed user id or false
+     * @return boolean user id or false
      */
     public function hasIdentity()
     {
@@ -83,7 +83,7 @@ 
     /**
      * Implements the observer pattern
      *
-     * @param object $observer
+     * @param Intraface_Log $observer
      *
      * @return boolean
      */

Spacing +2 added lines, -2 removed lines

@@ -32,9 +32,9 @@
         }
 
         if ($object = $adapter->auth()) {
-            $this->notifyObservers('login', $identification . ' logged in');
+            $this->notifyObservers('login', $identification.' logged in');
         } else {
-            $this->notifyObservers('login', $identification . ' could not login');
+            $this->notifyObservers('login', $identification.' could not login');
         }
 
         return $object;

src/Intraface/Controller/TestLogin.php

Doc Comments +4 added lines

@@ -54,6 +54,10 @@
         return $this->render();
     }
 
+    /**
+     * @param string $username
+     * @param string $password
+     */
     protected function selectUser($username, $password)
     {
         $adapter = new Intraface_Auth_User($this->mdb2, $this->session()->sessionId(), $username, $password);

src/Intraface/Intranet.php

Doc Comments +3 added lines, -4 removed lines

@@ -36,7 +36,6 @@ 
     /**
      * Constructor
      *
-     * @param integer $intranet_id The id of the intranet
      *
      * @return void
      */
@@ -59,7 +58,7 @@ 
     /**
      * loads
      *
-     * @return void
+     * @return integer|null
      */
     function load()
     {
@@ -103,9 +102,9 @@ 
      * @todo might be smarter to throw in an actual module object
      *       that would make us sure that it is actually valid
      *
-     * @param mixed $module The id or name of the module
+     * @param string $module The id or name of the module
      *
-     * @return void
+     * @return boolean
      */
     function hasModuleAccess($module)
     {

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      */
     function hasModuleAccess($module)
     {
-        $filename = PATH_INCLUDE_MODULE . $module . '/Main' . ucfirst($module) . '.php';
+        $filename = PATH_INCLUDE_MODULE.$module.'/Main'.ucfirst($module).'.php';
         if (file_exists($filename)) {
             require_once $filename;
             $module_class = 'Main'.ucfirst($module);