Completed
Pull Request — master (#20)
by Lars
15:27
created
src/Intraface/modules/filemanager/UploadHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
      *       then the filehandler->save method should rather accept some kind of file object which this
71 71
      *       object could generate?
72 72
      *
73
-     * @param object $file_handler A filehandler
73
+     * @param FileHandler $file_handler A filehandler
74 74
      *
75 75
      * @return void
76 76
      */
Please login to merge, or discard this patch.
src/Intraface/modules/intranetmaintenance/IntranetMaintenance.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      * Removes the intranets access to a module
117 117
      *
118 118
      * @param mixed module_id either name or id on module
119
-     * @return boolean true on success
119
+     * @return null|boolean true on success
120 120
      */
121 121
     public function removeModuleAccess($module_id)
122 122
     {
@@ -230,6 +230,7 @@  discard block
 block discarded – undo
230 230
 
231 231
     /**
232 232
      * Saves who the intranet is maintained by
233
+     * @return boolean
233 234
      */
234 235
     public function setMaintainedByUser($id, $current_intranet_id)
235 236
     {
@@ -322,8 +323,7 @@  discard block
 block discarded – undo
322 323
     /**
323 324
      * returns the RandomKeyGenerator
324 325
      *
325
-     * @param integer $length the length of the generated key
326
-     * @return object RandomKeyGenerator
326
+     * @return Ilib_RandomKeyGenerator RandomKeyGenerator
327 327
      */
328 328
     private function getRandomKeyGenerator()
329 329
     {
Please login to merge, or discard this patch.
src/Intraface/modules/intranetmaintenance/ModuleMaintenance.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@
 block discarded – undo
85 85
         }
86 86
     }
87 87
 
88
+    /**
89
+     * @param string $module_name
90
+     */
88 91
     public function registerModule($module_name)
89 92
     {
90 93
         $gateway = new Intraface_ModuleGateway(MDB2::singleton(DB_DSN));
Please login to merge, or discard this patch.
src/Intraface/modules/intranetmaintenance/UserMaintenance.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
      *
96 96
      * @param string $action Which action to perform?
97 97
      *
98
-     * @return void
98
+     * @return boolean
99 99
      */
100 100
     function transactionAction($action)
101 101
     {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/CreditNote.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -15,6 +15,9 @@  discard block
 block discarded – undo
15 15
         parent::__construct($kernel, 'credit_note', $id);
16 16
     }
17 17
 
18
+    /**
19
+     * @param string $status
20
+     */
18 21
     function setStatus($status)
19 22
     {
20 23
         $return = parent::setStatus($status);
@@ -37,6 +40,9 @@  discard block
 block discarded – undo
37 40
         }
38 41
     }
39 42
 
43
+    /**
44
+     * @return boolean
45
+     */
40 46
     function readyForState($year, $check_products = 'check_products')
41 47
     {
42 48
         if (!is_object($year)) {
@@ -94,6 +100,14 @@  discard block
 block discarded – undo
94 100
 
95 101
     }
96 102
 
103
+    /**
104
+     * @param Year $year
105
+     * @param integer $voucher_number
106
+     * @param string $voucher_date
107
+     * @param Stub_Translation $translation
108
+     *
109
+     * @return boolean
110
+     */
97 111
     function state($year, $voucher_number, $voucher_date, $translation)
98 112
     {
99 113
         if (!is_object($year)) {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/Invoice.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,6 +17,9 @@  discard block
 block discarded – undo
17 17
         parent::__construct($kernel, 'invoice', $id);
18 18
     }
19 19
 
20
+    /**
21
+     * @param string $status
22
+     */
20 23
     function setStatus($status)
21 24
     {
22 25
         if ($status == 'cancelled') {
@@ -58,7 +61,7 @@  discard block
 block discarded – undo
58 61
     /**
59 62
      * returns DebtorAccount object
60 63
      *
61
-     * @return object DebtorAccount
64
+     * @return DebtorAccount DebtorAccount
62 65
      */
63 66
     public function getDebtorAccount()
64 67
     {
@@ -150,6 +153,10 @@  discard block
 block discarded – undo
150 153
      * @param object year stating year
151 154
      * @param integer voucher_number
152 155
      * @param string voucher_date
156
+     * @param Year $year
157
+     * @param integer $voucher_number
158
+     * @param string $voucher_date
159
+     * @param Stub_Translation $translation
153 160
      * @return boolean true or false
154 161
      */
155 162
     function state($year, $voucher_number, $voucher_date, $translation)
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/Payment.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -360,10 +360,11 @@  discard block
 block discarded – undo
360 360
     /**
361 361
      * States the payment i the given year
362 362
      *
363
-     * @param object $year Accounting Year object
363
+     * @param Year $year Accounting Year object
364 364
      * @param integer $voucher_number
365 365
      * @param string $voucher_date
366 366
      * @param integer $state_account_number
367
+     * @param Stub_Translation $translation
367 368
      *
368 369
      * @return boolean true on succes or false.
369 370
      */
@@ -454,7 +455,7 @@  discard block
 block discarded – undo
454 455
     /**
455 456
      * returns possible payment types
456 457
      *
457
-     * @return array payment types
458
+     * @return string[] payment types
458 459
      *
459 460
      */
460 461
     public static function getTypes()
@@ -469,7 +470,7 @@  discard block
 block discarded – undo
469 470
     /**
470 471
      * returns the possible types payments can be for.
471 472
      *
472
-     * @return array payment for types
473
+     * @return string[] payment for types
473 474
      */
474 475
     private static function getPaymentForTypes()
475 476
     {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/PaymentGateway.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@  discard block
 block discarded – undo
19 19
         $this->dbquery = $this->getDBQuery();
20 20
     }
21 21
 
22
+    /**
23
+     * @param string|null $id
24
+     */
22 25
     function findById($id)
23 26
     {
24 27
         $db = new DB_Sql;
@@ -113,7 +116,7 @@  discard block
 block discarded – undo
113 116
     /**
114 117
      * returns possible payment types
115 118
      *
116
-     * @return array payment types
119
+     * @return string[] payment types
117 120
      *
118 121
      */
119 122
     public static function getTypes()
@@ -128,7 +131,7 @@  discard block
 block discarded – undo
128 131
     /**
129 132
      * returns the possible types payments can be for.
130 133
      *
131
-     * @return array payment for types
134
+     * @return string[] payment for types
132 135
      */
133 136
     private static function getPaymentForTypes()
134 137
     {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/Pdf/Reminder.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -11,6 +11,9 @@
 block discarded – undo
11 11
     private $db;
12 12
     public $error;
13 13
 
14
+    /**
15
+     * @param Reminder $reminder
16
+     */
14 17
     function __construct($reminder, $id = 0)
15 18
     {
16 19
         $this->reminder = $reminder;
Please login to merge, or discard this patch.